Re: [Qemu-devel] [PATCH] use qemu_malloc and friends consistently

[jcd@tribudubois.net]

Kevin,

I certainly understand your goal ... 

Anyway, I will update my patche and resubmit.

BTW it has to be noted that most of the time the return value of malloc/qemu_malloc is not checked which can also prove problematic whatever the qemu_malloc/malloc behavior is.

JC

----- Mail Original -----
De: "Kevin Wolf" <kwolf@redhat.com>

> I guess that if pattern_count/count is set to 0 we can just avoid the all processing of malloc/memset/memcmp/free anyway.
> 
> Would you be ok with something like:
> 
> if (Pflag && pattern_count) {
> 
> instead of: 
> 
> if (Pflag) {

To be honest, the whole point of my mail was to provoke answers like
Anthony's and get qemu_malloc fixed. ;-)

But sure, the change you propose in qemu-io is fine and will make things
work even with current qemu_malloc.

Kevin