From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 1/2] mem: balanced allocation of hugepages Date: Wed, 21 Jun 2017 11:28:03 +0200 Message-ID: <3310008.zNH8IraLfS@xps> References: <1496756020-4579-1-git-send-email-i.maximets@samsung.com> <3630286.1QuNDLyk9u@xps> <20170621085844.GA93740@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ilya Maximets , dev@dpdk.org, David Marchand , Sergio Gonzalez Monroy , Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei , Jerin Jacob To: Bruce Richardson Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 17A8D37A0 for ; Wed, 21 Jun 2017 11:28:05 +0200 (CEST) In-Reply-To: <20170621085844.GA93740@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/06/2017 10:58, Bruce Richardson: > On Wed, Jun 21, 2017 at 10:51:58AM +0200, Thomas Monjalon wrote: > > 21/06/2017 10:04, Ilya Maximets: > > > +CONFIG_RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES=n > > > > We can stop inserting LIBRTE in our config options. > > CONFIG_RTE_EAL_ is long enough :) > > > Consistency. While I agree it's unneeded should have it in all or none, > and unless we change a bunch of existing ones, I think it means we have > it in all. It is already not consistent. It could be cleaned in next release. For now, we have to decide which one we prefer. I prefer CONFIG_RTE_EAL_ and CONFIG_RTE_PMD_ for drivers.