From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH 0/2] Salvator-X: Add GPIO keys support
Date: Mon, 14 Nov 2016 15:41:46 +0200 [thread overview]
Message-ID: <3311383.qyYI76AWiA@avalon> (raw)
In-Reply-To: <CAMuHMdWwEoH79DnVwret7bK9i-f-tXfSVMRSQdk=k-Ps5PUMGQ@mail.gmail.com>
Hi Geert,
On Monday 14 Nov 2016 14:35:26 Geert Uytterhoeven wrote:
> On Mon, Nov 14, 2016 at 2:07 PM, Laurent Pinchart wrote:
> > This simple series adds GPIO keys support to both the H3- and M3-W-based
> > Salvator-X boards. Please see individual patches for details.
>
> Thanks for your series!
>
> The main reason I haven't sent out a similar series yet is because the GPIOs
> used for the 3 push buttons are shared with the 3 user LEDs. For each of
> them, you have to choose at DT time if you want to use them as buttons or
> as LEDs.
>
> On ULCB, the same issue is present. For those, we settled on 1 key and 2
> LEDs...
>
> Looking forward to more comments...
In theory the GPIOs could be shared by the gpio-keys and LED drivers in open-
drain mode. I'm not sure the GPIO subsystem supports that though.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-11-14 13:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 13:07 [PATCH 0/2] Salvator-X: Add GPIO keys support Laurent Pinchart
2016-11-14 13:07 ` [PATCH 1/2] arm64: dts: r8a7795: salvator-x: " Laurent Pinchart
2016-11-14 13:07 ` [PATCH 2/2] arm64: dts: r8a7796: " Laurent Pinchart
2016-11-14 13:35 ` [PATCH 0/2] Salvator-X: " Geert Uytterhoeven
2016-11-14 13:41 ` Laurent Pinchart [this message]
2016-11-14 13:47 ` Geert Uytterhoeven
2016-11-14 16:44 ` Laurent Pinchart
2016-11-14 19:47 ` Geert Uytterhoeven
2016-11-14 23:59 ` Laurent Pinchart
2016-11-15 7:58 ` Geert Uytterhoeven
2016-11-15 14:26 ` Laurent Pinchart
2016-11-15 14:28 ` Geert Uytterhoeven
2016-11-15 14:28 ` Laurent Pinchart
2016-11-15 20:36 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3311383.qyYI76AWiA@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.