From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 2/2] config: add static linkage of mlx
	dependency
Date: Wed, 09 Jan 2019 11:02:21 +0100
Message-ID: <3313625.hlFx3BV45W@xps>
References: <20190109020524.3633-1-thomas@monjalon.net>
 <20190109020524.3633-2-thomas@monjalon.net>
 <20190109093738.GB2940@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: yskoh@mellanox.com, shahafs@mellanox.com, dev@dpdk.org,
 ferruh.yigit@intel.com
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 02C231B2AB
 for <dev@dpdk.org>; Wed,  9 Jan 2019 11:02:24 +0100 (CET)
In-Reply-To: <20190109093738.GB2940@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/01/2019 10:37, Bruce Richardson:
> On Wed, Jan 09, 2019 at 03:05:24AM +0100, Thomas Monjalon wrote:
> > The libraries provided by rdma-core may be statically linked
> > if enabling CONFIG_RTE_IBVERBS_LINK_STATIC in the make-based build.
> > If CONFIG_RTE_BUILD_SHARED_LIB is disabled,
> > the applications will embed the mlx PMDs with ibverbs and the mlx libraries.
> > If CONFIG_RTE_BUILD_SHARED_LIB is enabled,
> > the mlx PMDs will embed ibverbs and the mlx libraries.
> > 
> > Support with meson may be added later.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> Just to clarify - if there is a shared library build, the idea is to
> actually link in the dependent .a files directly into the .so, rather than
> having the driver .so's track their dependency on the other .so files? What
> is the prospective use-case for this, and can it cause problems? I thought
> it was generally not advisable to be linking in static libraries into
> shared libraries.

Yes that's it.
It is supposed to ease the packaging for some users,
because there are less packages to install on the target host.
For instance, VPP may be interested.

If rdma-core is not linked by the application, I don't see any issue.