All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alban Gruin <alban.gruin@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Why is there still git-rebase--am.sh?
Date: Sun, 02 Jun 2019 13:04:15 +0200	[thread overview]
Message-ID: <3322453.bNc8J3RWDa@andromeda> (raw)

Hi,

I was wandering in rebase’s source code, and found out that even though 
run_specific_rebase() no longer calls git-rebase--am.sh since 21853626ea 
("built-in rebase: call `git am` directly", 2019-01-18), this commit did not 
remove the code to call it.  I guess it was an oversight.

Now that git-legacy-rebase.sh is gone (since d03ebd411c, "rebase: remove the 
rebase.useBuiltin setting", 2019-03-18), I would expect this file to be 
completely removed, too.

May I send a patch to remove git-rebase--am.sh, or is there a reason to keep 
it?

Cheers,
Alban





             reply	other threads:[~2019-06-02 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02 11:04 Alban Gruin [this message]
2019-06-02 11:19 ` Why is there still git-rebase--am.sh? Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3322453.bNc8J3RWDa@andromeda \
    --to=alban.gruin@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.