From: "Martin J. Bligh" <mbligh@aracnet.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: akpm@zip.com.au, linux-kernel@vger.kernel.org
Subject: Re: MAX_IO_APICS #ifdef'd wrongly
Date: Fri, 17 Jan 2003 16:52:28 -0800 [thread overview]
Message-ID: <332970000.1042851147@titus> (raw)
In-Reply-To: <20030117231417.GT919@holomorphy.com>
> I shot for the one liner that fixed the case I could test. Shoving it
> into subarch is cleaner, but needs more code movement and changes the
> prior semantics. The prior semantics were broken for larger Summit
> configurations, hmm. Maybe _all_ the array sizes should go into some
> kind of subarch analogue of param.h, e.g. mach_param.h
That sounds like the right thing to do longer-term ... let's change it
to the defn below for now, so people's trees work, then have a proper
think about to organise subarch to make this stuff work easily
(no doubt there's other gremlins there to be fixed at the same time).
M.
diff -urpN -X /home/fletch/.diff.exclude virgin/include/asm-i386/apicdef.h max_io_apics/include/asm-i386/apicdef.h
--- virgin/include/asm-i386/apicdef.h Fri Jan 17 09:18:31 2003
+++ max_io_apics/include/asm-i386/apicdef.h Fri Jan 17 16:49:41 2003
@@ -115,7 +115,7 @@
#define APIC_BASE (fix_to_virt(FIX_APIC_BASE))
-#ifdef CONFIG_X86_NUMA
+#ifdef CONFIG_NUMA
#define MAX_IO_APICS 32
#else
#define MAX_IO_APICS 8
prev parent reply other threads:[~2003-01-18 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-17 9:00 MAX_IO_APICS #ifdef'd wrongly William Lee Irwin III
2003-01-17 15:53 ` Martin J. Bligh
2003-01-17 23:14 ` William Lee Irwin III
2003-01-18 0:52 ` Martin J. Bligh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=332970000.1042851147@titus \
--to=mbligh@aracnet.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.