From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Fri, 20 Apr 2018 15:13:17 +0000 Subject: Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST Message-Id: <3329803.Cv7XkTmsQk@amdc3058> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , linux-omap@vger.kernel.org, Linux Media Mailing List On Thursday, April 05, 2018 04:29:42 PM Mauro Carvalho Chehab wrote: > This driver builds cleanly with COMPILE_TEST, and it is > needed in order to allow building drivers/media omap2 > driver. > > So, change the logic there to allow building it. > > Signed-off-by: Mauro Carvalho Chehab This change has broken build on OF=n && COMPILE_TEST=y configs: https://patchwork.kernel.org/patch/10352465/ [ This is not a problem when compiling for OMAP2 because it depends on ARM Multiplatform support which (indirectly) selects OF. ] Also I would really prefer that people won't merge fbdev related patches without my ACK and I see this patch in -next coming from one of your trees.. > --- > drivers/video/fbdev/omap2/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig > index 0921c4de8407..82008699d253 100644 > --- a/drivers/video/fbdev/omap2/Kconfig > +++ b/drivers/video/fbdev/omap2/Kconfig > @@ -1,4 +1,4 @@ > -if ARCH_OMAP2PLUS > +if ARCH_OMAP2PLUS || COMPILE_TEST > > source "drivers/video/fbdev/omap2/omapfb/Kconfig" Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST Date: Fri, 20 Apr 2018 17:13:17 +0200 Message-ID: <3329803.Cv7XkTmsQk@amdc3058> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , linux-omap@vger.kernel.org, Linux Media Mailing List List-Id: linux-omap@vger.kernel.org T24gVGh1cnNkYXksIEFwcmlsIDA1LCAyMDE4IDA0OjI5OjQyIFBNIE1hdXJvIENhcnZhbGhvIENo ZWhhYiB3cm90ZToKPiBUaGlzIGRyaXZlciBidWlsZHMgY2xlYW5seSB3aXRoIENPTVBJTEVfVEVT VCwgYW5kIGl0IGlzCj4gbmVlZGVkIGluIG9yZGVyIHRvIGFsbG93IGJ1aWxkaW5nIGRyaXZlcnMv bWVkaWEgb21hcDIKPiBkcml2ZXIuCj4gCj4gU28sIGNoYW5nZSB0aGUgbG9naWMgdGhlcmUgdG8g YWxsb3cgYnVpbGRpbmcgaXQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWF1cm8gQ2FydmFsaG8gQ2hl aGFiIDxtY2hlaGFiQHMtb3BlbnNvdXJjZS5jb20+CgpUaGlzIGNoYW5nZSBoYXMgYnJva2VuIGJ1 aWxkIG9uIE9GPW4gJiYgQ09NUElMRV9URVNUPXkgY29uZmlnczoKCmh0dHBzOi8vcGF0Y2h3b3Jr Lmtlcm5lbC5vcmcvcGF0Y2gvMTAzNTI0NjUvCgpbIFRoaXMgaXMgbm90IGEgcHJvYmxlbSB3aGVu IGNvbXBpbGluZyBmb3IgT01BUDIgYmVjYXVzZSBpdCBkZXBlbmRzCiAgb24gQVJNIE11bHRpcGxh dGZvcm0gc3VwcG9ydCB3aGljaCAoaW5kaXJlY3RseSkgc2VsZWN0cyBPRi4gXQoKQWxzbyBJIHdv dWxkIHJlYWxseSBwcmVmZXIgdGhhdCBwZW9wbGUgd29uJ3QgbWVyZ2UgZmJkZXYgcmVsYXRlZApw YXRjaGVzIHdpdGhvdXQgbXkgQUNLIGFuZCBJIHNlZSB0aGlzIHBhdGNoIGluIC1uZXh0IGNvbWlu ZyBmcm9tCm9uZSBvZiB5b3VyIHRyZWVzLi4KCj4gLS0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYv b21hcDIvS2NvbmZpZyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIv S2NvbmZpZyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvS2NvbmZpZwo+IGluZGV4IDA5MjFj NGRlODQwNy4uODIwMDg2OTlkMjUzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmlkZW8vZmJkZXYv b21hcDIvS2NvbmZpZwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvS2NvbmZpZwo+ IEBAIC0xLDQgKzEsNCBAQAo+IC1pZiBBUkNIX09NQVAyUExVUwo+ICtpZiBBUkNIX09NQVAyUExV UyB8fCBDT01QSUxFX1RFU1QKPiAgCj4gIHNvdXJjZSAiZHJpdmVycy92aWRlby9mYmRldi9vbWFw Mi9vbWFwZmIvS2NvbmZpZyIKCkJlc3QgcmVnYXJkcywKLS0KQmFydGxvbWllaiBab2xuaWVya2ll d2ljegpTYW1zdW5nIFImRCBJbnN0aXR1dGUgUG9sYW5kClNhbXN1bmcgRWxlY3Ryb25pY3MKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:52593 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755393AbeDTPNc (ORCPT ); Fri, 20 Apr 2018 11:13:32 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180420151330euoutp014d993dc684e47a443c54a1da15c7b7f8~nLaq4VmZR1131211312euoutp01R for ; Fri, 20 Apr 2018 15:13:30 +0000 (GMT) From: Bartlomiej Zolnierkiewicz To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Tomi Valkeinen , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST Date: Fri, 20 Apr 2018 17:13:17 +0200 Message-ID: <3329803.Cv7XkTmsQk@amdc3058> In-Reply-To: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" References: Sender: linux-media-owner@vger.kernel.org List-ID: On Thursday, April 05, 2018 04:29:42 PM Mauro Carvalho Chehab wrote: > This driver builds cleanly with COMPILE_TEST, and it is > needed in order to allow building drivers/media omap2 > driver. > > So, change the logic there to allow building it. > > Signed-off-by: Mauro Carvalho Chehab This change has broken build on OF=n && COMPILE_TEST=y configs: https://patchwork.kernel.org/patch/10352465/ [ This is not a problem when compiling for OMAP2 because it depends on ARM Multiplatform support which (indirectly) selects OF. ] Also I would really prefer that people won't merge fbdev related patches without my ACK and I see this patch in -next coming from one of your trees.. > --- > drivers/video/fbdev/omap2/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig > index 0921c4de8407..82008699d253 100644 > --- a/drivers/video/fbdev/omap2/Kconfig > +++ b/drivers/video/fbdev/omap2/Kconfig > @@ -1,4 +1,4 @@ > -if ARCH_OMAP2PLUS > +if ARCH_OMAP2PLUS || COMPILE_TEST > > source "drivers/video/fbdev/omap2/omapfb/Kconfig" Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics