From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 01/17] ixgbe: use the right debug macro
Date: Tue, 02 Sep 2014 16:21:18 +0200 [thread overview]
Message-ID: <3333103.135tnuTvaT@xps13> (raw)
In-Reply-To: <CALwxeUuC2O-YqB8yG01ZiBE2C7qQeCR2Km2gQ0i1fk+CHqXJ2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-02 16:16, David Marchand:
> >> /* Macros to check for invlaid function pointers. */
Invlaid is an invalid word ;)
> >> -#define FUNC_PTR_OR_ERR_RET(func, retval) do { \
> >> - if ((func) == NULL) { \
> >> - DEBUGOUT("%s:%d function not supported\n", \
> >> - __func__, __LINE__); \
> >> - return (retval); \
> >> - } \
> >> +#define FUNC_PTR_OR_ERR_RET(func, retval) do { \
> >> + if ((func) == NULL) { \
> >> + PMD_DRV_LOG("%s:%d function not supported", \
> >> + __func__, __LINE__); \
> >> + return retval; \
> >>
> > Need to keep the parens around retval in your macro
>
> Actually, checkpatch complained about this.
> So I can keep the parenthesis, but then I don't want Thomas to tell me my
> patch does not pass checkpatch :-)
You're right, I care about checkpatch :)
I don't see a case where parens are needed with return. Please give an example.
--
Thomas
next prev parent reply other threads:[~2014-09-02 14:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 10:24 [PATCH v2 00/17] cleanup logs in main PMDs David Marchand
[not found] ` <1409567080-27083-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-01 10:24 ` [PATCH v2 01/17] ixgbe: use the right debug macro David Marchand
[not found] ` <1409567080-27083-2-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-02 13:43 ` Jay Rolette
[not found] ` <CADNuJVpLLfiC_ROBkYQguHUGTgXNC1Bdu7HwveXcA23_Q3twxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-02 14:16 ` David Marchand
[not found] ` <CALwxeUuC2O-YqB8yG01ZiBE2C7qQeCR2Km2gQ0i1fk+CHqXJ2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-02 14:21 ` Thomas Monjalon [this message]
2014-09-02 17:57 ` Jay Rolette
2014-09-01 10:24 ` [PATCH v2 02/17] ixgbe/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [PATCH v2 03/17] ixgbe: clean log messages David Marchand
[not found] ` <1409567080-27083-4-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-02 15:19 ` Jay Rolette
2014-09-01 10:24 ` [PATCH v2 04/17] ixgbe: always log init messages David Marchand
2014-09-01 10:24 ` [PATCH v2 05/17] ixgbe: add a message when forcing scatter mode David Marchand
2014-09-01 10:24 ` [PATCH v2 06/17] ixgbe: add log messages when rx bulk mode is not usable David Marchand
2014-09-01 10:24 ` [PATCH v2 07/17] i40e: use the right debug macro David Marchand
[not found] ` <1409567080-27083-8-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-02 18:25 ` Jay Rolette
2014-09-01 10:24 ` [PATCH v2 08/17] i40e/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [PATCH v2 09/17] i40e: clean log messages David Marchand
[not found] ` <1409567080-27083-10-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-02 18:20 ` Jay Rolette
2014-09-01 10:24 ` [PATCH v2 10/17] i40e: always log init messages David Marchand
2014-09-01 10:24 ` [PATCH v2 11/17] i40e: add log messages when rx bulk mode is not usable David Marchand
2014-09-01 10:24 ` [PATCH v2 12/17] e1000: use the right debug macro David Marchand
[not found] ` <1409567080-27083-13-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-02 18:29 ` Jay Rolette
2014-09-01 10:24 ` [PATCH v2 13/17] e1000/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [PATCH v2 14/17] e1000: clean log messages David Marchand
[not found] ` <1409567080-27083-15-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-02 19:05 ` Jay Rolette
[not found] ` <CADNuJVqhOy6AfYO5OuUn=kmQsBVkwrRunXKXKkQ88bexPtWgsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-02 19:19 ` David Marchand
2014-09-01 10:24 ` [PATCH v2 15/17] e1000: always log init messages David Marchand
2014-09-01 10:24 ` [PATCH v2 16/17] e1000: add a message when forcing scatter mode David Marchand
[not found] ` <1409567080-27083-17-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-09-02 19:20 ` David Marchand
2014-09-01 10:24 ` [PATCH v2 17/17] eal: set log level from command line David Marchand
2014-09-12 12:32 ` [PATCH v2 00/17] cleanup logs in main PMDs Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3333103.135tnuTvaT@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.