From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V1AqQ-0004fZ-7w for mharc-grub-devel@gnu.org; Mon, 22 Jul 2013 03:47:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1AqM-0004fJ-SS for grub-devel@gnu.org; Mon, 22 Jul 2013 03:47:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1AqL-0003lE-Sx for grub-devel@gnu.org; Mon, 22 Jul 2013 03:47:42 -0400 Received: from collab.rosalab.ru ([195.19.76.181]:44673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1AqL-0003kV-LQ for grub-devel@gnu.org; Mon, 22 Jul 2013 03:47:41 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by collab.rosalab.ru (Postfix) with ESMTP id B282E29C230; Mon, 22 Jul 2013 11:47:39 +0400 (MSK) X-Virus-Scanned: amavisd-new at rosalab.ru Received: from collab.rosalab.ru ([127.0.0.1]) by localhost (collab.rosalab.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uRQDJ8jWppxw; Mon, 22 Jul 2013 11:47:39 +0400 (MSK) Received: from icedphoenix.localnet (unknown [217.199.216.178]) by collab.rosalab.ru (Postfix) with ESMTPSA id 2D18429C1AA; Mon, 22 Jul 2013 11:47:39 +0400 (MSK) From: Vladimir Testov To: grub-devel@gnu.org Subject: Re: [PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug Date: Mon, 22 Jul 2013 11:47:38 +0400 Message-ID: <3338260.RxHFEyJKGm@icedphoenix> User-Agent: KMail/4.10.4 (Linux/3.8.0-26-generic; KDE/4.10.4; x86_64; ; ) In-Reply-To: <20130720174758.285fa56e@opensuse.site> References: <1673590.C5H8tbIV1b@icedphoenix> <20130720174758.285fa56e@opensuse.site> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 195.19.76.181 Cc: Andrey Borzenkov X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jul 2013 07:47:45 -0000 On Saturday, July 20, 2013 05:47:57 PM Andrey Borzenkov wrote: > > - int string_left_offset = self->icon_width + icon_text_space; > > - int string_top_offset = (item_height - (ascent + descent)) / 2 + > > ascent; > > + int item_left_offset = self->icon_width + icon_text_space; > > + int item_top_offset = (item_height - (ascent + descent)) / 2 + ascent; > Is there any reason for renaming? Such changes usually obfuscate main > patch content and better done as separate patch with clear explanation. I have renamed these values to differ left and top offsets for non-selected item and for selected item. So the meanings of the values are cleared and easy-to-get. I can do these changes in a separate patch if it's needed. Just the patch and the renaming are about the same concept so it should be applied together. -- With best regards, _______________________________ Vladimir Testov, ROSA Laboratory. www.rosalab.ru