From: Arnd Bergmann <arnd@arndb.de>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Seungwon Jeon <tgih.jun@samsung.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 1/7] mmc: core add the property for hs200
Date: Tue, 21 Jan 2014 11:30:29 +0100 [thread overview]
Message-ID: <3339329.LQJLrAHSHx@wuerfel> (raw)
In-Reply-To: <52DE4916.4090603@samsung.com>
On Tuesday 21 January 2014 19:16:54 Jaehoon Chung wrote:
> caps2-mmc-hs200-1.8v and caps2-mmc-hs200-1.2v can be used to the general capability.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/mmc/core/host.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 49bc403..96ac4c1 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
> host->pm_caps |= MMC_PM_KEEP_POWER;
> if (of_find_property(np, "enable-sdio-wakeup", &len))
> host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
> + if (of_find_property(np, "caps2-mmc-hs200-1_8v", NULL))
> + host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
> + if (of_find_property(np, "caps2-mmc-hs200-1_2v", NULL))
> + host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
>
> return 0;
If we do this, the strings also need to be documented in
bindings/mmc/mmc.txt.
Unfortunately, the names are not particularly intuitive (the caps2
part in particular), but it's probably better to stick with that
now.
Arnd
next prev parent reply other threads:[~2014-01-21 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 10:16 [PATCH 1/7] mmc: core add the property for hs200 Jaehoon Chung
2014-01-21 10:30 ` Arnd Bergmann [this message]
2014-01-21 12:12 ` Ulf Hansson
2014-01-21 12:20 ` Jaehoon Chung
2014-01-21 13:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3339329.LQJLrAHSHx@wuerfel \
--to=arnd@arndb.de \
--cc=chris@printf.net \
--cc=g.liakhovetski@gmx.de \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.