From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Sat, 07 Apr 2018 11:46:56 +0000 Subject: Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST Message-Id: <3343566.MdR49rtcuZ@avalon> List-Id: References: <96572680e698fc554310e18cd6a166a0fb3bf32c.1523028795.git.mchehab@s-opensource.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , linux-omap@vger.kernel.org, Linux Media Mailing List Hi Mauro, Thank you for the patch. On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote: > The dependency of DRM_OMAP = n can be relaxed for just > compilation test. > > This allows building the omap3isp driver with allyesconfig > on ARM. omapfb has nothing to do with omap3isp. I assume you meant omap_vout. There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same time, they export identical symbols. I believe you will end up with link failures if you do so. > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig > b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..e42794a5e26c > 100644 > --- a/drivers/video/fbdev/omap2/omapfb/Kconfig > +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig > @@ -4,7 +4,7 @@ config OMAP2_VRFB > menuconfig FB_OMAP2 > tristate "OMAP2+ frame buffer support" > depends on FB > - depends on DRM_OMAP = n > + depends on DRM_OMAP = n || COMPILE_TEST > > select FB_OMAP2_DSS > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3 -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST Date: Sat, 07 Apr 2018 14:46:56 +0300 Message-ID: <3343566.MdR49rtcuZ@avalon> References: <96572680e698fc554310e18cd6a166a0fb3bf32c.1523028795.git.mchehab@s-opensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , linux-omap@vger.kernel.org, Linux Media Mailing List List-Id: linux-omap@vger.kernel.org SGkgTWF1cm8sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIEZyaWRheSwgNiBBcHJpbCAy MDE4IDE4OjMzOjIwIEVFU1QgTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIHdyb3RlOgo+IFRoZSBkZXBl bmRlbmN5IG9mIERSTV9PTUFQID0gbiBjYW4gYmUgcmVsYXhlZCBmb3IganVzdAo+IGNvbXBpbGF0 aW9uIHRlc3QuCj4gCj4gVGhpcyBhbGxvd3MgYnVpbGRpbmcgdGhlIG9tYXAzaXNwIGRyaXZlciB3 aXRoIGFsbHllc2NvbmZpZwo+IG9uIEFSTS4KCm9tYXBmYiBoYXMgbm90aGluZyB0byBkbyB3aXRo IG9tYXAzaXNwLiBJIGFzc3VtZSB5b3UgbWVhbnQgb21hcF92b3V0LgoKVGhlcmUncyBhIHJlYXNv biB3aHkgYm90aCBEUk1fT01BUCBhbmQgRkJfT01BUDIgY2FuJ3QgYmUgY29tcGlsZWQgYXQgdGhl IHNhbWUgCnRpbWUsIHRoZXkgZXhwb3J0IGlkZW50aWNhbCBzeW1ib2xzLiBJIGJlbGlldmUgeW91 IHdpbGwgZW5kIHVwIHdpdGggbGluayAKZmFpbHVyZXMgaWYgeW91IGRvIHNvLgoKPiBTaWduZWQt b2ZmLWJ5OiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWJAcy1vcGVuc291cmNlLmNvbT4K PiAtLS0KPiAgZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvS2NvbmZpZyB8IDIgKy0K PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL0tjb25maWcKPiBiL2Ry aXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL0tjb25maWcgaW5kZXggZTYyMjZhZWVkMTdl Li5lNDI3OTRhNWUyNmMKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAy L29tYXBmYi9LY29uZmlnCj4gKysrIGIvZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIv S2NvbmZpZwo+IEBAIC00LDcgKzQsNyBAQCBjb25maWcgT01BUDJfVlJGQgo+ICBtZW51Y29uZmln IEZCX09NQVAyCj4gICAgICAgICAgdHJpc3RhdGUgIk9NQVAyKyBmcmFtZSBidWZmZXIgc3VwcG9y dCIKPiAgICAgICAgICBkZXBlbmRzIG9uIEZCCj4gLSAgICAgICAgZGVwZW5kcyBvbiBEUk1fT01B UCA9IG4KPiArICAgICAgICBkZXBlbmRzIG9uIERSTV9PTUFQID0gbiB8fCBDT01QSUxFX1RFU1QK PiAKPiAgICAgICAgICBzZWxlY3QgRkJfT01BUDJfRFNTCj4gIAlzZWxlY3QgT01BUDJfVlJGQiBp ZiBBUkNIX09NQVAyIHx8IEFSQ0hfT01BUDMKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFy dAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:45375 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbeDGLq5 (ORCPT ); Sat, 7 Apr 2018 07:46:57 -0400 From: Laurent Pinchart To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST Date: Sat, 07 Apr 2018 14:46:56 +0300 Message-ID: <3343566.MdR49rtcuZ@avalon> In-Reply-To: References: <96572680e698fc554310e18cd6a166a0fb3bf32c.1523028795.git.mchehab@s-opensource.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Mauro, Thank you for the patch. On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote: > The dependency of DRM_OMAP = n can be relaxed for just > compilation test. > > This allows building the omap3isp driver with allyesconfig > on ARM. omapfb has nothing to do with omap3isp. I assume you meant omap_vout. There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same time, they export identical symbols. I believe you will end up with link failures if you do so. > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig > b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..e42794a5e26c > 100644 > --- a/drivers/video/fbdev/omap2/omapfb/Kconfig > +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig > @@ -4,7 +4,7 @@ config OMAP2_VRFB > menuconfig FB_OMAP2 > tristate "OMAP2+ frame buffer support" > depends on FB > - depends on DRM_OMAP = n > + depends on DRM_OMAP = n || COMPILE_TEST > > select FB_OMAP2_DSS > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3 -- Regards, Laurent Pinchart