From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1 1/5] rawdev: introduce raw device library
	support
Date: Sun, 14 Jan 2018 23:50:12 +0100
Message-ID: <3353485.Yvo7Hz8i5N@xps>
References: <20180102125749.2379-1-shreyansh.jain@nxp.com>
 <20180102125749.2379-2-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com,
 rosen.xu@intel.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B621025B3
 for <dev@dpdk.org>; Sun, 14 Jan 2018 23:50:44 +0100 (CET)
In-Reply-To: <20180102125749.2379-2-shreyansh.jain@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/01/2018 13:57, Shreyansh Jain:
> --- /dev/null
> +++ b/lib/librte_rawdev/rte_rawdev_version.map
> @@ -0,0 +1,33 @@
> +EXPERIMENTAL {
> +       global:
> +
> +       rte_rawdev_close;
> +       rte_rawdev_configure;
> +       rte_rawdev_count;
> +       rte_rawdev_dequeue_buffers;
> +       rte_rawdev_enqueue_buffers;
> +       rte_rawdev_firmware_load;
> +       rte_rawdev_firmware_status_get;
> +       rte_rawdev_firmware_unload;
> +       rte_rawdev_firmware_version_get;
> +       rte_rawdev_get_attr;
> +       rte_rawdev_get_dev_id;
> +       rte_rawdev_info_get;
> +       rte_rawdev_pmd_allocate;
> +       rte_rawdev_pmd_release;
> +       rte_rawdev_queue_conf_get;
> +       rte_rawdev_queue_setup;
> +       rte_rawdev_queue_release;
> +       rte_rawdev_reset;
> +       rte_rawdev_set_attr;
> +       rte_rawdev_socket_id;
> +       rte_rawdev_start;
> +       rte_rawdev_stop;
> +       rte_rawdev_xstats_by_name_get;
> +       rte_rawdev_xstats_get;
> +       rte_rawdev_xstats_names_get;
> +       rte_rawdev_xstats_reset;
> +       rte_rawdevs;
> +
> +       local: *;
> +};

It may be more pleasant to review, and more convenient to reference
in the git history later, if it is a bit split in patches.
If possible, I would suggest to split dequeue/enqueue, firmware
and stats in 3 separate patches after the basic skeleton.