From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] eal: fix header files install with meson
Date: Tue, 26 Nov 2019 12:17:41 +0100 [thread overview]
Message-ID: <3358503.0YUIpihZ7K@xps> (raw)
In-Reply-To: <20191126105028.24948-1-alialnu@mellanox.com>
26/11/2019 11:51, Ali Alnubani:
> The following header files weren't being installed by meson:
> - rte_vfio.h
> - rte_function_versioning.h
> - rte_test.h
>
> This patch adds them to the common_headers list so that
> they are installed.
>
> Fixes: 610beca42ea4 ("build: remove library special cases")
I am not sure this is the right root cause.
At least for rte_function_versioning.h, it has been added recently.
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2019-11-26 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 8:16 [dpdk-dev] [PATCH] build: install missing header files Ali Alnubani
2019-11-26 9:34 ` Thomas Monjalon
2019-11-26 9:52 ` Bruce Richardson
2019-11-26 10:51 ` [dpdk-dev] [PATCH v2] eal: fix header files install with meson Ali Alnubani
2019-11-26 11:17 ` Thomas Monjalon [this message]
2019-11-26 13:25 ` Bruce Richardson
2019-11-26 15:38 ` [dpdk-dev] [PATCH v3] eal: fix header file " Ali Alnubani
2019-11-26 16:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3358503.0YUIpihZ7K@xps \
--to=thomas@monjalon.net \
--cc=alialnu@mellanox.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.