From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E55CAC67861 for ; Wed, 10 Apr 2024 01:25:35 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1ruMiT-0005gB-Ow; Wed, 10 Apr 2024 01:25:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ruMiR-0005g0-Fe for linux-f2fs-devel@lists.sourceforge.net; Wed, 10 Apr 2024 01:25:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XdG9x/8zrScWi88kW4cVJXRZGGsWZEJjWwA7wj7h8/U=; b=lkCE+DuoBpqIZtxPq/8Tt3ouR6 aSpXi5GUrkyW8i+6s5mctCPgMBQTs1WL7OptCGMTSmmd7BUsAeYwVH9I+l+JagqZwYKpWxQOq8FzU LVA7GXOB5GAAOmy0nOAQTDG727M81urVLnmcDyQrnjTqVsk3iKrjx5RvU5/+V0MoUKnE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XdG9x/8zrScWi88kW4cVJXRZGGsWZEJjWwA7wj7h8/U=; b=gTZXgUbGCykf6LdNdVRhu1wDzE xuqJfZpHRT+E+/nJ9f9CswM3zHffuMvEIyEIzuqIMXoF8+WxNtZ/6wjBkG3/lsi5P1l/CjCcw0jjr UHWHAk+d5PUXe7loNPlFWF7reYv0dy3YJEC7GJFPJma7NeepjFEZ9qH0hv5vV++j3Bks=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1ruMiC-00083y-AC for linux-f2fs-devel@lists.sourceforge.net; Wed, 10 Apr 2024 01:25:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 53A22CE22A0; Wed, 10 Apr 2024 01:25:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FEF1C433C7; Wed, 10 Apr 2024 01:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712712303; bh=Gx9bCHrk1d77GFAb42nNEx6SxHXDuHF529fcfh61eHU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DTfyx2frpgj15Wx6eJlg+u5fV/fmpIM4AfEo+DxtWGjhn/Cmt1p05Z5d7JEmvob4u xySbZvEzzSJxd2r7RSDkZqr/UyK9ATc6nZZYTN08boj7i1DyMEyyNCOg2ggc31R4OX sUPivJD17j0XyliKhbyXB4tV6gLcHogm1pEBhgKo1TbDIYEuoa/IXlbWRDn2SWCB5X HobqGPjiUHixyzPY2GFVCh45yHOcnhOCnoZDXL7srypRZIpu7Yw6yCZuEMHatB+6ra 1f2HT2dlRBInnMRkCLnAYLhZWM+UAp6vfx4ML+KmQSj6Zm4UMdUapyzmeUQJZ9n5SD Le5G4IC2HgEBA== Message-ID: <33644d72-e32f-40bf-9d81-b915b509bde9@kernel.org> Date: Wed, 10 Apr 2024 09:24:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jaegeuk Kim References: <20240404195254.556896-1-jaegeuk@kernel.org> <2c195fee-c71c-4e44-b24f-9880b3c1b6c4@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: X-Headers-End: 1ruMiC-00083y-AC Subject: Re: [f2fs-dev] [PATCH] f2fs: don't set RO when shutting down f2fs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, =?UTF-8?B?TGlnaHQgSHNpZWggKOisneaYjueHiCk=?= , linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMjAyNC80LzEwIDA6MjEsIEphZWdldWsgS2ltIHdyb3RlOgo+IE9uIDA0LzA5LCBDaGFvIFl1 IHdyb3RlOgo+PiBPbiAyMDI0LzQvNSAzOjUyLCBKYWVnZXVrIEtpbSB3cm90ZToKPj4+IFNodXRk b3duIGRvZXMgbm90IGNoZWNrIHRoZSBlcnJvciBvZiB0aGF3X3N1cGVyIGR1ZSB0byByZWFkb25s eSwgd2hpY2gKPj4+IGNhdXNlcyBhIGRlYWRsb2NrIGxpa2UgYmVsb3cuCj4+Pgo+Pj4gZjJmc19p b2Nfc2h1dGRvd24oRjJGU19HT0lOR19ET1dOX0ZVTExTWU5DKSAgICAgICAgaXNzdWVfZGlzY2Fy ZF90aHJlYWQKPj4+ICAgIC0gYmRldl9mcmVlemUKPj4+ICAgICAtIGZyZWV6ZV9zdXBlcgo+Pj4g ICAgLSBmMmZzX3N0b3BfY2hlY2twb2ludCgpCj4+PiAgICAgLSBmMmZzX2hhbmRsZV9jcml0aWNh bF9lcnJvciAgICAgICAgICAgICAgICAgICAgIC0gc2Jfc3RhcnRfd3JpdGUKPj4+ICAgICAgIC0g c2V0IFJPICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtIHdhaXRpbmcK Pj4+ICAgIC0gYmRldl90aGF3Cj4+PiAgICAgLSB0aGF3X3N1cGVyX2xvY2tlZAo+Pj4gICAgICAg LSByZXR1cm4gLUVJTlZBTCwgaWYgc2JfcmRvbmx5KCkKPj4+ICAgIC0gZjJmc19zdG9wX2Rpc2Nh cmRfdGhyZWFkCj4+PiAgICAgLT4gd2FpdCBmb3Iga3RocmVhZF9zdG9wKGRpc2NhcmRfdGhyZWFk KTsKPj4+Cj4+PiBSZXBvcnRlZC1ieTogIkxpZ2h0IEhzaWVoICjorJ3mmI7nh4gpIiA8TGlnaHQu SHNpZWhAbWVkaWF0ZWsuY29tPgo+Pj4gU2lnbmVkLW9mZi1ieTogSmFlZ2V1ayBLaW0gPGphZWdl dWtAa2VybmVsLm9yZz4KPj4+IC0tLQo+Pj4gICAgZnMvZjJmcy9zdXBlci5jIHwgMTEgKysrKysr KysrLS0KPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2ZzL2YyZnMvc3VwZXIuYyBiL2ZzL2YyZnMvc3VwZXIu Ywo+Pj4gaW5kZXggZGY5NzY1YjQxZGFjLi5iYTYyODhlODcwYzUgMTAwNjQ0Cj4+PiAtLS0gYS9m cy9mMmZzL3N1cGVyLmMKPj4+ICsrKyBiL2ZzL2YyZnMvc3VwZXIuYwo+Pj4gQEAgLTQxMzUsOSAr NDEzNSwxNiBAQCB2b2lkIGYyZnNfaGFuZGxlX2NyaXRpY2FsX2Vycm9yKHN0cnVjdCBmMmZzX3Ni X2luZm8gKnNiaSwgdW5zaWduZWQgY2hhciByZWFzb24sCj4+PiAgICAJaWYgKHNodXRkb3duKQo+ Pj4gICAgCQlzZXRfc2JpX2ZsYWcoc2JpLCBTQklfSVNfU0hVVERPV04pOwo+Pj4gLQkvKiBjb250 aW51ZSBmaWxlc3lzdGVtIG9wZXJhdG9ycyBpZiBlcnJvcnM9Y29udGludWUgKi8KPj4+IC0JaWYg KGNvbnRpbnVlX2ZzIHx8IGYyZnNfcmVhZG9ubHkoc2IpKQo+Pj4gKwkvKgo+Pj4gKwkgKiBDb250 aW51ZSBmaWxlc3lzdGVtIG9wZXJhdG9ycyBpZiBlcnJvcnM9Y29udGludWUuIFNob3VsZCBub3Qg c2V0Cj4+PiArCSAqIFJPIGJ5IHNodXRkb3duLCBzaW5jZSBSTyBieXBhc3NlcyB0aGF3X3N1cGVy IHdoaWNoIGNhbiBoYW5nIHRoZQo+Pj4gKwkgKiBzeXN0ZW0uCj4+PiArCSAqLwo+Pj4gKwlpZiAo Y29udGludWVfZnMgfHwgZjJmc19yZWFkb25seShzYikgfHwKPj4+ICsJCQkJcmVhc29uID09IFNU T1BfQ1BfUkVBU09OX1NIVVRET1dOKSB7Cj4+PiArCQlmMmZzX3dhcm4oc2JpLCAiU3RvcHBlZCBm aWxlc3lzdGVtIGR1ZSB0byByZWFkb246ICVkIiwgcmVhc29uKTsKPj4+ICAgIAkJcmV0dXJuOwo+ Pgo+PiBEbyB3ZSBuZWVkIHRvIHNldCBSTyBhZnRlciBiZGV2X3RoYXcoKSBpbiBmMmZzX2RvX3No dXRkb3duKCk/Cj4gCj4gSUlSQywgc2h1dGRvd24gZG9lc24ndCBuZWVkIHRvIHNldCBSTyBhcyB3 ZSBzdG9wcGVkIHRoZSBjaGVja3BvaW50Lgo+IEknbSBtb3JlIGNvbmNlcm5lZCBvbiBhbnkgc2lk ZSBlZmZlY3QgY2F1c2VkIGJ5IHRoaXMgUk8gY2hhbmdlLgoKT2theSwgSSBqdXN0IHdvbmRlciB3 aGV0aGVyIHdlIG5lZWQgdG8gZm9sbG93IHNlbWFudGljcyBvZiBlcnJvcnM9cmVtb3VudC1ybwpz ZW1hbnRpY3MsIGJ1dCBpdCBsb29rcyBmaW5lIHNpbmNlIHNodXRkb3duIG9wZXJhdGlvbiBzaW11 bGF0ZWQgYnkgaW9jdGwKY291bGQgbm90IGJlIHRyZWF0ZWQgYXMgYW4gaW5uZXIgY3JpdGljYWwg ZXJyb3IsCgplcnJvcnM9JXMgICAgICAgICAgICAgICAgU3BlY2lmeSBmMmZzIGJlaGF2aW9yIG9u IGNyaXRpY2FsIGVycm9ycy4gVGhpcyBzdXBwb3J0cyBtb2RlczoKICAgICAgICAgICAgICAgICAg ICAgICAgICAicGFuaWMiLCAiY29udGludWUiIGFuZCAicmVtb3VudC1ybyIsIHJlc3BlY3RpdmVs eSwgdHJpZ2dlcgogICAgICAgICAgICAgICAgICAgICAgICAgIHBhbmljIGltbWVkaWF0ZWx5LCBj b250aW51ZSB3aXRob3V0IGRvaW5nIGFueXRoaW5nLCBhbmQgcmVtb3VudAogICAgICAgICAgICAg ICAgICAgICAgICAgIHRoZSBwYXJ0aXRpb24gaW4gcmVhZC1vbmx5IG1vZGUuIEJ5IGRlZmF1bHQg aXQgdXNlcyAiY29udGludWUiCiAgICAgICAgICAgICAgICAgICAgICAgICAgbW9kZS4KCkFsc28s IGl0IGtlZXBzIHRoZSBiZWhhdmlvciBjb25zaXN0ZW50IHcvIHdoYXQgd2UgZG8gZm9yIGVycm9y cz1wYW5pYyBjYXNlLgoKCWlmIChGMkZTX09QVElPTihzYmkpLmVycm9ycyA9PSBNT1VOVF9FUlJP UlNfUEFOSUMgJiYKCQkJCSFzaHV0ZG93biAmJiAhc3lzdGVtX2dvaW5nX2Rvd24oKSAmJgoJCQkJ Xl5eXl5eXl5eCgkJCQkhaXNfc2JpX2ZsYWdfc2V0KHNiaSwgU0JJX0lTX1NIVVRET1dOKSkKCQlw YW5pYygiRjJGUy1mcyAoZGV2aWNlICVzKTogcGFuaWMgZm9yY2VkIGFmdGVyIGVycm9yXG4iLAoJ CQkJCQkJc2ItPnNfaWQpOwoKVGhhbmtzLAoKPiAKPj4KPj4gVGhhbmtzLAo+Pgo+Pj4gKwl9Cj4+ PiAgICAJZjJmc193YXJuKHNiaSwgIlJlbW91bnRpbmcgZmlsZXN5c3RlbSByZWFkLW9ubHkiKTsK Pj4+ICAgIAkvKgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMu c291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3Rp bmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A75364A for ; Wed, 10 Apr 2024 01:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712712304; cv=none; b=TWu9kvYV9843TE0D0Q8Cr3R4JPeD7LqCyE1QQznUx0gRgJNE2f3qzXjvIs8szpSf3LxAO7r5bulLza09fDTpxK0VYApp2tI6WKI0+kXeQ0pj2Svf/Js3dewdtB7M2mGjrr7XZIgNwrCowwbR6Koqwqfqz1hq1wInedltXFeN+MU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712712304; c=relaxed/simple; bh=Gx9bCHrk1d77GFAb42nNEx6SxHXDuHF529fcfh61eHU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tf447yklh/FUDBXTXPlIVPmd+ue0U2z6/m1AmuPySL7kQ3ftNH2fWHHXlMAzeUcvbDe6FFf6cziFKGjaVy559knSI358AKEkINTI98AudC11+ZC9a16WYC4HIE+EggJdoY89kwgWcrnuxa03aRKG1eSZR8Tz1xU+H65k8WZp6lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DTfyx2fr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DTfyx2fr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FEF1C433C7; Wed, 10 Apr 2024 01:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712712303; bh=Gx9bCHrk1d77GFAb42nNEx6SxHXDuHF529fcfh61eHU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DTfyx2frpgj15Wx6eJlg+u5fV/fmpIM4AfEo+DxtWGjhn/Cmt1p05Z5d7JEmvob4u xySbZvEzzSJxd2r7RSDkZqr/UyK9ATc6nZZYTN08boj7i1DyMEyyNCOg2ggc31R4OX sUPivJD17j0XyliKhbyXB4tV6gLcHogm1pEBhgKo1TbDIYEuoa/IXlbWRDn2SWCB5X HobqGPjiUHixyzPY2GFVCh45yHOcnhOCnoZDXL7srypRZIpu7Yw6yCZuEMHatB+6ra 1f2HT2dlRBInnMRkCLnAYLhZWM+UAp6vfx4ML+KmQSj6Zm4UMdUapyzmeUQJZ9n5SD Le5G4IC2HgEBA== Message-ID: <33644d72-e32f-40bf-9d81-b915b509bde9@kernel.org> Date: Wed, 10 Apr 2024 09:24:59 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [f2fs-dev] [PATCH] f2fs: don't set RO when shutting down f2fs To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, =?UTF-8?B?TGlnaHQgSHNpZWggKOisneaYjueHiCk=?= References: <20240404195254.556896-1-jaegeuk@kernel.org> <2c195fee-c71c-4e44-b24f-9880b3c1b6c4@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024/4/10 0:21, Jaegeuk Kim wrote: > On 04/09, Chao Yu wrote: >> On 2024/4/5 3:52, Jaegeuk Kim wrote: >>> Shutdown does not check the error of thaw_super due to readonly, which >>> causes a deadlock like below. >>> >>> f2fs_ioc_shutdown(F2FS_GOING_DOWN_FULLSYNC) issue_discard_thread >>> - bdev_freeze >>> - freeze_super >>> - f2fs_stop_checkpoint() >>> - f2fs_handle_critical_error - sb_start_write >>> - set RO - waiting >>> - bdev_thaw >>> - thaw_super_locked >>> - return -EINVAL, if sb_rdonly() >>> - f2fs_stop_discard_thread >>> -> wait for kthread_stop(discard_thread); >>> >>> Reported-by: "Light Hsieh (謝明燈)" >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/super.c | 11 +++++++++-- >>> 1 file changed, 9 insertions(+), 2 deletions(-) >>> >>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >>> index df9765b41dac..ba6288e870c5 100644 >>> --- a/fs/f2fs/super.c >>> +++ b/fs/f2fs/super.c >>> @@ -4135,9 +4135,16 @@ void f2fs_handle_critical_error(struct f2fs_sb_info *sbi, unsigned char reason, >>> if (shutdown) >>> set_sbi_flag(sbi, SBI_IS_SHUTDOWN); >>> - /* continue filesystem operators if errors=continue */ >>> - if (continue_fs || f2fs_readonly(sb)) >>> + /* >>> + * Continue filesystem operators if errors=continue. Should not set >>> + * RO by shutdown, since RO bypasses thaw_super which can hang the >>> + * system. >>> + */ >>> + if (continue_fs || f2fs_readonly(sb) || >>> + reason == STOP_CP_REASON_SHUTDOWN) { >>> + f2fs_warn(sbi, "Stopped filesystem due to readon: %d", reason); >>> return; >> >> Do we need to set RO after bdev_thaw() in f2fs_do_shutdown()? > > IIRC, shutdown doesn't need to set RO as we stopped the checkpoint. > I'm more concerned on any side effect caused by this RO change. Okay, I just wonder whether we need to follow semantics of errors=remount-ro semantics, but it looks fine since shutdown operation simulated by ioctl could not be treated as an inner critical error, errors=%s Specify f2fs behavior on critical errors. This supports modes: "panic", "continue" and "remount-ro", respectively, trigger panic immediately, continue without doing anything, and remount the partition in read-only mode. By default it uses "continue" mode. Also, it keeps the behavior consistent w/ what we do for errors=panic case. if (F2FS_OPTION(sbi).errors == MOUNT_ERRORS_PANIC && !shutdown && !system_going_down() && ^^^^^^^^^ !is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN)) panic("F2FS-fs (device %s): panic forced after error\n", sb->s_id); Thanks, > >> >> Thanks, >> >>> + } >>> f2fs_warn(sbi, "Remounting filesystem read-only"); >>> /*