From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues
Date: Mon, 22 Apr 2019 22:55:18 +0200 [thread overview]
Message-ID: <3365798.BUGD0mJE1c@xps> (raw)
In-Reply-To: <601a96fa-1a3e-9d98-8d78-df96c4ebd400@intel.com>
09/04/2019 13:18, Burakov, Anatoly:
> On 09-Apr-19 10:22 AM, David Hunt wrote:
> > A previous change removed the limit of 64 cores by
> > moving away from 64-bit masks to char arrays. However
> > this left a buffer overrun issue, where the max channels
> > was defined as 64, and max cores was defined as 256. These
> > should all be consistently set to RTE_MAX_LCORE.
> >
> > The #defines being removed are CHANNEL_CMDS_MAX_CPUS,
> > CHANNEL_CMDS_MAX_CHANNELS, POWER_MGR_MAX_CPUS, and
> > CHANNEL_CMDS_MAX_VM_CHANNELS, and are being replaced
> > with RTE_MAX_LCORE for consistency and simplicity.
> >
> > Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
> > Coverity issue: 337672
> > Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
> > Coverity issue: 337673
> > Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
> > Coverity issue: 337678
>
> No need to mention the same commit three times :)
>
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-04-22 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 9:22 [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues David Hunt
2019-04-09 11:18 ` Burakov, Anatoly
2019-04-09 14:40 ` Hunt, David
2019-04-10 7:52 ` Ferruh Yigit
2019-04-10 10:55 ` Burakov, Anatoly
2019-04-10 14:17 ` Ferruh Yigit
2019-04-22 20:55 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3365798.BUGD0mJE1c@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.