From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74255253931 for ; Thu, 17 Jul 2025 07:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752737709; cv=none; b=PwMYPjwjDVkcKGChYEX/taHTQn+VqUXDAnBCo3tYYGkdq6OO/B74S88ZB2uP6dif45bgKMx5mqkP477rgN797GC0gduPBeVcDjCo09IfYe8CmEmYcyrjEfZ0oZL9d1o5XFlh+mx+jxG5vO3uOEXwcHhie+xPY5cb+WgZ/H9zXTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752737709; c=relaxed/simple; bh=+PQqRj/+APqDPfJKyjrfclx/vTYwfsNsxaUV9DAeknA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uFIiLHP5N277D11pZFXxCMpoEm3zIM7dm1uNiBPoer5CeEijtrn7YfS4NDwmswna+GdlbJ8uWssGD2abAXa6O54CB2JfoYM1Tcd5TwG2B+7s/uKu1x6Yxi9ZTI43KfIRK4wqO5R+LxEX2O/0Sna75HaEAv6WrZKgjRKCM0pXbhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=If+ElQ16; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="If+ElQ16" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752737706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dujvEOHGoGkKIbh2VcvWWUHTqJBgDW3Vgo4cGXVPWNY=; b=If+ElQ16GalXdMYvqQgQWxUcnUYTmHP8pkM2iSnPGze89/riUnVDuCf+stownz4XvAm/Ul Cv6ZiXcrZfvVxbKuz9i54/mpyVZbjY71mDlcc9fo/qWcjo0qbMYFmIsIiUQVBD6q1Uf2yj Y8k+0jdfFpe6G0XlYPVY21KzWB10p9M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-u8k5q24NO-OTIIyeUnIUHw-1; Thu, 17 Jul 2025 03:35:05 -0400 X-MC-Unique: u8k5q24NO-OTIIyeUnIUHw-1 X-Mimecast-MFC-AGG-ID: u8k5q24NO-OTIIyeUnIUHw_1752737704 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4561611dc2aso5603955e9.0 for ; Thu, 17 Jul 2025 00:35:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752737704; x=1753342504; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dujvEOHGoGkKIbh2VcvWWUHTqJBgDW3Vgo4cGXVPWNY=; b=dJNOiEz8u37FCq/bmZ76qFrDWw9xxVt7APy4vM1cuyagw9NA1SQQFtkVDu81bhrL8+ ieFW0h3kjMm7SdHVMVwGJEt4AaYFIPuKGKUK4Fvtld8o7hS0J/joQG2oqmqbECutDjer hM6yxvRtRJVxMjhm4hhFltIwMHyIxRNhjQO5opPvmBxYIhHzyCvEMSHh6rYqcJFIWKbK MOm24OfNowgD58ABBVZQtez0kjReDFbeOnyaeAkG5HED5uTH4ldBtLkRKN/dVZjQLWBy NgedDYQxnos1KABcoI8UTnL1cCJMoa7jYyLRYAUzPntWQZgRxNfePh5S8BBYQP31oj05 TbHg== X-Forwarded-Encrypted: i=1; AJvYcCXpVSTQ1wcW1x3x67wljudnpLiuESWPTO75jfr2Z6jINixedLLivAk81mknJlzPwMkXlIl7/0M=@lists.linux.dev X-Gm-Message-State: AOJu0YwMEodIYOFbodlawIvhxkAovfL70jtIvhP1CoyhAVVX1SAhNNOM Tmi/st0bw4Kz8vHIm7wF9sb+GOpjTiiA4PBtdAunBVLNLJ5LPsmWnB+oqpYuAsp9X8VC5UGhbqv kspVEwzu6IdMnoGlt6zlYfV72U+RQ6a1hMasAUKIwmmn33neMID5sJw2iHg== X-Gm-Gg: ASbGnctEztIrM5JZS5tFSA4g4noHO+5TPyNatFW0B6N9I0fXry2EcaQ3KKNgxDceuih ed7cGSP4aGgkcMfaXclz++V4x+Y5mC1lydXVyT9MQsrU6WAmXWJFHDwfogpa27ih0k1aZCd3+/3 yvPLPR5aow5Ye0KEuyVi0muNLLqHz1ZcmSSyI7kehSqmaV1XQ6IgiWwig7h/jsxlpMUkrl1BstN Y2WZ7duJtVc6mInWWTEdgpkSrWaOebIiGATFln1b0HvvCppUYv7cX7JSFBWX65eWNbiFSSDmnfa 7n10S6Z5U5j6EvDo456WuuKtGFUFzxGCZpmMvRsRJ/gUxSvvHkztd7T2DCtJPUw0S+k5jlBwQFp W2xq94Ils5Rwghy+ipAr8q1AoCN094eBDGV++a6mzuFbAPqzqV2kZZOH7pxRJseEn X-Received: by 2002:a05:600c:820f:b0:43c:ec0a:ddfd with SMTP id 5b1f17b1804b1-4562ed57638mr48600575e9.6.1752737703920; Thu, 17 Jul 2025 00:35:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtTyLPcaxAHqteD7RhIpkLjY6DinVSnPGFlCTrTsNMCpipiqNTjkckjgG4pKMNN42D/qwMTg== X-Received: by 2002:a05:600c:820f:b0:43c:ec0a:ddfd with SMTP id 5b1f17b1804b1-4562ed57638mr48600205e9.6.1752737703460; Thu, 17 Jul 2025 00:35:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7? (p200300d82f1f36000dc826ee9aa9fdc7.dip0.t-ipconnect.de. [2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e7f2d4fsm43469055e9.4.2025.07.17.00.35.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 00:35:02 -0700 (PDT) Message-ID: <336b1801-869d-47ff-a942-c100e0d07d75@redhat.com> Date: Thu, 17 Jul 2025 09:35:01 +0200 Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/9] mm: vm_normal_page*() improvements To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Oscar Salvador , Lance Yang References: <20250715132350.2448901-1-david@redhat.com> <20250715163126.7bcaca25364dd68835bd9c8b@linux-foundation.org> <17a539fa-977c-4f3f-bedf-badd1fc1287a@redhat.com> <20250716152710.59e09fe5056010322de2a1a3@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250716152710.59e09fe5056010322de2a1a3@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rsZQtb6RTzKtRVQGK91CVdhhFhhpj5SJ74D3im5q_zc_1752737704 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17.07.25 00:27, Andrew Morton wrote: > On Wed, 16 Jul 2025 10:47:29 +0200 David Hildenbrand wrote: > >>> >>> However the series rejects due to the is_huge_zero_pmd -> >>> is_huge_zero_pfn changes in Luiz's "mm: introduce snapshot_page() v3" >>> series, so could we please have a redo against present mm-new? >> >> I'm confused: mm-new *still* contains the patch from Luiz series that >> was originally part of the RFC here. >> >> commit 791cb64cd7f8c2314c65d1dd5cb9e05e51c4cd70 >> Author: David Hildenbrand >> Date: Mon Jul 14 09:16:51 2025 -0400 >> >> mm/memory: introduce is_huge_zero_pfn() and use it in vm_normal_page_pmd() >> >> If you want to put this series here before Luiz', you'll have to move that >> single patch as well. >> >> But probably this series should be done on top of Luiz work, because Luiz >> fixes something. > > I'm confused at your confused. mm-new presently contains Luiz's latest > v3 series "mm: introduce snapshot_page()" which includes a copy of your > "mm/memory: introduce is_huge_zero_pfn() and use it in > vm_normal_page_pmd()". Let's recap: you said "the series rejects due to the is_huge_zero_pmd -> is_huge_zero_pfn changes in Luiz's "mm: introduce snapshot_page() v3" series" $ git checkout mm/mm-new -b tmp branch 'tmp' set up to track 'mm/mm-new'. Switched to a new branch 'tmp' $ b4 shazam 20250715132350.2448901-1-david@redhat.com Grabbing thread from lore.kernel.org/all/20250715132350.2448901-1-david@redhat.com/t.mbox.gz Checking for newer revisions Grabbing search results from lore.kernel.org Analyzing 17 messages in the thread Looking for additional code-review trailers on lore.kernel.org Analyzing 65 code-review messages Checking attestation on all messages, may take a moment... --- ✓ [PATCH v1 1/9] mm/huge_memory: move more common code into insert_pmd() ✓ [PATCH v1 2/9] mm/huge_memory: move more common code into insert_pud() ✓ [PATCH v1 3/9] mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd() ✓ [PATCH v1 4/9] fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio ✓ [PATCH v1 5/9] mm/huge_memory: mark PMD mappings of the huge zero folio special ✓ [PATCH v1 6/9] mm/memory: convert print_bad_pte() to print_bad_page_map() ✓ [PATCH v1 7/9] mm/memory: factor out common code from vm_normal_page_*() + Reviewed-by: Oscar Salvador (✓ DKIM/suse.de) ✓ [PATCH v1 8/9] mm: introduce and use vm_normal_page_pud() + Reviewed-by: Oscar Salvador (✓ DKIM/suse.de) ✓ [PATCH v1 9/9] mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page() + Reviewed-by: Oscar Salvador (✓ DKIM/suse.de) --- ✓ Signed: DKIM/redhat.com --- Total patches: 9 --- Base: using specified base-commit 64d19a2cdb7b62bcea83d9309d83e06d7aff4722 Applying: mm/huge_memory: move more common code into insert_pmd() Applying: mm/huge_memory: move more common code into insert_pud() Applying: mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd() Applying: fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio Applying: mm/huge_memory: mark PMD mappings of the huge zero folio special Applying: mm/memory: convert print_bad_pte() to print_bad_page_map() Applying: mm/memory: factor out common code from vm_normal_page_*() Applying: mm: introduce and use vm_normal_page_pud() Applying: mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page() $ make mm/memory.o ... CC mm/memory.o I know that a tree from yesterday temporarily didn't have Luiz patches, so maybe that's what you ran into. *anyhow*, I will resend to work around that arm pgdp_get() issue. -- Cheers, David / dhildenb