From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] mk: fix external shared library dependencies of libraries
Date: Tue, 08 Dec 2015 11:11:04 +0100 [thread overview]
Message-ID: <33721268.SXJjAvgPEg@xps13> (raw)
In-Reply-To: <87f15b40e6a0cad89a9eb94dd173cd20878b591a.1449563079.git.pmatilai@redhat.com>
Hi Panu,
2015-12-08 10:30, Panu Matilainen:
> --- a/lib/librte_vhost/Makefile
> +++ b/lib/librte_vhost/Makefile
> @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user
> else
> CFLAGS += -I vhost_cuse -lfuse
> LDFLAGS += -lfuse
> +LDLIBS += -lfuse
> endif
>
> ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
> LDFLAGS += -lnuma
> +LDLIBS += -lnuma
> endif
It looks weird to have to declare the dependencies both in
LDFLAGS and LDLIBS. What is the reason?
Can we improve it?
next prev parent reply other threads:[~2015-12-08 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 8:30 [PATCH] mk: fix external shared library dependencies of libraries Panu Matilainen
2015-12-08 10:11 ` Thomas Monjalon [this message]
2015-12-08 11:19 ` Panu Matilainen
2015-12-08 11:39 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33721268.SXJjAvgPEg@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.