From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 096C7606A32D for ; Wed, 4 Nov 2026 10:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uI07dMGc; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=A+8t5vjZ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=uRrdt0oAcAPfS+w2dQ61HkrI15khdaUCiJ5g7tU0p+Q=; b=uI07dMGcv9dPM24anTGw7Ef/i8 ZpSozk5XcXizOiZZ8V/vmurOKCvlIn/hIyl5YZ8181TJ/OBFf11n/JF9jXB+8Xgvc7se+n651nhhj JTxyODX7CVKVBjPTHtEpuSS9yKssHO1Qhiiasbzdyj8+xToW2QDaCB5qnBoBj/LUgf3szKEMelcrz SL/Wlby1fGRsl0QNAGLiygI1Y2ByKOO6LbwhHDKr8yv275j875PLWS1JU3qloYyhWRy2I7H6Txo3C vNZI9ZYmJM1gK0KeTLaYywsswvqsaSwI9Tec2wP4akbuut0eTV4w4U8Ihr8ox7Dg2el+HhINTiRmv u47e9TEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOYBp-00000004zdF-1nrB; Wed, 04 Nov 2026 10:25:57 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOYBm-00000004zc0-2Y3p; Wed, 04 Nov 2026 10:25:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=uRrdt0oAcAPfS+w2dQ61HkrI15khdaUCiJ5g7tU0p+Q=; b=A+8t5vjZqpreZvPSLqn2rWHCfk n20HzKOydnfedJfrqrbJoETErbWXGYMoVDxPotfS+pj30dhVa9kgt9ioE3h2XT9i+o0G+8YdGkx94 c3QBYW5k2mk+ni5jhkwtbJ0XyA5dPKbn2W67WeyaIRUJ548XcG9M2F372a+JG9Z4saOhjOzo+w3oC eyhS0ZoraybqUEcq+Rs1ShIc64rINHDJig5KDlfjZqHUgloCWhUZhfDAow0U/X/rkbraLV4ZTsUbE L8NNkvSjhwcAGWUz3HAevwzEEWEfjFK3ykebZUp2dFTL+4ugzZ2Y132qKzJFggyFXmgKN48nvtd3S d5ApHuFg==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: tomeu@tomeuvizoso.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, ulfh@kernel.org, p.zabel@pengutronix.de, ogabbay@kernel.org, zhangqing@rock-chips.com, Jiaxing Hu Cc: royalnet026@gmail.com, abel.vesa@oss.qualcomm.com, sebastian.reichel@collabora.com, sidong.yang@furiosa.ai, u.kleine-koenig@baylibre.com, chaoyi.chen@rock-chips.com, diederik@cknow-tech.com, alchark@flipper.net, leonard@lausen.nl, jeff.hugo@oss.qualcomm.com, rfoss@kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiaxing Hu Subject: Re: [PATCH v15 04/15] accel/rocket: let the core suspend after a reset Date: Wed, 04 Nov 2026 11:25:30 +0100 Message-ID: <3373678.NnENhoQgcM@diego> In-Reply-To: <20261101082307.151957-5-gahing@gahingwoo.com> References: <20261101082307.151957-1-gahing@gahingwoo.com> <20261101082307.151957-5-gahing@gahingwoo.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261104_022554_650177_ECCA7A91 X-CRM114-Status: GOOD ( 17.52 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Am Sonntag, 1. November 2026, 09:22:56 Mitteleurop=C3=A4ische Normalzeit sc= hrieb Jiaxing Hu: > rocket_reset() drops the in-flight job's runtime PM reference with > pm_runtime_put_noidle(), which requests nothing, so the core does not > suspend until something else asks and its power domain does not cycle. On > RK3576 the domain's power-on resets the NPU bus interface; without it the > IOMMU stops answering and the job after a timeout fails. >=20 > Use pm_runtime_put_autosuspend(), as the completion path does. On a ROCK = 4D > the job after a timeout goes from 0 to 128 of 128 channels correct. >=20 > Link: https://lore.kernel.org/all/20260819073530.6087-1-royalnet026@gmail= =2Ecom/ > Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL") > Signed-off-by: Jiaxing Hu > Tested-by: Igor Paunovic # RK3588, three cores, i= nduced reset, JOB_TIMEOUT_MS=3D2 > --- > drivers/accel/rocket/rocket_job.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/roc= ket_job.c > index 5b2abf40b618..152a9098634b 100644 > --- a/drivers/accel/rocket/rocket_job.c > +++ b/drivers/accel/rocket/rocket_job.c > @@ -467,12 +467,12 @@ rocket_reset(struct rocket_core *core, struct drm_s= ched_job *bad) > =20 > /* > * No handler is running now, but we might still have stuck jobs. Let's > - * make sure the PM counters stay balanced by manually calling > - * pm_runtime_put_noidle(). > + * make sure the PM counters stay balanced by putting the reference the > + * job took, and request idle while doing it so the core can suspend. > */ with my comment in patch 3/15 fixed Reviewed-by: Heiko Stuebner > scoped_guard(mutex, &core->job_lock) { > if (core->in_flight_job) > - pm_runtime_put_noidle(core->dev); > + pm_runtime_put_autosuspend(core->dev); > =20 > iommu_detach_group(NULL, core->iommu_group); > =20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0ABE606A328 for ; Wed, 4 Nov 2026 10:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aMfOJCBP; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=A+8t5vjZ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=Sz8N6pbYSmqsCd7OGTsSUzb4tT9hnLEvvb0Rw2k99lI=; b=aMfOJCBPb5cscIZJSBp3tOUQVG /NFcW+Yc7zq/nYJH8PKqF0kETBkLZGcPl2PWB8RW0qgmiBkgtpSbp9Eaww9y8E4r96v8CYkPEqC5l cboZYHxyGyAsyTg+j0QfSxPJhszooKk0DS0vK2wmtTUIaKicJh9kVQA3HQME0YreMJJZniyeGWxGe loclveXyXbZAXmHfhagK7BFyAIqHRU98V3/tTbpL2r0Q+blZ4di04gglW9qr1DXuG+l8EtWP6pkn5 e4dukjyrDaSDZ2RcR8exTn3sZx19f5ufkBnPemECC15nPMXaG/wDxAHc/7CU3jdDdOJE9b8AdHaNA fgO//wWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOYBp-00000004zd9-1Zoi; Wed, 04 Nov 2026 10:25:57 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOYBm-00000004zc0-2Y3p; Wed, 04 Nov 2026 10:25:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=uRrdt0oAcAPfS+w2dQ61HkrI15khdaUCiJ5g7tU0p+Q=; b=A+8t5vjZqpreZvPSLqn2rWHCfk n20HzKOydnfedJfrqrbJoETErbWXGYMoVDxPotfS+pj30dhVa9kgt9ioE3h2XT9i+o0G+8YdGkx94 c3QBYW5k2mk+ni5jhkwtbJ0XyA5dPKbn2W67WeyaIRUJ548XcG9M2F372a+JG9Z4saOhjOzo+w3oC eyhS0ZoraybqUEcq+Rs1ShIc64rINHDJig5KDlfjZqHUgloCWhUZhfDAow0U/X/rkbraLV4ZTsUbE L8NNkvSjhwcAGWUz3HAevwzEEWEfjFK3ykebZUp2dFTL+4ugzZ2Y132qKzJFggyFXmgKN48nvtd3S d5ApHuFg==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: tomeu@tomeuvizoso.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, ulfh@kernel.org, p.zabel@pengutronix.de, ogabbay@kernel.org, zhangqing@rock-chips.com, Jiaxing Hu Cc: royalnet026@gmail.com, abel.vesa@oss.qualcomm.com, sebastian.reichel@collabora.com, sidong.yang@furiosa.ai, u.kleine-koenig@baylibre.com, chaoyi.chen@rock-chips.com, diederik@cknow-tech.com, alchark@flipper.net, leonard@lausen.nl, jeff.hugo@oss.qualcomm.com, rfoss@kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiaxing Hu Subject: Re: [PATCH v15 04/15] accel/rocket: let the core suspend after a reset Date: Wed, 04 Nov 2026 11:25:30 +0100 Message-ID: <3373678.NnENhoQgcM@diego> In-Reply-To: <20261101082307.151957-5-gahing@gahingwoo.com> References: <20261101082307.151957-1-gahing@gahingwoo.com> <20261101082307.151957-5-gahing@gahingwoo.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261104_022554_650177_ECCA7A91 X-CRM114-Status: GOOD ( 17.52 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gU29ubnRhZywgMS4gTm92ZW1iZXIgMjAyNiwgMDk6MjI6NTYgTWl0dGVsZXVyb3DDpGlzY2hl IE5vcm1hbHplaXQgc2NocmllYiBKaWF4aW5nIEh1Ogo+IHJvY2tldF9yZXNldCgpIGRyb3BzIHRo ZSBpbi1mbGlnaHQgam9iJ3MgcnVudGltZSBQTSByZWZlcmVuY2Ugd2l0aAo+IHBtX3J1bnRpbWVf cHV0X25vaWRsZSgpLCB3aGljaCByZXF1ZXN0cyBub3RoaW5nLCBzbyB0aGUgY29yZSBkb2VzIG5v dAo+IHN1c3BlbmQgdW50aWwgc29tZXRoaW5nIGVsc2UgYXNrcyBhbmQgaXRzIHBvd2VyIGRvbWFp biBkb2VzIG5vdCBjeWNsZS4gT24KPiBSSzM1NzYgdGhlIGRvbWFpbidzIHBvd2VyLW9uIHJlc2V0 cyB0aGUgTlBVIGJ1cyBpbnRlcmZhY2U7IHdpdGhvdXQgaXQgdGhlCj4gSU9NTVUgc3RvcHMgYW5z d2VyaW5nIGFuZCB0aGUgam9iIGFmdGVyIGEgdGltZW91dCBmYWlscy4KPiAKPiBVc2UgcG1fcnVu dGltZV9wdXRfYXV0b3N1c3BlbmQoKSwgYXMgdGhlIGNvbXBsZXRpb24gcGF0aCBkb2VzLiBPbiBh IFJPQ0sgNEQKPiB0aGUgam9iIGFmdGVyIGEgdGltZW91dCBnb2VzIGZyb20gMCB0byAxMjggb2Yg MTI4IGNoYW5uZWxzIGNvcnJlY3QuCj4gCj4gTGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcv YWxsLzIwMjYwODE5MDczNTMwLjYwODctMS1yb3lhbG5ldDAyNkBnbWFpbC5jb20vCj4gRml4ZXM6 IDA4MTBkNWFkODhhMSAoImFjY2VsL3JvY2tldDogQWRkIGpvYiBzdWJtaXNzaW9uIElPQ1RMIikK PiBTaWduZWQtb2ZmLWJ5OiBKaWF4aW5nIEh1IDxnYWhpbmdAZ2FoaW5nd29vLmNvbT4KPiBUZXN0 ZWQtYnk6IElnb3IgUGF1bm92aWMgPHJveWFsbmV0MDI2QGdtYWlsLmNvbT4gIyBSSzM1ODgsIHRo cmVlIGNvcmVzLCBpbmR1Y2VkIHJlc2V0LCBKT0JfVElNRU9VVF9NUz0yCj4gLS0tCj4gIGRyaXZl cnMvYWNjZWwvcm9ja2V0L3JvY2tldF9qb2IuYyB8IDYgKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvYWNjZWwvcm9ja2V0L3JvY2tldF9qb2IuYyBiL2RyaXZlcnMvYWNjZWwvcm9ja2V0L3JvY2tl dF9qb2IuYwo+IGluZGV4IDViMmFiZjQwYjYxOC4uMTUyYTkwOTg2MzRiIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvYWNjZWwvcm9ja2V0L3JvY2tldF9qb2IuYwo+ICsrKyBiL2RyaXZlcnMvYWNjZWwv cm9ja2V0L3JvY2tldF9qb2IuYwo+IEBAIC00NjcsMTIgKzQ2NywxMiBAQCByb2NrZXRfcmVzZXQo c3RydWN0IHJvY2tldF9jb3JlICpjb3JlLCBzdHJ1Y3QgZHJtX3NjaGVkX2pvYiAqYmFkKQo+ICAK PiAgCS8qCj4gIAkgKiBObyBoYW5kbGVyIGlzIHJ1bm5pbmcgbm93LCBidXQgd2UgbWlnaHQgc3Rp bGwgaGF2ZSBzdHVjayBqb2JzLiBMZXQncwo+IC0JICogbWFrZSBzdXJlIHRoZSBQTSBjb3VudGVy cyBzdGF5IGJhbGFuY2VkIGJ5IG1hbnVhbGx5IGNhbGxpbmcKPiAtCSAqIHBtX3J1bnRpbWVfcHV0 X25vaWRsZSgpLgo+ICsJICogbWFrZSBzdXJlIHRoZSBQTSBjb3VudGVycyBzdGF5IGJhbGFuY2Vk IGJ5IHB1dHRpbmcgdGhlIHJlZmVyZW5jZSB0aGUKPiArCSAqIGpvYiB0b29rLCBhbmQgcmVxdWVz dCBpZGxlIHdoaWxlIGRvaW5nIGl0IHNvIHRoZSBjb3JlIGNhbiBzdXNwZW5kLgo+ICAJICovCgp3 aXRoIG15IGNvbW1lbnQgaW4gcGF0Y2ggMy8xNSBmaXhlZAoKUmV2aWV3ZWQtYnk6IEhlaWtvIFN0 dWVibmVyIDxoZWlrb0BzbnRlY2guZGU+Cgo+ICAJc2NvcGVkX2d1YXJkKG11dGV4LCAmY29yZS0+ am9iX2xvY2spIHsKPiAgCQlpZiAoY29yZS0+aW5fZmxpZ2h0X2pvYikKPiAtCQkJcG1fcnVudGlt ZV9wdXRfbm9pZGxlKGNvcmUtPmRldik7Cj4gKwkJCXBtX3J1bnRpbWVfcHV0X2F1dG9zdXNwZW5k KGNvcmUtPmRldik7Cj4gIAo+ICAJCWlvbW11X2RldGFjaF9ncm91cChOVUxMLCBjb3JlLT5pb21t dV9ncm91cCk7Cj4gIAo+IAoKCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcm9ja2NoaXAK