diff for duplicates of <3375560.xz1gJhmReB@avalon> diff --git a/a/1.txt b/N1/1.txt index 046a571..a87188e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -23,8 +23,7 @@ On Friday 03 July 2015 00:21:50 Ben Hutchings wrote: > > > + > > > + /* Pins not associated with a GPIO port, placed after all the GPIOs */ -> > > + [RCAR_GP_PIN(5, 31) + 1] = -> > +> > > + [RCAR_GP_PIN(5, 31) + 1] > > > > I'm sorry but I still don't like this. gcc outputs a warning when > > overriding an initializer if you enable -Wextra, which leads me to > > believe this construct is dubious. It should at least be tested with @@ -132,8 +131,7 @@ On Friday 03 July 2015 00:21:50 Ben Hutchings wrote: > + PORT_GP_32(5, _GP_GPIO, unused), > > /* Pins not associated with a GPIO port, placed after all the GPIOs */ -> - [RCAR_GP_PIN(5, 31) + 1] = -> SH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15), +> - [RCAR_GP_PIN(5, 31) + 1] > SH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15), > SH_PFC_PIN_NAMED(ROW_GROUP_A('G'), 15, AG15), > SH_PFC_PIN_NAMED(ROW_GROUP_A('H'), 15, AH15), > diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c diff --git a/a/content_digest b/N1/content_digest index 0082dd0..86f8c4c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\01435879310.7541.2.camel@codethink.co.uk\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH v4 2/8] pinctrl: sh-pfc: r8a7790: Implement voltage switching for SDHI\0" - "Date\0Wed, 03 Feb 2016 11:59:34 +0200\0" + "Date\0Wed, 03 Feb 2016 09:59:34 +0000\0" "To\0Ben Hutchings <ben.hutchings@codethink.co.uk>\0" "Cc\0Ian Molton <ian@mnementh.co.uk>" linux-mmc@vger.kernel.org @@ -40,8 +40,7 @@ "> > > +\n" "> > > +\t/* Pins not associated with a GPIO port, placed after all the GPIOs \n" "*/\n" - "> > > +\t[RCAR_GP_PIN(5, 31) + 1] =\n" - "> > \n" + "> > > +\t[RCAR_GP_PIN(5, 31) + 1] > > \n" "> > I'm sorry but I still don't like this. gcc outputs a warning when\n" "> > overriding an initializer if you enable -Wextra, which leads me to\n" "> > believe this construct is dubious. It should at least be tested with\n" @@ -149,8 +148,7 @@ "> +\tPORT_GP_32(5, _GP_GPIO, unused),\n" "> \n" "> \t/* Pins not associated with a GPIO port, placed after all the GPIOs */\n" - "> -\t[RCAR_GP_PIN(5, 31) + 1] =\n" - "> \tSH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15),\n" + "> -\t[RCAR_GP_PIN(5, 31) + 1] > \tSH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15),\n" "> \tSH_PFC_PIN_NAMED(ROW_GROUP_A('G'), 15, AG15),\n" "> \tSH_PFC_PIN_NAMED(ROW_GROUP_A('H'), 15, AH15),\n" "> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c\n" @@ -235,4 +233,4 @@ "\n" Laurent Pinchart -3ef94fb2ceafed96cd35e64d58b4278a6d66ba2ec1663f8a07d95d5b3720d73e +3688600e040b2ef231f0cfdbe7821d8dee3b962a94e1cd3e385b4d5f2d869ab9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.