From: Richard Weinberger <richard@sigma-star.at>
To: David Woodhouse <dwmw2@infradead.org>
Cc: mingo@kernel.org, luto@kernel.org, arjan@linux.intel.com,
bp@alien8.de, dan.j.williams@intel.com,
dave.hansen@linux.intel.com, gregkh@linuxfoundation.org,
jpoimboe@redhat.com, torvalds@linux-foundation.org,
peterz@infradead.org, tglx@linutronix.de,
arjan.van.de.ven@intel.com, dave.hansen@intel.com,
jmattson@google.com, karahmed@amazon.de, kvm@vger.kernel.org,
pbonzini@redhat.com, rkrcmar@redhat.com, sironi@amazon.de,
linux-kernel@vger.kernel.org
Subject: Re: Revert "x86/speculation: Simplify indirect_branch_prediction_barrier()" crashes KVM guest
Date: Fri, 16 Feb 2018 00:45:29 +0100 [thread overview]
Message-ID: <3378738.8dlq1zuRqp@blindfold> (raw)
In-Reply-To: <1518737310.7876.10.camel@infradead.org>
Am Freitag, 16. Februar 2018, 00:28:30 CET schrieb David Woodhouse:
> On Fri, 2018-02-16 at 00:12 +0100, Richard Weinberger wrote:
> > [ 2.791518] Code: 8b 45 00 49 8b 7d 08 49 83 c5 18 31 d2 31 f6 ff
> > d0 49 8b 45 00 48 85 c0 75 e9 eb b1 b9 49 00 00 00 b8 01 00 00 00 ba
> > 00 00 00 00 <0f> 30 e9 68 fd ff ff 9c 58 0f 1f 44 00 00 48 89 c5 fa
> > 66 0f 1f
>
> 23: b9 49 00 00 00 mov $0x49,%ecx
> 28: b8 01 00 00 00 mov $0x1,%eax
> 2d: ba 00 00 00 00 mov $0x0,%edx
> 32: 0f 30 wrmsr
>
> The faulting instruction is the wrmsr itself. That shouldn't happen; if
> the CPUID bit indicates that the MSR exists, then it should exist.
>
> The reverted patch did use the C __wrmsr() macro which contained a
> fixup for this GP# but it was just a side-effect of the "cleanup" — it
> wasn't intentional because that really shouldn't happen. That looks
> like a qemu bug as first glance.
Hmmm, yes seems so. Just gave latest qemu a try, works fine. ;-\
Thanks,
//richard
--
sigma star gmbh - Eduard-Bodem-Gasse 6 - 6020 Innsbruck - Austria
ATU66964118 - FN 374287y
prev parent reply other threads:[~2018-02-15 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 23:12 Revert "x86/speculation: Simplify indirect_branch_prediction_barrier()" crashes KVM guest Richard Weinberger
2018-02-15 23:28 ` David Woodhouse
2018-02-15 23:45 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3378738.8dlq1zuRqp@blindfold \
--to=richard@sigma-star.at \
--cc=arjan.van.de.ven@intel.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmattson@google.com \
--cc=jpoimboe@redhat.com \
--cc=karahmed@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=sironi@amazon.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.