Re: [PATCH v16 1/5] dt-bindings: mmc: sdhci-pxa: restrict pinctrl to pxav1

["Duje Mihanović" <duje@dujemihanovic.xyz>]

On Wednesday, 9 July 2025 09:32:06 Central European Summer Time Krzysztof 
Kozlowski wrote:
> On Tue, Jul 08, 2025 at 07:09:46PM +0200, Duje Mihanović wrote:
> > The current pinctrl properties apply only to the pxav1 controller.
> 
> Why they are not applicable for pxav3?

state_cmd_gpio is used for working around a PXA168 SDIO erratum. That SoC uses 
the pxav1 controller and no such erratum exists on any of the other PXA SoCs.

> > Adding one default pinctrl node to a pxav3 controller therefore causes
> > a schema warning.
> > 
> > Check the existing properties only on pxav1. pxav2 and pxav3 may add
> > their own set of pinctrl properties if and when needed.
> 
> This should be rather made complete here, because properties should be
> defined in top-level, not in allOf: block. Strictly speaking pinctrl-xxx
> are defined in core schema, but still the binding should follow same
> rule - define them in top.

Would it then be acceptable to declare the pinctrl properties in the top level 
and define each controller's respective description: and items: in the allOf: 
block?

Regards,
--
Duje