From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:32990 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbeETIV7 (ORCPT ); Sun, 20 May 2018 04:21:59 -0400 From: Laurent Pinchart To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Koji Matsuoka Subject: Re: [PATCH 1/5] drm: rcar-du: Add r8a77995 device support Date: Sun, 20 May 2018 11:22:21 +0300 Message-ID: <3388861.61vxE1Ocq2@avalon> In-Reply-To: <1526386840-15368-2-git-send-email-ulrich.hecht+renesas@gmail.com> References: <1526386840-15368-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1526386840-15368-2-git-send-email-ulrich.hecht+renesas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Ulrich, Thank you for the patch. On Tuesday, 15 May 2018 15:20:36 EEST Ulrich Hecht wrote: > From: Koji Matsuoka > > Add support for the R-Car D3 (R8A77995) SoC to the R-Car DU driver. > > Signed-off-by: Koji Matsuoka > Signed-off-by: Ulrich Hecht > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 05745e8..ba82842 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -266,6 +266,31 @@ static const struct rcar_du_device_info > rcar_du_r8a77970_info = { .num_lvds = 1, > }; > > +static const struct rcar_du_device_info rcar_du_r8a77995_info = { > + .gen = 3, > + .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > + | RCAR_DU_FEATURE_EXT_CTRL_REGS > + | RCAR_DU_FEATURE_VSP1_SOURCE, > + .num_crtcs = 2, > + .routes = { > + /* R8A77995 has two LVDS output and one RGB output. > + */ This comment holds on a single line. Apart from that the patch looks good to me, but it conflicts with commit 5361cc7f8e9146f393cfcb76890d8c80a4e73086 Author: Kieran Bingham Date: Fri Apr 27 23:21:52 2018 +0100 drm: rcar-du: Split CRTC handling to support hardware indexing that has been queued in Dave's DRM tree for v4.18. The num_crtcs field has been replaced with a channels_mask field. I can fix when applying but I can't test the result as I don't have a D3 board, so I'd prefer if you could submit a v2 rebased on top of Dave's drm-next branch. I'm also wondering whether we also need commit 6f3850955384cff722f02530f570806897b02a87 Author: Koji Matsuoka Date: Wed Dec 6 20:30:24 2017 +0900 drm: rcar-du: Fix digital RGB routing for R8A77995 from the BSP. What's your opinion ? > + [RCAR_DU_OUTPUT_DPAD0] = { > + .possible_crtcs = BIT(0) | BIT(1), > + .port = 0, > + }, > + [RCAR_DU_OUTPUT_LVDS0] = { > + .possible_crtcs = BIT(0), > + .port = 1, > + }, > + [RCAR_DU_OUTPUT_LVDS1] = { > + .possible_crtcs = BIT(1), > + .port = 2, > + }, > + }, > + .num_lvds = 2, > +}; > + > static const struct of_device_id rcar_du_of_table[] = { > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > @@ -278,6 +303,7 @@ static const struct of_device_id rcar_du_of_table[] = { > { .compatible = "renesas,du-r8a7795", .data = &rcar_du_r8a7795_info }, > { .compatible = "renesas,du-r8a7796", .data = &rcar_du_r8a7796_info }, > { .compatible = "renesas,du-r8a77970", .data = &rcar_du_r8a77970_info }, > + { .compatible = "renesas,du-r8a77995", .data = &rcar_du_r8a77995_info }, > { } > }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/5] drm: rcar-du: Add r8a77995 device support Date: Sun, 20 May 2018 11:22:21 +0300 Message-ID: <3388861.61vxE1Ocq2@avalon> References: <1526386840-15368-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1526386840-15368-2-git-send-email-ulrich.hecht+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 161566E163 for ; Sun, 20 May 2018 08:21:59 +0000 (UTC) In-Reply-To: <1526386840-15368-2-git-send-email-ulrich.hecht+renesas@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, Koji Matsuoka , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVWxyaWNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxNSBNYXkg MjAxOCAxNToyMDozNiBFRVNUIFVscmljaCBIZWNodCB3cm90ZToKPiBGcm9tOiBLb2ppIE1hdHN1 b2thIDxrb2ppLm1hdHN1b2thLnhtQHJlbmVzYXMuY29tPgo+IAo+IEFkZCBzdXBwb3J0IGZvciB0 aGUgUi1DYXIgRDMgKFI4QTc3OTk1KSBTb0MgdG8gdGhlIFItQ2FyIERVIGRyaXZlci4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBLb2ppIE1hdHN1b2thIDxrb2ppLm1hdHN1b2thLnhtQHJlbmVzYXMuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IFVscmljaCBIZWNodCA8dWxyaWNoLmhlY2h0K3JlbmVzYXNAZ21h aWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jIHwg MjYgKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2Vy dGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9k dV9kcnYuYwo+IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyBpbmRleCAw NTc0NWU4Li5iYTgyODQyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5j Cj4gQEAgLTI2Niw2ICsyNjYsMzEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCByY2FyX2R1X2Rldmlj ZV9pbmZvCj4gcmNhcl9kdV9yOGE3Nzk3MF9pbmZvID0geyAubnVtX2x2ZHMgPSAxLAo+ICB9Owo+ IAo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8gcmNhcl9kdV9yOGE3 Nzk5NV9pbmZvID0gewo+ICsJLmdlbiA9IDMsCj4gKwkuZmVhdHVyZXMgPSBSQ0FSX0RVX0ZFQVRV UkVfQ1JUQ19JUlFfQ0xPQ0sKPiArCQkgIHwgUkNBUl9EVV9GRUFUVVJFX0VYVF9DVFJMX1JFR1MK PiArCQkgIHwgUkNBUl9EVV9GRUFUVVJFX1ZTUDFfU09VUkNFLAo+ICsJLm51bV9jcnRjcyA9IDIs Cj4gKwkucm91dGVzID0gewo+ICsJCS8qIFI4QTc3OTk1IGhhcyB0d28gTFZEUyBvdXRwdXQgYW5k IG9uZSBSR0Igb3V0cHV0Lgo+ICsJCSAqLwoKVGhpcyBjb21tZW50IGhvbGRzIG9uIGEgc2luZ2xl IGxpbmUuCgpBcGFydCBmcm9tIHRoYXQgdGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUsIGJ1dCBp dCBjb25mbGljdHMgd2l0aAoKY29tbWl0IDUzNjFjYzdmOGU5MTQ2ZjM5M2NmY2I3Njg5MGQ4Yzgw YTRlNzMwODYKQXV0aG9yOiBLaWVyYW4gQmluZ2hhbSA8a2llcmFuLmJpbmdoYW0rcmVuZXNhc0Bp ZGVhc29uYm9hcmQuY29tPgpEYXRlOiAgIEZyaSBBcHIgMjcgMjM6MjE6NTIgMjAxOCArMDEwMAoK ICAgIGRybTogcmNhci1kdTogU3BsaXQgQ1JUQyBoYW5kbGluZyB0byBzdXBwb3J0IGhhcmR3YXJl IGluZGV4aW5nCgp0aGF0IGhhcyBiZWVuIHF1ZXVlZCBpbiBEYXZlJ3MgRFJNIHRyZWUgZm9yIHY0 LjE4LiBUaGUgbnVtX2NydGNzIGZpZWxkIGhhcyAKYmVlbiByZXBsYWNlZCB3aXRoIGEgY2hhbm5l bHNfbWFzayBmaWVsZC4gSSBjYW4gZml4IHdoZW4gYXBwbHlpbmcgYnV0IEkgY2FuJ3QgCnRlc3Qg dGhlIHJlc3VsdCBhcyBJIGRvbid0IGhhdmUgYSBEMyBib2FyZCwgc28gSSdkIHByZWZlciBpZiB5 b3UgY291bGQgc3VibWl0IAphIHYyIHJlYmFzZWQgb24gdG9wIG9mIERhdmUncyBkcm0tbmV4dCBi cmFuY2guCgpJJ20gYWxzbyB3b25kZXJpbmcgd2hldGhlciB3ZSBhbHNvIG5lZWQKCmNvbW1pdCA2 ZjM4NTA5NTUzODRjZmY3MjJmMDI1MzBmNTcwODA2ODk3YjAyYTg3CkF1dGhvcjogS29qaSBNYXRz dW9rYSA8a29qaS5tYXRzdW9rYS54bUByZW5lc2FzLmNvbT4KRGF0ZTogICBXZWQgRGVjIDYgMjA6 MzA6MjQgMjAxNyArMDkwMAoKICAgIGRybTogcmNhci1kdTogRml4IGRpZ2l0YWwgUkdCIHJvdXRp bmcgZm9yIFI4QTc3OTk1Cgpmcm9tIHRoZSBCU1AuIFdoYXQncyB5b3VyIG9waW5pb24gPwoKPiAr CQlbUkNBUl9EVV9PVVRQVVRfRFBBRDBdID0gewo+ICsJCQkucG9zc2libGVfY3J0Y3MgPSBCSVQo MCkgfCBCSVQoMSksCj4gKwkJCS5wb3J0ID0gMCwKPiArCQl9LAo+ICsJCVtSQ0FSX0RVX09VVFBV VF9MVkRTMF0gPSB7Cj4gKwkJCS5wb3NzaWJsZV9jcnRjcyA9IEJJVCgwKSwKPiArCQkJLnBvcnQg PSAxLAo+ICsJCX0sCj4gKwkJW1JDQVJfRFVfT1VUUFVUX0xWRFMxXSA9IHsKPiArCQkJLnBvc3Np YmxlX2NydGNzID0gQklUKDEpLAo+ICsJCQkucG9ydCA9IDIsCj4gKwkJfSwKPiArCX0sCj4gKwku bnVtX2x2ZHMgPSAyLAo+ICt9Owo+ICsKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2Vf aWQgcmNhcl9kdV9vZl90YWJsZVtdID0gewo+ICAJeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1 LXI4YTc3NDMiLCAuZGF0YSA9ICZyemcxX2R1X3I4YTc3NDNfaW5mbyB9LAo+ICAJeyAuY29tcGF0 aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3NDUiLCAuZGF0YSA9ICZyemcxX2R1X3I4YTc3NDVfaW5m byB9LAo+IEBAIC0yNzgsNiArMzAzLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2Vf aWQgcmNhcl9kdV9vZl90YWJsZVtdID0gewo+ICAJeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1 LXI4YTc3OTUiLCAuZGF0YSA9ICZyY2FyX2R1X3I4YTc3OTVfaW5mbyB9LAo+ICAJeyAuY29tcGF0 aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3OTYiLCAuZGF0YSA9ICZyY2FyX2R1X3I4YTc3OTZfaW5m byB9LAo+ICAJeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3OTcwIiwgLmRhdGEgPSAm cmNhcl9kdV9yOGE3Nzk3MF9pbmZvIH0sCj4gKwl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMsZHUt cjhhNzc5OTUiLCAuZGF0YSA9ICZyY2FyX2R1X3I4YTc3OTk1X2luZm8gfSwKPiAgCXsgfQo+ICB9 OwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=