From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2445CCCF9F8 for ; Sat, 1 Nov 2025 11:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TlHFSQLWkknhMBMzv5JOmlU/cXjMPui0qcErIXp3wgk=; b=x/3xIjs/Yq+ePX RJOEu3TlRIy5jPpfwES9iTVB8rxCa8jFoVq4cxA/ww0jKSVXRs8pmDS3CNIiFuJKXNu4dmFR6uPpW mRUlp4D+jnzhST8uiQUsigBbsNqP7Fjru1wFtjT5XK4KgRUkA5wKrEaQXTcERs8pWxuct6oIW/Lhr +AjZ4pLLtjFCL/x9+gvGHmEXS/AyVPH8H6MlyZcde5dC58dmHFpMyr3dDn5PRAv/jGB6D8FBFWJ34 DsZe2ekbwJJlCOGXsm7xKVljTxXqaG26qjD3PaVHWON6eDfWIPQ8DY5LgJG8JIXxjwSvqeaZZOQll UAxOzd3NJ3lHaM/+V7AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFA9G-00000007JbJ-3Qni; Sat, 01 Nov 2025 11:51:58 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFA9C-00000007Jak-40ox for linux-rockchip@lists.infradead.org; Sat, 01 Nov 2025 11:51:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=JDKD/R+9K+muuhY+XkY+sEMXaT9VzPK07TMwgKEtODo=; b=s689bHBr4MhZ0vC2+14m076COd j/Q/2TTDmgCXIRmSQmZqsa6nfSCfZGSZj8gw0Vcz/lWKXhM163CYmojRyg987boADOiKVMukRg680 WpGbb0H81WFgO0fdj89KMIFGGG8eCYU9+MTm3JdFXdIM4Zbs45kLMSKMvNfIxca3T5v2cul5emIhc TB5VemdtdkMWSAZjY8XD/lKBxN40/Fbtr6J2BLgrdujyVQJ29DfCw9Wh9H9nYnbCcNdP63q1ictXq 0OoHx+m3SpM+Pzqjc6K9BFwJ+Imx24AczH+6XxOmtAqQrGcHPzlb9XQZQcWl7OLUhJ/ofVULgy3Zg q8e6qEyA==; Received: from i53875b80.versanet.de ([83.135.91.128] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vFA8u-0008O8-CF; Sat, 01 Nov 2025 12:51:36 +0100 From: Heiko Stuebner To: FUKAUMI Naoki Subject: Re: [PATCH v2 1/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5B+/5T Date: Sat, 01 Nov 2025 12:51:35 +0100 Message-ID: <3389401.44csPzL39Z@phil> In-Reply-To: <20251029130200.987580-1-naoki@radxa.com> References: <20251029130200.987580-1-naoki@radxa.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251101_045155_832716_4806D144 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmitry.baryshkov@oss.qualcomm.com, robh@kernel.org, conor+dt@kernel.org, liujianfeng1994@gmail.com, detlev.casanova@collabora.com, linux-rockchip@lists.infradead.org, sebastian.reichel@collabora.com, damon.ding@rock-chips.com, FUKAUMI Naoki , dmitry.osipenko@collabora.com, jbx6244@gmail.com, andy.yan@rock-chips.com, krzk+dt@kernel.org, didi.debian@cknow.org, shreeya.patel@collabora.com, nicolas.frattaroli@collabora.com, devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGksCgpBbSBNaXR0d29jaCwgMjkuIE9rdG9iZXIgMjAyNSwgMTQ6MDE6NTkgTWl0dGVsZXVyb3DD pGlzY2hlIE5vcm1hbHplaXQgc2NocmllYiBGVUtBVU1JIE5hb2tpOgo+IFRoZSBSYWR4YSBST0NL IDVCKy81VCBVU0IgVHlwZS1DIHBvcnQgc3VwcG9ydHMgRHVhbCBSb2xlIERhdGEgYW5kCj4gc2hv dWxkIGFsc28gYWN0IGFzIGEgaG9zdC4gSG93ZXZlciwgY3VycmVudGx5LCB3aGVuIGFjdGluZyBh cyBhIGhvc3QsCj4gb25seSBzZWxmLXBvd2VyZWQgZGV2aWNlcyB3b3JrLgo+IAo+IFNpbmNlIHRo ZSBST0NLIDVCKyBzdXBwb3J0cyBEdWFsIFJvbGUgUG93ZXIsIHNldCB0aGUgcG93ZXItcm9sZQo+ IHByb3BlcnR5IHRvICJkdWFsIiBhbmQgdGhlIHRyeS1wb3dlci1yb2xlIHByb3BlcnR5IHRvICJz aW5rIi4gKGFsb25nCj4gd2l0aCByZWxhdGVkIHByb3BlcnRpZXMpCj4gCj4gVGhlIFJPQ0sgNVQg c2hvdWxkIG9ubHkgc3VwcG9ydCB0aGUgInNvdXJjZSIgcG93ZXIgcm9sZSwgYnV0IHdoZW4gdGhl Cj4gcG93ZXItcm9sZSBwcm9wZXJ0eSBpcyBzZXQgdG8gInNvdXJjZSIsIHdoZW4gYWN0aW5nIGFz IGEgaG9zdCwgb25seQo+IHNlbGYtcG93ZXJlZCBkZXZpY2VzIHdvcmsuIEFzIGEgd29ya2Fyb3Vu ZCwgc2V0IHRoZSBwb3dlci1yb2xlCj4gcHJvcGVydHkgdG8gImR1YWwiIGFuZCB0aGUgdHJ5LXBv d2VyLXJvbGUgcHJvcGVydHkgdG8gInNpbmsiLgo+Cj4gVGhpcyBhbGxvd3MgdGhlIHBvcnQgdG8g YWN0IGFzIGEgaG9zdCwgc3VwcGx5IHBvd2VyIHRvIHRoZSBwb3J0LCBhbmQKPiBhbGxvdyBidXMt cG93ZXJlZCBkZXZpY2VzIHRvIHdvcmsuCgpTbyBpdCBzb3VuZHMgbGlrZSB5b3UncmUgd29ya2lu ZyBhcm91bmQgYW4gaXNzdWUgY29taW5nIGZyb20gdGhlIExpbnV4CnVzYiBzdGFjayBoZXJlPyBJ ZiB0aGUgdXNiIHN0YWNrIGhhbmRsZXMgdGhvc2UgcG93ZXIgcm9sZXMgd3JvbmdseQpzaG91bGRu J3QgaXQgYmUgZml4ZWQgaW5zdGVhZCBvZiBpbnRyb2R1Y2luZyB3cm9uZyBoYWNrcyB0byBnZW5l cmljCmhhcmR3YXJlIGRlc2NyaXB0aW9ucz8KCkxpa2UgTGludXggaXNuJ3QgdGhlIG9ubHkgY29u c3VtZXIgb2YgRGV2aWNldHJlZXMsIHNvIGhhY2tpbmcgdGhlbQp0b2dldGhlciB0byB3YWxrIGFy b3VuZCBkcml2ZXIgaXNzdWVzIGZlZWxzIHdyb25nLgoKCkhlaWtvCgo+IE5vdGUgdGhhdCB0aGVy ZSBpcyBhIHNlcGFyYXRlIGtub3duIGlzc3VlIHdoZXJlIFVTQiAzLjAgU3VwZXJTcGVlZAo+IGRl dmljZXMgZG8gbm90IHdvcmsgd2hlbiBvcmllbnRlZCBpbiByZXZlcnNlLiBUaGlzIGlzc3VlIHNo b3VsZCBiZQo+IGFkZHJlc3NlZCBzZXBhcmF0ZWx5LiAoVVNCIDIuMC8xLjEgZGV2aWNlcyB3b3Jr IGluIGJvdGggb3JpZW50YXRpb25zKQo+IAo+IEZpeGVzOiA2N2IyYzE1ZDhmYjNjICgiYXJtNjQ6 IGR0czogcm9ja2NoaXA6IGFkZCBVU0ItQyBzdXBwb3J0IGZvciBST0NLIDVCLzVCKy81VCIpCj4g U2lnbmVkLW9mZi1ieTogRlVLQVVNSSBOYW9raSA8bmFva2lAcmFkeGEuY29tPgo+IC0tLQo+IENo YW5nZXMgaW4gdjI6Cj4gLSBSZWZpbmUgY29tbWl0IG1lc3NhZ2UKPiAtIFVzZSBib2FyZC1zcGVj aWZpYyBkdHMgdG8gZGVzY3JpYmUgKHRyeS0pcG93ZXItcm9sZQo+IC0tLQo+ICBhcmNoL2FybTY0 L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC1yb2NrLTViLTVicC01dC5kdHNpIHwgNCArKy0tCj4g IGFyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNWItcGx1cy5kdHMgICAg fCA1ICsrKysrCj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNWIu ZHRzICAgICAgICAgfCA0ICsrKysKPiAgYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1 ODgtcm9jay01dC5kdHMgICAgICAgICB8IDUgKysrKysKPiAgNCBmaWxlcyBjaGFuZ2VkLCAxNiBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0 L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC1yb2NrLTViLTVicC01dC5kdHNpIGIvYXJjaC9hcm02 NC9ib290L2R0cy9yb2NrY2hpcC9yazM1ODgtcm9jay01Yi01YnAtNXQuZHRzaQo+IGluZGV4IDNi YmU3ODgxMGVjNmYuLjdhYWM3N2RmYzVmMTYgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm02NC9ib290 L2R0cy9yb2NrY2hpcC9yazM1ODgtcm9jay01Yi01YnAtNXQuZHRzaQo+ICsrKyBiL2FyY2gvYXJt NjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNWItNWJwLTV0LmR0c2kKPiBAQCAtMzMx LDEyICszMzEsMTIgQEAgdXNiX2NvbjogY29ubmVjdG9yIHsKPiAgCQkJZGF0YS1yb2xlID0gImR1 YWwiOwo+ICAJCQkvKiBmdXNiMzAyIHN1cHBvcnRzIFBEIFJldiAyLjAgVmVyIDEuMiAqLwo+ICAJ CQlwZC1yZXZpc2lvbiA9IC9iaXRzLyA4IDwweDIgMHgwIDB4MSAweDI+Owo+IC0JCQlwb3dlci1y b2xlID0gInNpbmsiOwo+IC0JCQl0cnktcG93ZXItcm9sZSA9ICJzaW5rIjsKPiAgCQkJb3Atc2lu ay1taWNyb3dhdHQgPSA8MTAwMDAwMD47Cj4gIAkJCXNpbmstcGRvcyA9Cj4gIAkJCQk8UERPX0ZJ WEVEKDUwMDAsIDMwMDAsIFBET19GSVhFRF9VU0JfQ09NTSk+LAo+ICAJCQkJPFBET19WQVIoNTAw MCwgMjAwMDAsIDUwMDApPjsKPiArCQkJc291cmNlLXBkb3MgPQo+ICsJCQkJPFBET19GSVhFRCg1 MDAwLCAzMDAwLCBQRE9fRklYRURfVVNCX0NPTU0pPjsKPiAgCj4gIAkJCWFsdG1vZGVzIHsKPiAg CQkJCWRpc3BsYXlwb3J0IHsKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazM1ODgtcm9jay01Yi1wbHVzLmR0cyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2No aXAvcmszNTg4LXJvY2stNWItcGx1cy5kdHMKPiBpbmRleCA1ZTk4NGE0NDEyMGU0Li4wN2E4NDBk OWIzODU5IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4 LXJvY2stNWItcGx1cy5kdHMKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3Jr MzU4OC1yb2NrLTViLXBsdXMuZHRzCj4gQEAgLTExMCw2ICsxMTAsMTEgQEAgdmNjNXYwX2hvc3Rf ZW46IHZjYzV2MC1ob3N0LWVuIHsKPiAgCX07Cj4gIH07Cj4gIAo+ICsmdXNiX2NvbiB7Cj4gKwlw b3dlci1yb2xlID0gImR1YWwiOwo+ICsJdHJ5LXBvd2VyLXJvbGUgPSAic2luayI7Cj4gK307Cj4g Kwo+ICAmdXNiZHBfcGh5MCB7Cj4gIAlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ICAJcGlu Y3RybC0wID0gPCZ1c2JjX3NidV9kYz47Cj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9k dHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNWIuZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazM1ODgtcm9jay01Yi5kdHMKPiBpbmRleCA4ZWYwMTAxMGQ5ODViLi5kYTEzZGFmY2Jj ODIzIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LXJv Y2stNWIuZHRzCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1ODgtcm9j ay01Yi5kdHMKPiBAQCAtNDksNiArNDksMTAgQEAgdmNjNXYwX2hvc3RfZW46IHZjYzV2MC1ob3N0 LWVuIHsKPiAgCX07Cj4gIH07Cj4gIAo+ICsmdXNiX2NvbiB7Cj4gKwlwb3dlci1yb2xlID0gInNp bmsiOwo+ICt9Owo+ICsKPiAgJnVzYmRwX3BoeTAgewo+ICAJcGluY3RybC1uYW1lcyA9ICJkZWZh dWx0IjsKPiAgCXBpbmN0cmwtMCA9IDwmdXNiY19zYnVfZGM+Owo+IGRpZmYgLS1naXQgYS9hcmNo L2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC1yb2NrLTV0LmR0cyBiL2FyY2gvYXJtNjQv Ym9vdC9kdHMvcm9ja2NoaXAvcmszNTg4LXJvY2stNXQuZHRzCj4gaW5kZXggYzE3NjM4MzVmNTNk NC4uOTZmZmZmZWM3ZTA1ZCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tj aGlwL3JrMzU4OC1yb2NrLTV0LmR0cwo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2No aXAvcmszNTg4LXJvY2stNXQuZHRzCj4gQEAgLTEzMCw2ICsxMzAsMTEgQEAgdXNiY19zYnVfZGM6 IHVzYmMtc2J1LWRjIHsKPiAgCX07Cj4gIH07Cj4gIAo+ICsmdXNiX2NvbiB7Cj4gKwlwb3dlci1y b2xlID0gImR1YWwiOwo+ICsJdHJ5LXBvd2VyLXJvbGUgPSAic2luayI7Cj4gK307Cj4gKwo+ICAm dXNiZHBfcGh5MCB7Cj4gIAlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ICAJcGluY3RybC0w ID0gPCZ1c2JjX3NidV9kYz47Cj4gCgoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tj aGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C9A4134AB for ; Sat, 1 Nov 2025 11:51:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761997913; cv=none; b=C5qL4jXmIECbk/FBJsLNSVRrg8R9D3Cg3Hit/BdG9dbfRG5lY0MN1f0ad8OmK9IE0qi72NcpmHK02kXsG6wPSNsAMDEQ8GR8Edm4a7wY1MrrdVQjUJS3T//0g8LHhtTcB9XlUi3zNuLiFZzAoaAS7L43yeScA3V1LAUewPQyCHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761997913; c=relaxed/simple; bh=80GYiOXyQj396dKaPorO5SbPTcTsCGXvm5DwswRqxi0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NJ+/f96yjoOXdUCWBfCNk7Eru44dfryhGsPZD/11xMTW2zZuD4WKls14klF/+6DAhVmtFb/Nwmjmy9I7suJqY3+xn5Nge/8efupgJGXsFeyBLOWJ+FjfRFqsiV4dm4NcyrH/ALBPVaT3wVJM+2yGytDMmT8ux7r8NMNaM0dBA6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=s689bHBr; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="s689bHBr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=JDKD/R+9K+muuhY+XkY+sEMXaT9VzPK07TMwgKEtODo=; b=s689bHBr4MhZ0vC2+14m076COd j/Q/2TTDmgCXIRmSQmZqsa6nfSCfZGSZj8gw0Vcz/lWKXhM163CYmojRyg987boADOiKVMukRg680 WpGbb0H81WFgO0fdj89KMIFGGG8eCYU9+MTm3JdFXdIM4Zbs45kLMSKMvNfIxca3T5v2cul5emIhc TB5VemdtdkMWSAZjY8XD/lKBxN40/Fbtr6J2BLgrdujyVQJ29DfCw9Wh9H9nYnbCcNdP63q1ictXq 0OoHx+m3SpM+Pzqjc6K9BFwJ+Imx24AczH+6XxOmtAqQrGcHPzlb9XQZQcWl7OLUhJ/ofVULgy3Zg q8e6qEyA==; Received: from i53875b80.versanet.de ([83.135.91.128] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vFA8u-0008O8-CF; Sat, 01 Nov 2025 12:51:36 +0100 From: Heiko Stuebner To: FUKAUMI Naoki Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, liujianfeng1994@gmail.com, dmitry.baryshkov@oss.qualcomm.com, andy.yan@rock-chips.com, sebastian.reichel@collabora.com, nicolas.frattaroli@collabora.com, dmitry.osipenko@collabora.com, damon.ding@rock-chips.com, jbx6244@gmail.com, shreeya.patel@collabora.com, didi.debian@cknow.org, cristian.ciocaltea@collabora.com, detlev.casanova@collabora.com, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, FUKAUMI Naoki Subject: Re: [PATCH v2 1/2] arm64: dts: rockchip: Fix USB Type-C host mode for Radxa ROCK 5B+/5T Date: Sat, 01 Nov 2025 12:51:35 +0100 Message-ID: <3389401.44csPzL39Z@phil> In-Reply-To: <20251029130200.987580-1-naoki@radxa.com> References: <20251029130200.987580-1-naoki@radxa.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi, Am Mittwoch, 29. Oktober 2025, 14:01:59 Mitteleurop=C3=A4ische Normalzeit s= chrieb FUKAUMI Naoki: > The Radxa ROCK 5B+/5T USB Type-C port supports Dual Role Data and > should also act as a host. However, currently, when acting as a host, > only self-powered devices work. >=20 > Since the ROCK 5B+ supports Dual Role Power, set the power-role > property to "dual" and the try-power-role property to "sink". (along > with related properties) >=20 > The ROCK 5T should only support the "source" power role, but when the > power-role property is set to "source", when acting as a host, only > self-powered devices work. As a workaround, set the power-role > property to "dual" and the try-power-role property to "sink". > > This allows the port to act as a host, supply power to the port, and > allow bus-powered devices to work. So it sounds like you're working around an issue coming from the Linux usb stack here? If the usb stack handles those power roles wrongly shouldn't it be fixed instead of introducing wrong hacks to generic hardware descriptions? Like Linux isn't the only consumer of Devicetrees, so hacking them together to walk around driver issues feels wrong. Heiko > Note that there is a separate known issue where USB 3.0 SuperSpeed > devices do not work when oriented in reverse. This issue should be > addressed separately. (USB 2.0/1.1 devices work in both orientations) >=20 > Fixes: 67b2c15d8fb3c ("arm64: dts: rockchip: add USB-C support for ROCK 5= B/5B+/5T") > Signed-off-by: FUKAUMI Naoki > --- > Changes in v2: > - Refine commit message > - Use board-specific dts to describe (try-)power-role > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 4 ++-- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dts | 5 +++++ > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 4 ++++ > arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 5 +++++ > 4 files changed, 16 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/ar= ch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi > index 3bbe78810ec6f..7aac77dfc5f16 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi > @@ -331,12 +331,12 @@ usb_con: connector { > data-role =3D "dual"; > /* fusb302 supports PD Rev 2.0 Ver 1.2 */ > pd-revision =3D /bits/ 8 <0x2 0x0 0x1 0x2>; > - power-role =3D "sink"; > - try-power-role =3D "sink"; > op-sink-microwatt =3D <1000000>; > sink-pdos =3D > , > ; > + source-pdos =3D > + ; > =20 > altmodes { > displayport { > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dts b/arch/= arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dts > index 5e984a44120e4..07a840d9b3859 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dts > @@ -110,6 +110,11 @@ vcc5v0_host_en: vcc5v0-host-en { > }; > }; > =20 > +&usb_con { > + power-role =3D "dual"; > + try-power-role =3D "sink"; > +}; > + > &usbdp_phy0 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&usbc_sbu_dc>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64= /boot/dts/rockchip/rk3588-rock-5b.dts > index 8ef01010d985b..da13dafcbc823 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > @@ -49,6 +49,10 @@ vcc5v0_host_en: vcc5v0-host-en { > }; > }; > =20 > +&usb_con { > + power-role =3D "sink"; > +}; > + > &usbdp_phy0 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&usbc_sbu_dc>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts b/arch/arm64= /boot/dts/rockchip/rk3588-rock-5t.dts > index c1763835f53d4..96ffffec7e05d 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts > @@ -130,6 +130,11 @@ usbc_sbu_dc: usbc-sbu-dc { > }; > }; > =20 > +&usb_con { > + power-role =3D "dual"; > + try-power-role =3D "sink"; > +}; > + > &usbdp_phy0 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&usbc_sbu_dc>; >=20