From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6CEC4727C for ; Fri, 25 Sep 2020 12:33:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E407B21D7A for ; Fri, 25 Sep 2020 12:33:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E407B21D7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3AFA46ECCD; Fri, 25 Sep 2020 12:33:21 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1876A6ECCD; Fri, 25 Sep 2020 12:33:20 +0000 (UTC) IronPort-SDR: t5gSjt+5P6NC6JA8gMtmmaiiLGePEnE3WF9pQ17f3o2CWnW2MdvGAzljAH/fVFZfw166/wB2Bu 5OVZhbGzdRaw== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="158903034" X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="158903034" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 05:33:19 -0700 IronPort-SDR: hAAv+KjG+5EErAYnMJaScqJ3YYAs2Mc/2dUArWSDmx65J8EzpBWhcriotwbsqsU6JaoLkiPuAa UlmbgTVp8fFA== X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="455809154" Received: from mlevy2-mobl.ger.corp.intel.com (HELO [10.251.176.131]) ([10.251.176.131]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 05:33:15 -0700 To: Maor Gottlieb , Jason Gunthorpe , Leon Romanovsky References: <20200922083958.2150803-1-leon@kernel.org> <20200922083958.2150803-2-leon@kernel.org> <118a03ef-d160-e202-81cc-16c9c39359fc@linux.intel.com> <20200925071330.GA2280698@unreal> <20200925115544.GY9475@nvidia.com> <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> Date: Fri, 25 Sep 2020 13:33:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rdma@vger.kernel.org, intel-gfx@lists.freedesktop.org, Roland Scheidegger , dri-devel@lists.freedesktop.org, Maor Gottlieb , David Airlie , Doug Ledford , VMware Graphics , Christoph Hellwig Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Ck9uIDI1LzA5LzIwMjAgMTM6MTgsIE1hb3IgR290dGxpZWIgd3JvdGU6Cj4gT24gOS8yNS8yMDIw IDI6NTUgUE0sIEphc29uIEd1bnRob3JwZSB3cm90ZToKPj4gT24gRnJpLCBTZXAgMjUsIDIwMjAg YXQgMTA6MTM6MzBBTSArMDMwMCwgTGVvbiBSb21hbm92c2t5IHdyb3RlOgo+Pj4+PiBkaWZmIC0t Z2l0IGEvdG9vbHMvdGVzdGluZy9zY2F0dGVybGlzdC9tYWluLmMgCj4+Pj4+IGIvdG9vbHMvdGVz dGluZy9zY2F0dGVybGlzdC9tYWluLmMKPj4+Pj4gaW5kZXggMGExNDY0MTgxMjI2Li40ODk5MzU5 YTMxYWMgMTAwNjQ0Cj4+Pj4+ICsrKyBiL3Rvb2xzL3Rlc3Rpbmcvc2NhdHRlcmxpc3QvbWFpbi5j Cj4+Pj4+IEBAIC01NSwxNCArNTUsMTMgQEAgaW50IG1haW4odm9pZCkKPj4+Pj4gwqDCoMKgwqDC oMKgIGZvciAoaSA9IDAsIHRlc3QgPSB0ZXN0czsgdGVzdC0+ZXhwZWN0ZWRfc2VnbWVudHM7IHRl c3QrKywgCj4+Pj4+IGkrKykgewo+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcGFn ZSAqcGFnZXNbTUFYX1BBR0VTXTsKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHNn X3RhYmxlIHN0Owo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgaW50IHJldDsKPj4+Pj4gK8KgwqDCoMKg wqDCoMKgIHN0cnVjdCBzY2F0dGVybGlzdCAqc2c7Cj4+Pj4+Cj4+Pj4+IMKgwqDCoMKgwqDCoMKg wqDCoMKgIHNldF9wYWdlcyhwYWdlcywgdGVzdC0+cGZuLCB0ZXN0LT5udW1fcGFnZXMpOwo+Pj4+ Pgo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0ID0gX19zZ19hbGxvY190YWJsZV9mcm9tX3BhZ2Vz KCZzdCwgcGFnZXMsIAo+Pj4+PiB0ZXN0LT5udW1fcGFnZXMsCj4+Pj4+IC3CoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAwLCB0ZXN0LT5zaXplLCB0ZXN0 LT5tYXhfc2VnLAo+Pj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgR0ZQX0tFUk5FTCk7Cj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBhc3NlcnQocmV0 ID09IHRlc3QtPmFsbG9jX3JldCk7Cj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBzZyA9IF9fc2dfYWxs b2NfdGFibGVfZnJvbV9wYWdlcygmc3QsIHBhZ2VzLCAKPj4+Pj4gdGVzdC0+bnVtX3BhZ2VzLCAw LAo+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHRlc3QtPnNpemUsIHRlc3Qt Pm1heF9zZWcsIE5VTEwsIDAsIEdGUF9LRVJORUwpOwo+Pj4+PiArwqDCoMKgwqDCoMKgwqAgYXNz ZXJ0KFBUUl9FUlJfT1JfWkVSTyhzZykgPT0gdGVzdC0+YWxsb2NfcmV0KTsKPj4+PiBTb21lIHRl c3QgY292ZXJhZ2UgZm9yIHJlbGF0aXZlbHkgY29tcGxleCBjb2RlIHdvdWxkIGJlIHZlcnkgCj4+ Pj4gd2VsY29tZWQuIFNpbmNlCj4+Pj4gdGhlIHRlc3RpbmcgZnJhbWV3b3JrIGlzIGFscmVhZHkg dGhlcmUsIGV2ZW4gaWYgaXQgYml0LXJvdHRlZCBhIGJpdCwgCj4+Pj4gYnV0Cj4+Pj4gc2hvdWxk bid0IGJlIGhhcmQgdG8gZml4Lgo+Pj4+Cj4+Pj4gQSBmZXcgdGVzdHMgdG8gY2hlY2sgYXBwZW5k L2dyb3cgd29ya3MgYXMgZXhwZWN0ZWQsIGluIHRlcm1zIG9mIGhvdyAKPj4+PiB0aGUgZW5kCj4+ Pj4gdGFibGUgbG9va3MgbGlrZSBnaXZlbiB0aGUgaW5pdGlhbCBzdGF0ZSBhbmQgc29tZSBkaWZm ZXJlbnQgcGFnZSAKPj4+PiBwYXR0ZXJucwo+Pj4+IGFkZGVkIHRvIGl0LiBBbmQgYm90aCBjcm9z c2luZyBhbmQgbm90IGNyb3NzaW5nIGludG8gc2cgY2hhaW5pbmcgCj4+Pj4gc2NlbmFyaW9zLgo+ Pj4gVGhpcyBmdW5jdGlvbiBpcyBiYXNpYyBmb3IgYWxsIFJETUEgZGV2aWNlcyBhbmQgd2UgYXJl IHByZXR0eSBjb25maWRlbnQKPj4+IHRoYXQgdGhlIG9sZCBhbmQgbmV3IGZsb3dzIGFyZSB0ZXN0 ZWQgdGhvcm91Z2hseS4KPj4gV2VsbCwgc2luY2UgMC1kYXkgaXMgcmVwb3J0aW5nIHRoYXQgX19p OTE1X2dlbV91c2VycHRyX2FsbG9jX3BhZ2VzIGlzCj4+IGNyYXNoaW5nIG9uIHRoaXMsIGl0IHBy b2JhYmx5IGRvZXMgbmVlZCBzb21lIHRlc3RzIDpcCj4+Cj4+IEphc29uCj4gCj4gSXQgaXMgY3Jh c2hpbmcgaW4gdGhlIHJlZ3VsYXIgb2xkIGZsb3cgd2hpY2ggYWxyZWFkeSB0ZXN0ZWQuCj4gSG93 ZXZlciwgSSB3aWxsIGFkZCBtb3JlIHRlc3RzLgoKRG8geW91IHdhbnQgdG8gdGFrZSBzb21lIG9m IHRoZSBjb21taXRzIGZyb20gCmdpdDovL3Blb3BsZS5mcmVlZGVza3RvcC5vcmcvfnR1cnN1bGlu L2RybS1pbnRlbCBzZ3Rlc3Q/IEl0IHdvdWxkIGJlIApmaW5lIGJ5IG1lLiBJIGNhbiBjbGVhbiB1 cCB0aGUgY29tbWl0IG1lc3NhZ2VzIGlmIHlvdSB3YW50LgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNr dG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVsL2NvbW1pdC8/aD1zZ3Rlc3QmaWQ9NzkxMDJmNGQ3 OTVjNDc2OTQzMWZjNDRhNmNmN2VkNWM1YjFiNTIxNCAKLSB0aGlzIG9uZSB1bmRvZXMgdGhlIGJp dCByb3QgYW5kIG1ha2VzIHRoZSB0ZXN0IGp1c3Qgd29yayBvbiB0aGUgCmN1cnJlbnQga2VybmVs LgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVsL2NvbW1p dC8/aD1zZ3Rlc3QmaWQ9YjA5YmZlODA0ODZjNGQ5M2VlMWQ4YWUxN2Q1YjQ2Mzk3YjFjNmVlMSAK LSB0aGlzIG9uZSB5b3UgcHJvYmFibHkgc2hvdWxkIHNxdWFzaCBpbiB5b3VyIHBhdGNoLiBNaW51 cyB0aGUgemVyb2luZyAKb2Ygc3RydWN0IHNnX3N0YWJsZSBzaW5jZSB0aGF0IHdvdWxkIGhpZGUg dGhlIGlzc3VlLgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWlu dGVsL2NvbW1pdC8/aD1zZ3Rlc3QmaWQ9OTdmNWRmMzdlNjEyZjc5OGNlZDkwNTQxZWVjZTEzZTJl ZjYzOTE4MSAKLSBmaW5hbCBjb21taXQgaXMgb3B0aW9uYWwgYnV0IEkgZ3Vlc3MgaGFuZHkgZm9y IGRlYnVnZ2luZy4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4069EC4363D for ; Fri, 25 Sep 2020 12:33:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C0DF21D7A for ; Fri, 25 Sep 2020 12:33:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727290AbgIYMdU (ORCPT ); Fri, 25 Sep 2020 08:33:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:41361 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgIYMdU (ORCPT ); Fri, 25 Sep 2020 08:33:20 -0400 IronPort-SDR: zxeEcLuD26RXFPXzqq0VS8/6NeA+SNljkQqBY/c0fsxwNv3pjaSnG3FB4bypcXJQL9b9wP4qz+ WhBIuDegfLyA== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="149165680" X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="149165680" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 05:33:19 -0700 IronPort-SDR: hAAv+KjG+5EErAYnMJaScqJ3YYAs2Mc/2dUArWSDmx65J8EzpBWhcriotwbsqsU6JaoLkiPuAa UlmbgTVp8fFA== X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="455809154" Received: from mlevy2-mobl.ger.corp.intel.com (HELO [10.251.176.131]) ([10.251.176.131]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 05:33:15 -0700 Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages To: Maor Gottlieb , Jason Gunthorpe , Leon Romanovsky Cc: Christoph Hellwig , Doug Ledford , linux-rdma@vger.kernel.org, intel-gfx@lists.freedesktop.org, Roland Scheidegger , dri-devel@lists.freedesktop.org, David Airlie , VMware Graphics , Maor Gottlieb References: <20200922083958.2150803-1-leon@kernel.org> <20200922083958.2150803-2-leon@kernel.org> <118a03ef-d160-e202-81cc-16c9c39359fc@linux.intel.com> <20200925071330.GA2280698@unreal> <20200925115544.GY9475@nvidia.com> <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> Date: Fri, 25 Sep 2020 13:33:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 25/09/2020 13:18, Maor Gottlieb wrote: > On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: >> On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: >>>>> diff --git a/tools/testing/scatterlist/main.c >>>>> b/tools/testing/scatterlist/main.c >>>>> index 0a1464181226..4899359a31ac 100644 >>>>> +++ b/tools/testing/scatterlist/main.c >>>>> @@ -55,14 +55,13 @@ int main(void) >>>>>        for (i = 0, test = tests; test->expected_segments; test++, >>>>> i++) { >>>>>            struct page *pages[MAX_PAGES]; >>>>>            struct sg_table st; >>>>> -        int ret; >>>>> +        struct scatterlist *sg; >>>>> >>>>>            set_pages(pages, test->pfn, test->num_pages); >>>>> >>>>> -        ret = __sg_alloc_table_from_pages(&st, pages, >>>>> test->num_pages, >>>>> -                          0, test->size, test->max_seg, >>>>> -                          GFP_KERNEL); >>>>> -        assert(ret == test->alloc_ret); >>>>> +        sg = __sg_alloc_table_from_pages(&st, pages, >>>>> test->num_pages, 0, >>>>> +                test->size, test->max_seg, NULL, 0, GFP_KERNEL); >>>>> +        assert(PTR_ERR_OR_ZERO(sg) == test->alloc_ret); >>>> Some test coverage for relatively complex code would be very >>>> welcomed. Since >>>> the testing framework is already there, even if it bit-rotted a bit, >>>> but >>>> shouldn't be hard to fix. >>>> >>>> A few tests to check append/grow works as expected, in terms of how >>>> the end >>>> table looks like given the initial state and some different page >>>> patterns >>>> added to it. And both crossing and not crossing into sg chaining >>>> scenarios. >>> This function is basic for all RDMA devices and we are pretty confident >>> that the old and new flows are tested thoroughly. >> Well, since 0-day is reporting that __i915_gem_userptr_alloc_pages is >> crashing on this, it probably does need some tests :\ >> >> Jason > > It is crashing in the regular old flow which already tested. > However, I will add more tests. Do you want to take some of the commits from git://people.freedesktop.org/~tursulin/drm-intel sgtest? It would be fine by me. I can clean up the commit messages if you want. https://cgit.freedesktop.org/~tursulin/drm-intel/commit/?h=sgtest&id=79102f4d795c4769431fc44a6cf7ed5c5b1b5214 - this one undoes the bit rot and makes the test just work on the current kernel. https://cgit.freedesktop.org/~tursulin/drm-intel/commit/?h=sgtest&id=b09bfe80486c4d93ee1d8ae17d5b46397b1c6ee1 - this one you probably should squash in your patch. Minus the zeroing of struct sg_stable since that would hide the issue. https://cgit.freedesktop.org/~tursulin/drm-intel/commit/?h=sgtest&id=97f5df37e612f798ced90541eece13e2ef639181 - final commit is optional but I guess handy for debugging. Regards, Tvrtko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F83C4727D for ; Fri, 25 Sep 2020 12:33:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44A3F21D7A for ; Fri, 25 Sep 2020 12:33:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44A3F21D7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CA636ECCF; Fri, 25 Sep 2020 12:33:21 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1876A6ECCD; Fri, 25 Sep 2020 12:33:20 +0000 (UTC) IronPort-SDR: t5gSjt+5P6NC6JA8gMtmmaiiLGePEnE3WF9pQ17f3o2CWnW2MdvGAzljAH/fVFZfw166/wB2Bu 5OVZhbGzdRaw== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="158903034" X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="158903034" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 05:33:19 -0700 IronPort-SDR: hAAv+KjG+5EErAYnMJaScqJ3YYAs2Mc/2dUArWSDmx65J8EzpBWhcriotwbsqsU6JaoLkiPuAa UlmbgTVp8fFA== X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="455809154" Received: from mlevy2-mobl.ger.corp.intel.com (HELO [10.251.176.131]) ([10.251.176.131]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 05:33:15 -0700 Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages To: Maor Gottlieb , Jason Gunthorpe , Leon Romanovsky References: <20200922083958.2150803-1-leon@kernel.org> <20200922083958.2150803-2-leon@kernel.org> <118a03ef-d160-e202-81cc-16c9c39359fc@linux.intel.com> <20200925071330.GA2280698@unreal> <20200925115544.GY9475@nvidia.com> <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> Date: Fri, 25 Sep 2020 13:33:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rdma@vger.kernel.org, intel-gfx@lists.freedesktop.org, Roland Scheidegger , dri-devel@lists.freedesktop.org, Maor Gottlieb , David Airlie , Doug Ledford , VMware Graphics , Christoph Hellwig Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Ck9uIDI1LzA5LzIwMjAgMTM6MTgsIE1hb3IgR290dGxpZWIgd3JvdGU6Cj4gT24gOS8yNS8yMDIw IDI6NTUgUE0sIEphc29uIEd1bnRob3JwZSB3cm90ZToKPj4gT24gRnJpLCBTZXAgMjUsIDIwMjAg YXQgMTA6MTM6MzBBTSArMDMwMCwgTGVvbiBSb21hbm92c2t5IHdyb3RlOgo+Pj4+PiBkaWZmIC0t Z2l0IGEvdG9vbHMvdGVzdGluZy9zY2F0dGVybGlzdC9tYWluLmMgCj4+Pj4+IGIvdG9vbHMvdGVz dGluZy9zY2F0dGVybGlzdC9tYWluLmMKPj4+Pj4gaW5kZXggMGExNDY0MTgxMjI2Li40ODk5MzU5 YTMxYWMgMTAwNjQ0Cj4+Pj4+ICsrKyBiL3Rvb2xzL3Rlc3Rpbmcvc2NhdHRlcmxpc3QvbWFpbi5j Cj4+Pj4+IEBAIC01NSwxNCArNTUsMTMgQEAgaW50IG1haW4odm9pZCkKPj4+Pj4gwqDCoMKgwqDC oMKgIGZvciAoaSA9IDAsIHRlc3QgPSB0ZXN0czsgdGVzdC0+ZXhwZWN0ZWRfc2VnbWVudHM7IHRl c3QrKywgCj4+Pj4+IGkrKykgewo+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcGFn ZSAqcGFnZXNbTUFYX1BBR0VTXTsKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHNn X3RhYmxlIHN0Owo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgaW50IHJldDsKPj4+Pj4gK8KgwqDCoMKg wqDCoMKgIHN0cnVjdCBzY2F0dGVybGlzdCAqc2c7Cj4+Pj4+Cj4+Pj4+IMKgwqDCoMKgwqDCoMKg wqDCoMKgIHNldF9wYWdlcyhwYWdlcywgdGVzdC0+cGZuLCB0ZXN0LT5udW1fcGFnZXMpOwo+Pj4+ Pgo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0ID0gX19zZ19hbGxvY190YWJsZV9mcm9tX3BhZ2Vz KCZzdCwgcGFnZXMsIAo+Pj4+PiB0ZXN0LT5udW1fcGFnZXMsCj4+Pj4+IC3CoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAwLCB0ZXN0LT5zaXplLCB0ZXN0 LT5tYXhfc2VnLAo+Pj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgR0ZQX0tFUk5FTCk7Cj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBhc3NlcnQocmV0 ID09IHRlc3QtPmFsbG9jX3JldCk7Cj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBzZyA9IF9fc2dfYWxs b2NfdGFibGVfZnJvbV9wYWdlcygmc3QsIHBhZ2VzLCAKPj4+Pj4gdGVzdC0+bnVtX3BhZ2VzLCAw LAo+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHRlc3QtPnNpemUsIHRlc3Qt Pm1heF9zZWcsIE5VTEwsIDAsIEdGUF9LRVJORUwpOwo+Pj4+PiArwqDCoMKgwqDCoMKgwqAgYXNz ZXJ0KFBUUl9FUlJfT1JfWkVSTyhzZykgPT0gdGVzdC0+YWxsb2NfcmV0KTsKPj4+PiBTb21lIHRl c3QgY292ZXJhZ2UgZm9yIHJlbGF0aXZlbHkgY29tcGxleCBjb2RlIHdvdWxkIGJlIHZlcnkgCj4+ Pj4gd2VsY29tZWQuIFNpbmNlCj4+Pj4gdGhlIHRlc3RpbmcgZnJhbWV3b3JrIGlzIGFscmVhZHkg dGhlcmUsIGV2ZW4gaWYgaXQgYml0LXJvdHRlZCBhIGJpdCwgCj4+Pj4gYnV0Cj4+Pj4gc2hvdWxk bid0IGJlIGhhcmQgdG8gZml4Lgo+Pj4+Cj4+Pj4gQSBmZXcgdGVzdHMgdG8gY2hlY2sgYXBwZW5k L2dyb3cgd29ya3MgYXMgZXhwZWN0ZWQsIGluIHRlcm1zIG9mIGhvdyAKPj4+PiB0aGUgZW5kCj4+ Pj4gdGFibGUgbG9va3MgbGlrZSBnaXZlbiB0aGUgaW5pdGlhbCBzdGF0ZSBhbmQgc29tZSBkaWZm ZXJlbnQgcGFnZSAKPj4+PiBwYXR0ZXJucwo+Pj4+IGFkZGVkIHRvIGl0LiBBbmQgYm90aCBjcm9z c2luZyBhbmQgbm90IGNyb3NzaW5nIGludG8gc2cgY2hhaW5pbmcgCj4+Pj4gc2NlbmFyaW9zLgo+ Pj4gVGhpcyBmdW5jdGlvbiBpcyBiYXNpYyBmb3IgYWxsIFJETUEgZGV2aWNlcyBhbmQgd2UgYXJl IHByZXR0eSBjb25maWRlbnQKPj4+IHRoYXQgdGhlIG9sZCBhbmQgbmV3IGZsb3dzIGFyZSB0ZXN0 ZWQgdGhvcm91Z2hseS4KPj4gV2VsbCwgc2luY2UgMC1kYXkgaXMgcmVwb3J0aW5nIHRoYXQgX19p OTE1X2dlbV91c2VycHRyX2FsbG9jX3BhZ2VzIGlzCj4+IGNyYXNoaW5nIG9uIHRoaXMsIGl0IHBy b2JhYmx5IGRvZXMgbmVlZCBzb21lIHRlc3RzIDpcCj4+Cj4+IEphc29uCj4gCj4gSXQgaXMgY3Jh c2hpbmcgaW4gdGhlIHJlZ3VsYXIgb2xkIGZsb3cgd2hpY2ggYWxyZWFkeSB0ZXN0ZWQuCj4gSG93 ZXZlciwgSSB3aWxsIGFkZCBtb3JlIHRlc3RzLgoKRG8geW91IHdhbnQgdG8gdGFrZSBzb21lIG9m IHRoZSBjb21taXRzIGZyb20gCmdpdDovL3Blb3BsZS5mcmVlZGVza3RvcC5vcmcvfnR1cnN1bGlu L2RybS1pbnRlbCBzZ3Rlc3Q/IEl0IHdvdWxkIGJlIApmaW5lIGJ5IG1lLiBJIGNhbiBjbGVhbiB1 cCB0aGUgY29tbWl0IG1lc3NhZ2VzIGlmIHlvdSB3YW50LgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNr dG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVsL2NvbW1pdC8/aD1zZ3Rlc3QmaWQ9NzkxMDJmNGQ3 OTVjNDc2OTQzMWZjNDRhNmNmN2VkNWM1YjFiNTIxNCAKLSB0aGlzIG9uZSB1bmRvZXMgdGhlIGJp dCByb3QgYW5kIG1ha2VzIHRoZSB0ZXN0IGp1c3Qgd29yayBvbiB0aGUgCmN1cnJlbnQga2VybmVs LgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVsL2NvbW1p dC8/aD1zZ3Rlc3QmaWQ9YjA5YmZlODA0ODZjNGQ5M2VlMWQ4YWUxN2Q1YjQ2Mzk3YjFjNmVlMSAK LSB0aGlzIG9uZSB5b3UgcHJvYmFibHkgc2hvdWxkIHNxdWFzaCBpbiB5b3VyIHBhdGNoLiBNaW51 cyB0aGUgemVyb2luZyAKb2Ygc3RydWN0IHNnX3N0YWJsZSBzaW5jZSB0aGF0IHdvdWxkIGhpZGUg dGhlIGlzc3VlLgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWlu dGVsL2NvbW1pdC8/aD1zZ3Rlc3QmaWQ9OTdmNWRmMzdlNjEyZjc5OGNlZDkwNTQxZWVjZTEzZTJl ZjYzOTE4MSAKLSBmaW5hbCBjb21taXQgaXMgb3B0aW9uYWwgYnV0IEkgZ3Vlc3MgaGFuZHkgZm9y IGRlYnVnZ2luZy4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==