From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Date: Sun, 13 Jan 2019 18:48:49 +0000 Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put Message-Id: <3397932.PmTvevuZIG@phil> List-Id: References: <1547369264-24831-1-git-send-email-Julia.Lawall@lip6.fr> <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local idexpression child; > iterator name for_each_child_of_node; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > + of_node_put(child); > ? break; > ... > } > ... when != child > // > > Signed-off-by: Julia Lawall I've added a fixes+stable tag and applied it to drm-misc-fixes Thanks for catching that Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put Date: Sun, 13 Jan 2019 19:48:49 +0100 Message-ID: <3397932.PmTvevuZIG@phil> References: <1547369264-24831-1-git-send-email-Julia.Lawall@lip6.fr> <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org QW0gU29ubnRhZywgMTMuIEphbnVhciAyMDE5LCAwOTo0Nzo0MyBDRVQgc2NocmllYiBKdWxpYSBM YXdhbGw6Cj4gVGhlIGRldmljZSBub2RlIGl0ZXJhdG9ycyBwZXJmb3JtIGFuIG9mX25vZGVfZ2V0 IG9uIGVhY2ggaXRlcmF0aW9uLCBzbyBhCj4ganVtcCBvdXQgb2YgdGhlIGxvb3AgcmVxdWlyZXMg YW4gb2Zfbm9kZV9wdXQuCj4gCj4gVGhlIHNlbWFudGljIHBhdGNoIHRoYXQgZml4ZXMgdGhpcyBw cm9ibGVtIGlzIGFzIGZvbGxvd3MKPiAoaHR0cDovL2NvY2NpbmVsbGUubGlwNi5mcik6Cj4gCj4g Ly8gPHNtcGw+Cj4gQEAKPiBleHByZXNzaW9uIHJvb3QsZTsKPiBsb2NhbCBpZGV4cHJlc3Npb24g Y2hpbGQ7Cj4gaXRlcmF0b3IgbmFtZSBmb3JfZWFjaF9jaGlsZF9vZl9ub2RlOwo+IEBACj4gCj4g IGZvcl9lYWNoX2NoaWxkX29mX25vZGUocm9vdCwgY2hpbGQpIHsKPiAgICAuLi4gd2hlbiAhPSBv Zl9ub2RlX3B1dChjaGlsZCkKPiAgICAgICAgd2hlbiAhPSBlID0gY2hpbGQKPiArICBvZl9ub2Rl X3B1dChjaGlsZCk7Cj4gPyAgYnJlYWs7Cj4gICAgLi4uCj4gfQo+IC4uLiB3aGVuICE9IGNoaWxk Cj4gLy8gPC9zbXBsPgo+IAo+IFNpZ25lZC1vZmYtYnk6IEp1bGlhIExhd2FsbCA8SnVsaWEuTGF3 YWxsQGxpcDYuZnI+CgpJJ3ZlIGFkZGVkIGEgZml4ZXMrc3RhYmxlIHRhZyBhbmQgYXBwbGllZCBp dCB0byBkcm0tbWlzYy1maXhlcwoKVGhhbmtzIGZvciBjYXRjaGluZyB0aGF0CkhlaWtvCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 675A7C43387 for ; Sun, 13 Jan 2019 18:49:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AB4420656 for ; Sun, 13 Jan 2019 18:49:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qeqb+Upx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AB4420656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MDEoJ4i9fli5VIYAgbrQjg7w0ksGSb/lZ1HhD1isSCI=; b=Qeqb+UpxhTaR8A e6JYem49uWZ3Z7MmM00lxx+tgh9rOEn8P8V2ZcVUteKPWAizI55FrhZHkoECItxABGYPXKFxmBILg 2ESaRYSqbe5KBTNo6mo+9fjpYbV6rntUqiOKw4GRC5/GltHdplKYxjB8gxF1SqUH1s9eO5aM3mYEo F9maaKCGCdvpS/Ivlm77yFJGv/DvmKNHvy1M6W5+0BF5Q9Zu1egcVbWYDeRY77SUStxiZvgDzp+le GpAg3czjTHwUhI66UL88y//vgiTZwT+rpLx3SmheaL9KVIsdbgGcWrZrDMUrbAbjg690hhPqLEl8E 5ymv/HI7CshN3NgAm06Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gikoi-0001jK-8C; Sun, 13 Jan 2019 18:49:04 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gikoe-0001hk-1A; Sun, 13 Jan 2019 18:49:02 +0000 Received: from p57b7799d.dip0.t-ipconnect.de ([87.183.121.157] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gikoU-0002Hp-KY; Sun, 13 Jan 2019 19:48:50 +0100 From: Heiko Stuebner To: Julia Lawall Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put Date: Sun, 13 Jan 2019 19:48:49 +0100 Message-ID: <3397932.PmTvevuZIG@phil> In-Reply-To: <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr> References: <1547369264-24831-1-git-send-email-Julia.Lawall@lip6.fr> <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190113_104900_217862_8A2BDC66 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, Sandy Huang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local idexpression child; > iterator name for_each_child_of_node; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > + of_node_put(child); > ? break; > ... > } > ... when != child > // > > Signed-off-by: Julia Lawall I've added a fixes+stable tag and applied it to drm-misc-fixes Thanks for catching that Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFA4C43387 for ; Sun, 13 Jan 2019 20:11:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAE2D20675 for ; Sun, 13 Jan 2019 20:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfAMULf (ORCPT ); Sun, 13 Jan 2019 15:11:35 -0500 Received: from gloria.sntech.de ([185.11.138.130]:46984 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726428AbfAMULf (ORCPT ); Sun, 13 Jan 2019 15:11:35 -0500 Received: from p57b7799d.dip0.t-ipconnect.de ([87.183.121.157] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gikoU-0002Hp-KY; Sun, 13 Jan 2019 19:48:50 +0100 From: Heiko Stuebner To: Julia Lawall Cc: Sandy Huang , kernel-janitors@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put Date: Sun, 13 Jan 2019 19:48:49 +0100 Message-ID: <3397932.PmTvevuZIG@phil> In-Reply-To: <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr> References: <1547369264-24831-1-git-send-email-Julia.Lawall@lip6.fr> <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local idexpression child; > iterator name for_each_child_of_node; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > + of_node_put(child); > ? break; > ... > } > ... when != child > // > > Signed-off-by: Julia Lawall I've added a fixes+stable tag and applied it to drm-misc-fixes Thanks for catching that Heiko