Re: [PATCH] panic: Clean up message about deprecated 'panic_print' parameter

[Lance Yang <lance.yang@linux.dev>]

On 2025/8/20 09:54, Lance Yang wrote:
> 
> 
> On 2025/8/20 09:31, kernel test robot wrote:
>> Hi Petr,
>>
>> kernel test robot noticed the following build errors:
>>
>>
>>
>> url:    https://github.com/intel-lab-lkp/linux/commits/ 
>> UPDATE-20250819-180717/Feng-Tang/lib-sys_info-handle-sys_info_mask-0- 
>> case/20250815-152131
>> base:   the 3th patch of https://lore.kernel.org/ 
>> r/20250815071428.98041-4-feng.tang%40linux.alibaba.com
>> patch link:    https://lore.kernel.org/r/ 
>> aKRJKZHgcxyNF3y7%40pathway.suse.cz
>> patch subject: [PATCH] panic: Clean up message about deprecated 
>> 'panic_print' parameter
>> config: i386-buildonly-randconfig-004-20250820 (https:// 
>> download.01.org/0day-ci/archive/20250820/202508200907.PsZ3geub- 
>> lkp@intel.com/config)
>> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 
>> 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/ 
>> archive/20250820/202508200907.PsZ3geub-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new 
>> version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202508200907.PsZ3geub- 
>> lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>>>> kernel/panic.c:952:2: error: call to undeclared function 
>>>> 'panic_print_deprecated'; ISO C99 and later do not support implicit 
>>>> function declarations [-Wimplicit-function-declaration]
>>       952 |         panic_print_deprecated();
>>           |         ^
>>     kernel/panic.c:958:2: error: call to undeclared function 
>> 'panic_print_deprecated'; ISO C99 and later do not support implicit 
>> function declarations [-Wimplicit-function-declaration]
>>       958 |         panic_print_deprecated();
>>           |         ^
>>     2 errors generated.
> 
> 
> Oops, panic_print_deprecated() is defined within the #ifdef
> CONFIG_PROC_SYSCTL block, but it's also called from panic_print_set()

Correction:

CONFIG_SYSCTL block - sorry ;(

> and panic_print_get(), which are outside of that block.
> 
> So, we need to move the definition out of the block to a common
> scope where all its callers can see it. @Petr wdyt?
> 
> Thanks,
> Lance
> 
>>
>>
>> vim +/panic_print_deprecated +952 kernel/panic.c
>>
>>     949
>>     950    static int panic_print_set(const char *val, const struct 
>> kernel_param *kp)
>>     951    {
>>   > 952        panic_print_deprecated();
>>     953        return  param_set_ulong(val, kp);
>>     954    }
>>     955
>>
>