From: Arun KS <arunks@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: keescook@chromium.org, khlebnikov@yandex-team.ru,
minchan@kernel.org, getarunks@gmail.com,
gregkh@linuxfoundation.org, mhocko@kernel.org, vbabka@suse.cz,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic
Date: Wed, 07 Nov 2018 11:49:44 +0530 [thread overview]
Message-ID: <33a9d26369468824e27de5a636e4e843@codeaurora.org> (raw)
In-Reply-To: <20181106162206.0f43c1eb16c3dd812bdadbdd@linux-foundation.org>
On 2018-11-07 05:52, Andrew Morton wrote:
> On Fri, 26 Oct 2018 16:30:58 +0530 Arun KS <arunks@codeaurora.org>
> wrote:
>
>> This series convert totalram_pages, totalhigh_pages and
>> zone->managed_pages to atomic variables.
>
> The whole point appears to be removal of managed_page_count_lock, yes?
>
> Why? What is the value of this patchset? If "performance" then are
> any
> measurements available?
Hello Andrew,
https://patchwork.kernel.org/patch/10670787/
In version 2, I have added motivation behind this conversion. Pasting
same here,
totalram_pages, zone->managed_pages and totalhigh_pages updates are
protected by managed_page_count_lock, but readers never care about it.
Convert these variables to atomic to avoid readers potentially seeing a
store tear. I don't think we have a performance improvement here.
Regards,
Arun
next prev parent reply other threads:[~2018-11-07 6:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 11:00 [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Arun KS
2018-10-26 11:00 ` Arun KS
2018-10-26 11:00 ` [PATCH v1 1/4] mm: Fix multiple evaluvations of totalram_pages and managed_pages Arun KS
2018-10-26 11:00 ` Arun KS
2018-10-26 11:01 ` [PATCH v1 2/4] mm: Convert zone->managed_pages to atomic variable Arun KS
2018-10-26 11:01 ` Arun KS
2018-10-26 11:01 ` [PATCH v1 3/4] mm: convert totalram_pages and totalhigh_pages variables to atomic Arun KS
2018-10-26 11:01 ` Arun KS
[not found] ` <20181106141438.GQ27423@dhcp22.suse.cz>
2018-11-07 10:38 ` Michal Hocko
2018-11-07 10:38 ` Michal Hocko
2018-10-26 11:01 ` [PATCH v1 4/4] mm: Remove managed_page_count spinlock Arun KS
2018-10-26 11:01 ` Arun KS
[not found] ` <20181106141732.GR27423@dhcp22.suse.cz>
2018-11-07 10:36 ` Michal Hocko
2018-11-07 10:36 ` Michal Hocko
2018-11-07 11:50 ` Vlastimil Babka
2018-11-06 5:38 ` [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Arun KS
2018-11-06 8:17 ` Konstantin Khlebnikov
2018-11-06 8:17 ` Konstantin Khlebnikov
2018-11-06 8:30 ` Arun KS
2018-11-06 8:30 ` Arun KS
2018-11-06 8:37 ` Konstantin Khlebnikov
2018-11-06 8:37 ` Konstantin Khlebnikov
2018-11-06 8:43 ` Arun KS
2018-11-06 8:43 ` Arun KS
2018-11-07 7:02 ` Konstantin Khlebnikov
2018-11-07 7:02 ` Konstantin Khlebnikov
2018-11-07 8:50 ` Vlastimil Babka
2018-11-07 10:28 ` Michal Hocko
2018-11-07 10:39 ` Michal Hocko
2018-11-07 0:22 ` Andrew Morton
2018-11-07 6:19 ` Arun KS [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-26 11:00 Arun KS
2018-10-26 11:00 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a9d26369468824e27de5a636e4e843@codeaurora.org \
--to=arunks@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=getarunks@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.