All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cengiz Can <cengiz@kernel.wtf>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Dennis Dalessandro <dennis.dalessandro@intel.com>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: remove unnecessary fallthrough usage
Date: Mon, 31 Aug 2020 19:00:32 +0300	[thread overview]
Message-ID: <33b7fe93c7fd17658baeabd233d38099@kernel.wtf> (raw)
In-Reply-To: <20200831153440.GA24045@ziepe.ca>

On 2020-08-31 18:34, Jason Gunthorpe wrote:
> On Mon, Aug 31, 2020 at 06:30:34PM +0300, Cengiz Can wrote:
>> Since /* fallthrough */ comments are deprecated[1], they are being 
>> replaced
>> by new 'fallthrough' pseudo-keyword.
>> 
>> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\
>>         highlight=fallthrough#implicit-switch-case-fall-through
>> 
>> This sometimes leads to unreachable code warnings by static analyzers,
>> particularly in this case, Coverity Scanner. (CID 1466512)
>> 
>> Remove unnecessary 'fallthrough' keywords to prevent dead code
>> warnings.
>> 
>> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
>> ---
>>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>>  1 file changed, 2 deletions(-)
> 
> Alex beat you to it:
> 
> https://patchwork.kernel.org/patch/11736039/

Well, I'm glad it's fixed :)

Thanks for sharing

> 
> Thanks,
> Jason

-- 
Cengiz Can
@cengiz_io

      reply	other threads:[~2020-08-31 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 15:30 [PATCH] infiniband: remove unnecessary fallthrough usage Cengiz Can
2020-08-31 15:34 ` Jason Gunthorpe
2020-08-31 16:00   ` Cengiz Can [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33b7fe93c7fd17658baeabd233d38099@kernel.wtf \
    --to=cengiz@kernel.wtf \
    --cc=dennis.dalessandro@intel.com \
    --cc=dledford@redhat.com \
    --cc=gustavoars@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.