From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68652C433DB for ; Wed, 27 Jan 2021 07:28:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E634D2073C for ; Wed, 27 Jan 2021 07:28:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E634D2073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 57C356E54C; Wed, 27 Jan 2021 07:28:58 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D37B56E54C for ; Wed, 27 Jan 2021 07:28:56 +0000 (UTC) IronPort-SDR: aOvPOl0QL+q3KqXeVTtui7grjFwH24Hr1kuBFldfzyY+Ncl5cTfsopa9k3Yu/SUpPaHx7BxGG+ 888hpG/XhntQ== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="177462467" X-IronPort-AV: E=Sophos;i="5.79,378,1602572400"; d="scan'208";a="177462467" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 23:28:55 -0800 IronPort-SDR: ISeFx6bnR/LkF48tiORiqvC05t1HT1Zr7Vqk0H8fx5SpkIPZVc0a+uICdypVqmAbIWFEU9TAcC 3Y8wDLcbk5rg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,378,1602572400"; d="scan'208";a="369389200" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 26 Jan 2021 23:28:54 -0800 Received: from bgsmsx602.gar.corp.intel.com (10.109.78.81) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 26 Jan 2021 23:28:53 -0800 Received: from bgsmsx604.gar.corp.intel.com (10.67.234.6) by BGSMSX602.gar.corp.intel.com (10.109.78.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 Jan 2021 12:58:51 +0530 Received: from bgsmsx604.gar.corp.intel.com ([10.67.234.6]) by BGSMSX604.gar.corp.intel.com ([10.67.234.6]) with mapi id 15.01.1713.004; Wed, 27 Jan 2021 12:58:51 +0530 From: "Gupta, Anshuman" To: "Li, Juston" , "intel-gfx@lists.freedesktop.org" Thread-Topic: [PATCH v2 4/4] drm/i915/hdcp: disable the QSES check for HDCP2.2 over MST Thread-Index: AQHW9HjH1mdEEx7XkEGDr0piwDUliKo7EwVQ Date: Wed, 27 Jan 2021 07:28:51 +0000 Message-ID: <33ca4c838fc843b883ee87e889e8ba87@intel.com> References: <20210127065034.2501119-1-juston.li@intel.com> <20210127065034.2501119-4-juston.li@intel.com> In-Reply-To: <20210127065034.2501119-4-juston.li@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.223.10.1] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/hdcp: disable the QSES check for HDCP2.2 over MST X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "seanpaul@chromium.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Looks Good to me. Reviewed-by: Anshuman Gupta > -----Original Message----- > From: Li, Juston > Sent: Wednesday, January 27, 2021 12:21 PM > To: intel-gfx@lists.freedesktop.org > Cc: seanpaul@chromium.org; Gupta, Anshuman > ; C, Ramalingam ; > Li, Juston > Subject: [PATCH v2 4/4] drm/i915/hdcp: disable the QSES check for > HDCP2.2 over MST > > Like the patch to disable QSES for HDCP 1.4 over MST > https://patchwork.freedesktop.org/patch/415297/ the HDCP2.2 spec > doesn't require QSES as well and we've seen QSES not supported on a > couple HDCP2.2 docks so far (Dell WD19 and Lenovo LDC-G2) > > Remove it for now until we get a better idea of how widely supported QSES > is and how to support it optionally. > > Signed-off-by: Juston Li > --- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 31 +------------------- > 1 file changed, 1 insertion(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > index cd183944bc5a..5e9d0d8f7f84 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > @@ -699,30 +699,6 @@ intel_dp_mst_hdcp_stream_encryption(struct > intel_connector *connector, > return 0; > } > > -static bool intel_dp_mst_get_qses_status(struct intel_digital_port > *dig_port, > - struct intel_connector *connector) > -{ > - struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev); > - struct drm_dp_query_stream_enc_status_ack_reply reply; > - struct intel_dp *intel_dp = &dig_port->dp; > - int ret; > - > - ret = drm_dp_send_query_stream_enc_status(&intel_dp- > >mst_mgr, > - connector->port, &reply); > - if (ret) { > - drm_dbg_kms(&i915->drm, > - "[%s:%d] failed QSES ret=%d\n", > - connector->base.name, connector->base.base.id, > ret); > - return false; > - } > - > - drm_dbg_kms(&i915->drm, "[%s:%d] QSES stream auth: %d stream > enc: %d\n", > - connector->base.name, connector->base.base.id, > - reply.auth_completed, reply.encryption_enabled); > - > - return reply.auth_completed && reply.encryption_enabled; > -} > - > static int > intel_dp_mst_hdcp2_stream_encryption(struct intel_connector > *connector, > bool enable) > @@ -758,11 +734,6 @@ intel_dp_mst_hdcp2_stream_encryption(struct > intel_connector *connector, > return 0; > } > > -/* > - * DP v2.0 I.3.3 ignore the stream signature L' in QSES reply msg reply. > - * I.3.5 MST source device may use a QSES msg to query downstream > status > - * for a particular stream. > - */ > static > int intel_dp_mst_hdcp2_check_link(struct intel_digital_port *dig_port, > struct intel_connector *connector) @@ - > 782,7 +753,7 @@ int intel_dp_mst_hdcp2_check_link(struct > intel_digital_port *dig_port, > return ret; > } > > - return intel_dp_mst_get_qses_status(dig_port, connector) ? 0 : - > EINVAL; > + return 0; > } > > static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = { > -- > 2.29.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx