All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>
To: christian.koenig-5C7GfCeVMHo@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)
Date: Mon, 6 Nov 2017 13:28:32 -0500	[thread overview]
Message-ID: <33d2fd4b-6645-e4f4-629a-40f48a339477@amd.com> (raw)
In-Reply-To: <0b642f55-e810-c1a4-f6b5-4644eba2f967-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 06/11/17 05:01 AM, Christian König wrote:
> Am 04.11.2017 um 18:15 schrieb Tom St Denis:
>> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
> 
> Still not perfect, but good enough for now. Patch is Tested-by: 
> Christian König <christian.koenig@amd.com>.
> 
> I think you need to rework the VM walking a bit, cause we need to 
> support the T bit as well in the future and your code make a few 
> assumptions which doesn't allow that.

Doesn't the T bit imply V=0 which means the page isn't backed by memory. 
  Not much umr could do about that other than to print out the T bit.

Tom
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-11-06 18:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-04 17:15 [PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2) Tom St Denis
     [not found] ` <20171104171535.6620-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2017-11-06 10:01   ` Christian König
     [not found]     ` <0b642f55-e810-c1a4-f6b5-4644eba2f967-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-06 18:28       ` Tom St Denis [this message]
     [not found]         ` <33d2fd4b-6645-e4f4-629a-40f48a339477-5C7GfCeVMHo@public.gmane.org>
2017-11-06 18:34           ` Christian König
     [not found]             ` <a9059d35-db2e-b8e3-7e1b-ea829950dc42-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-06 18:39               ` Tom St Denis
     [not found]                 ` <bff0ee92-e57d-ee07-e8a0-1bd54d81a04a-5C7GfCeVMHo@public.gmane.org>
2017-11-06 18:47                   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33d2fd4b-6645-e4f4-629a-40f48a339477@amd.com \
    --to=tom.stdenis-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.