From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Jerry Meng <jerry.meng.lk@quectel.com>,
loic.poulain@linaro.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: wwan: Add WWAN sahara port type
Date: Fri, 22 Nov 2024 01:43:06 +0200 [thread overview]
Message-ID: <33d70ece-15db-4c83-90a4-3daa2f4032fd@gmail.com> (raw)
In-Reply-To: <022f6596-3b4c-6c19-f918-8dc1cce509ba@quicinc.com>
On 22.11.2024 01:02, Jeffrey Hugo wrote:
> On 11/21/2024 3:53 PM, Sergey Ryazanov wrote:
>> On 20.11.2024 23:48, Jeffrey Hugo wrote:
>>> On 11/20/2024 1:36 PM, Sergey Ryazanov wrote:
>>>> +Manivannan
>>>>
>>>> Hello Jerry,
>>>>
>>>> this version looks a way better, still there is one minor thing to
>>>> improve. See below.
>>>>
>>>> Manivannan, Loic, could you advice is it Ok to export that SAHARA
>>>> port as is?
>>>
>>> I'm against this.
>>>
>>> There is an in-kernel Sahara implementation, which is going to be
>>> used by QDU100. If WWAN is going to own the "SAHARA" MHI channel
>>> name, then no one else can use it which will conflict with QDU100.
>>>
>>> I expect the in-kernel implementation can be leveraged for this.
>>
>> Make sense. Can you share a link to this in-kernel implementation?
>> I've searched through the code and found nothing similar. Is it merged
>> or has it a different name?
>
> drivers/accel/qaic/sahara.c
I was searching for SAHARA and for sahara in the log, however it was
introduced as Sahara. Next time will use case insensitive search :)
Thank you for the clue.
--
Sergey
next prev parent reply other threads:[~2024-11-21 23:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 9:39 [PATCH net-next v2] net: wwan: Add WWAN sahara port type Jerry Meng
2024-11-20 20:36 ` Sergey Ryazanov
2024-11-20 21:48 ` Jeffrey Hugo
2024-11-21 9:08 ` Loic Poulain
2024-11-21 22:48 ` Sergey Ryazanov
2024-11-21 22:53 ` Sergey Ryazanov
2024-11-21 23:02 ` Jeffrey Hugo
2024-11-21 23:43 ` Sergey Ryazanov [this message]
2024-11-21 9:05 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33d70ece-15db-4c83-90a4-3daa2f4032fd@gmail.com \
--to=ryazanov.s.a@gmail.com \
--cc=jerry.meng.lk@quectel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.