From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: sagi@grimberg.me, kbusch@kernel.org,
linux-nvme@lists.infradead.org, hare@suse.de, axboe@kernel.dk,
oren@nvidia.com, ngottlieb@nvidia.com, israelr@nvidia.com
Subject: Re: [PATCH 3/3] nvme-fabrics: prevent overriding of existing host
Date: Thu, 11 May 2023 16:59:36 +0300 [thread overview]
Message-ID: <33db06d5-36fc-77bb-1f0c-adb61fc77767@nvidia.com> (raw)
In-Reply-To: <20230511134959.GA786@lst.de>
On 11/05/2023 16:49, Christoph Hellwig wrote:
> On Thu, May 11, 2023 at 04:26:55PM +0300, Max Gurtovoy wrote:
>> I first though this way too but the specification allows an NQN to have
>> logical partitions marked as hostIds:
>>
>> NVMe over fabrics spec 1.1a section 3.3 (p 27):
>
> This is simply broken and we must no support it.
I see.
So I'll re-spin it with 1:1 mapping between hostnqn and hostid. This
means we won't allow any nqn to have multiple ids and vice versa.
prev parent reply other threads:[~2023-05-11 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 18:02 [PATCH v1 0/3] nvme-fabrics: fix un-expected behaviour related to hostnqn and hostid Max Gurtovoy
2023-05-10 18:02 ` [PATCH 1/3] nvme-fabrics: unify common code in admin and io queue connect Max Gurtovoy
2023-05-11 13:12 ` Christoph Hellwig
2023-05-10 18:02 ` [PATCH 2/3] nvme-fabrics: check hostid using uuid_equal Max Gurtovoy
2023-05-11 13:13 ` Christoph Hellwig
2023-05-11 13:27 ` Max Gurtovoy
2023-05-10 18:02 ` [PATCH 3/3] nvme-fabrics: prevent overriding of existing host Max Gurtovoy
2023-05-11 13:16 ` Christoph Hellwig
2023-05-11 13:26 ` Max Gurtovoy
2023-05-11 13:49 ` Christoph Hellwig
2023-05-11 13:59 ` Max Gurtovoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33db06d5-36fc-77bb-1f0c-adb61fc77767@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ngottlieb@nvidia.com \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.