Re: [RFCv2 00/15] RFCv2: Consolidated userspace RDMA library repo

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1970 bytes --]

On 8/29/2016 9:27 PM, Jarod Wilson wrote:
> On Fri, Aug 26, 2016 at 11:00:22PM -0400, Doug Ledford wrote:
>> On 8/26/2016 6:27 PM, Jason Gunthorpe wrote:
> ...
>>> 3) Version numbers. What version numbers do we give to the sub
>>>    packages? I guess this is very distro specific.
>>
>> You can not give different versions to sub-packages.  Or, allow me to be
>> more precise:  You can't use the Version: tag on sub-packages, it resets
>> the version of the entire package overall when you do.  The last
>> Version: tag in the spec file ends up being the version applied to
>> everything.  This impacts the %{version} macro usage in the spec file.
>> The only way to put versions on sub-packages is to make it part of the
>> sub-package's name.
> 
> I'm not so sure about that. Check out our linux-firmware package and
> sub-packages. There are several firmwares with their own Version: tags in
> their sub-package definitions, and the base linux-firmware package still
> comes out of there with the intended original Version: from the top of the
> spec. I suppose %{version} maybe does get stomped on,

Correct.  The %{version} macro gets stomped on, so all of the typical
guidelines about spec files that tell you to use %{version} in various
places have to be ignored.

> but the solution
> I've seen used is to simply set an extra %global and use that where you
> would have used %{version} in the spec.

Yes, that works.  But it's an ugly hack and should be taken as a clue
that you are using rpm in a way that it doesn't want to be used ;-)

> That said, I tend to agree with what Doug is saying... If this is all one
> big tree, then it's one big release, and should have one big consistent
> version number, most likely. Otherwise, it's a massive headache and a bit
> of a mess to maintain, package-wise, like he said.
> 


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]