All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nazar Kazakov <nazar.kazakov@codethink.co.uk>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH] perf jevents: make events order more deterministic
Date: Mon, 06 Jul 2026 20:08:34 +0100	[thread overview]
Message-ID: <33e2fcf9b93f39e9e75e80b1af1bdb1c@codethink.co.uk> (raw)
In-Reply-To: <CAP-5=fWm8q6EX29hY33xoDNFJYoGOB4GnsLkXarUFzsoUZVEqg@mail.gmail.com>

On 2026-07-06 19:48, Ian Rogers wrote:

> I see the problem from your example. I wonder a more complete fix
> would be something like:
> ```
>    def __lt__(self, other):
>      """Sort order."""
>     if self.name != other.name:
>         return self.name < other.name
>     if not self.expr.Equals(other.expr):
>         return self.expr.ToPerfJson() < other.expr.ToPerfJson()
>     return self.description < other.description
> ```
> wdyt?

Yep, your code looks better. Also Sashiko AI tool found an embarrasing
bug in mine 
https://sashiko.dev/#/patchset/20260706175624.692736-1-nazar.kazakov@codethink.co.uk?part=1

So let's go with yours :)

Thanks,
Nazar Kazakov

      reply	other threads:[~2026-07-06 19:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 17:56 [PATCH] perf jevents: make events order more deterministic Nazar Kazakov
2026-07-06 18:01 ` sashiko-bot
2026-07-06 18:04 ` Ian Rogers
2026-07-06 18:22   ` Nazar Kazakov
2026-07-06 18:48     ` Ian Rogers
2026-07-06 19:08       ` Nazar Kazakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33e2fcf9b93f39e9e75e80b1af1bdb1c@codethink.co.uk \
    --to=nazar.kazakov@codethink.co.uk \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.