From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A203C2BBD1 for ; Thu, 17 Sep 2020 10:24:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17D2E2083B for ; Thu, 17 Sep 2020 10:24:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1OQ6nTMq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17D2E2083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ComqX+wlTZHYMRXW0w5/nF5LFtkQASc2EmZRB7c65/o=; b=1OQ6nTMqtRQIbyjyYs16BtcI2 VN6+H6JgSA5+PDzPkCW4XaAuFOUbRf7dMlQStiHAqETSimfIAl3MagYRu2AoOsS9X522d5kv3u1Dl rDcfwTRVihsye9re+7/XazYBiJdMfGbdWD9komv2zFik0/mYJj+NjnJ7WVdDfdq+Q1AX9Hpv3NTGv C+/u1TP/MD4QAA7bxtSp1fZZmqo57/KYmSg9s3yp53J3MskS3a6S2DZCX++q5ay/7pqG9xpaknqnd /SXjt/Y5jee4277GFWkwUBdXAoURvDkFODFK15Ai+CLpV+YC5620bptoswPouxsbCNtFwOiRPytVE vAaZggNDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIr49-0005ME-IZ; Thu, 17 Sep 2020 10:23:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIr43-0005K4-FY for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 10:22:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9AF2230E; Thu, 17 Sep 2020 03:22:53 -0700 (PDT) Received: from [10.57.47.84] (unknown [10.57.47.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35C5C3F68F; Thu, 17 Sep 2020 03:22:52 -0700 (PDT) Subject: Re: [PATCH 2/2] arm64/mm: Enable color zero pages To: Gavin Shan , Will Deacon References: <20200916032523.13011-1-gshan@redhat.com> <20200916032523.13011-3-gshan@redhat.com> <20200916082819.GB27496@willie-the-truck> From: Robin Murphy Message-ID: <33e9a04e-9f93-6a06-273d-284900bc1535@arm.com> Date: Thu, 17 Sep 2020 11:22:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_062255_692430_2B09F24A X-CRM114-Status: GOOD ( 40.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, shan.gavin@gmail.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wOS0xNyAwNDozNSwgR2F2aW4gU2hhbiB3cm90ZToKPiBIaSBXaWxsLAo+IAo+IE9u IDkvMTYvMjAgNjoyOCBQTSwgV2lsbCBEZWFjb24gd3JvdGU6Cj4+IE9uIFdlZCwgU2VwIDE2LCAy MDIwIGF0IDAxOjI1OjIzUE0gKzEwMDAsIEdhdmluIFNoYW4gd3JvdGU6Cj4+PiBUaGlzIGVuYWJs ZXMgY29sb3IgemVybyBwYWdlcyBieSBhbGxvY2F0aW5nIGNvbnRpZ291cyBwYWdlIGZyYW1lcwo+ Pj4gZm9yIGl0LiBUaGUgbnVtYmVyIG9mIHBhZ2VzIGZvciB0aGlzIGlzIGRldGVybWluZWQgYnkg TDEgZENhY2hlCj4+PiAob3IgaUNhY2hlKSBzaXplLCB3aGljaCBpcyBwcm9iYmVkIGZyb20gdGhl IGhhcmR3YXJlLgo+Pj4KPj4+IMKgwqDCoCAqIEFkZCBjYWNoZV90b3RhbF9zaXplKCkgdG8gcmV0 dXJuIEwxIGRDYWNoZSAob3IgaUNhY2hlKSBzaXplCj4+Pgo+Pj4gwqDCoMKgICogSW1wbGVtZW50 IHNldHVwX3plcm9fcGFnZXMoKSwgd2hpY2ggaXMgY2FsbGVkIGFmdGVyIHRoZSBwYWdlCj4+PiDC oMKgwqDCoMKgIGFsbG9jYXRvciBiZWdpbnMgdG8gd29yaywgdG8gYWxsb2NhdGUgdGhlIGNvbnRp Z291cyBwYWdlcwo+Pj4gwqDCoMKgwqDCoCBuZWVkZWQgYnkgY29sb3IgemVybyBwYWdlLgo+Pj4K Pj4+IMKgwqDCoCAqIFJld29ya2VkIFpFUk9fUEFHRSgpIGFuZCBkZWZpbmUgX19IQVZFX0NPTE9S X1pFUk9fUEFHRS4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBHYXZpbiBTaGFuIDxnc2hhbkByZWRo YXQuY29tPgo+Pj4gLS0tCj4+PiDCoCBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL2NhY2hlLmjCoMKg IHwgMjIgKysrKysrKysrKysrKysrKysrKysKPj4+IMKgIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20v cGd0YWJsZS5oIHzCoCA5ICsrKysrKy0tCj4+PiDCoCBhcmNoL2FybTY0L2tlcm5lbC9jYWNoZWlu Zm8uY8KgwqDCoCB8IDM0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4+IMKgIGFy Y2gvYXJtNjQvbW0vaW5pdC5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgMzUgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysKPj4+IMKgIGFyY2gvYXJtNjQvbW0vbW11LmPCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCB8wqAgNyAtLS0tLS0tCj4+PiDCoCA1IGZpbGVzIGNoYW5nZWQs IDk4IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJtNjQvaW5jbHVkZS9hc20vY2FjaGUuaCAKPj4+IGIvYXJjaC9hcm02NC9pbmNsdWRlL2Fz bS9jYWNoZS5oCj4+PiBpbmRleCBhNGQxYjVmNzcxZjYuLjQyMGU5ZGRlMmM1MSAxMDA2NDQKPj4+ IC0tLSBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vY2FjaGUuaAo+Pj4gKysrIGIvYXJjaC9hcm02 NC9pbmNsdWRlL2FzbS9jYWNoZS5oCj4+PiBAQCAtMzksNiArMzksMjcgQEAKPj4+IMKgICNkZWZp bmUgQ0xJRFJfTE9DKGNsaWRyKcKgwqDCoCAoKChjbGlkcikgPj4gQ0xJRFJfTE9DX1NISUZUKSAm IDB4NykKPj4+IMKgICNkZWZpbmUgQ0xJRFJfTE9VSVMoY2xpZHIpwqDCoMKgICgoKGNsaWRyKSA+ PiBDTElEUl9MT1VJU19TSElGVCkgJiAweDcpCj4+PiArI2RlZmluZSBDU1NFTFJfVE5EX1NISUZU wqDCoMKgIDQKPj4+ICsjZGVmaW5lIENTU0VMUl9UTkRfTUFTS8KgwqDCoMKgwqDCoMKgIChVTCgx KSA8PCBDU1NFTFJfVE5EX1NISUZUKQo+Pj4gKyNkZWZpbmUgQ1NTRUxSX0xFVkVMX1NISUZUwqDC oMKgIDEKPj4+ICsjZGVmaW5lIENTU0VMUl9MRVZFTF9NQVNLwqDCoMKgIChVTCg3KSA8PCBDU1NF TFJfTEVWRUxfU0hJRlQpCj4+PiArI2RlZmluZSBDU1NFTFJfSU5EX1NISUZUwqDCoMKgIDAKPj4+ ICsjZGVmaW5lIENTU0VSTF9JTkRfTUFTS8KgwqDCoMKgwqDCoMKgIChVTCgxKSA8PCBDU1NFTFJf SU5EX1NISUZUKQo+Pj4gKwo+Pj4gKyNkZWZpbmUgQ0NTSURSXzY0X0xTX1NISUZUwqDCoMKgIDAK Pj4+ICsjZGVmaW5lIENDU0lEUl82NF9MU19NQVNLwqDCoMKgIChVTCg3KSA8PCBDQ1NJRFJfNjRf TFNfU0hJRlQpCj4+PiArI2RlZmluZSBDQ1NJRFJfNjRfQVNTT0NfU0hJRlTCoMKgwqAgMwo+Pj4g KyNkZWZpbmUgQ0NTSURSXzY0X0FTU09DX01BU0vCoMKgwqAgKFVMKDB4MUZGRkZGKSA8PCBDQ1NJ RFJfNjRfQVNTT0NfU0hJRlQpCj4+PiArI2RlZmluZSBDQ1NJRFJfNjRfU0VUX1NISUZUwqDCoMKg IDMyCj4+PiArI2RlZmluZSBDQ1NJRFJfNjRfU0VUX01BU0vCoMKgwqAgKFVMKDB4RkZGRkZGKSA8 PCBDQ1NJRFJfNjRfU0VUX1NISUZUKQo+Pj4gKwo+Pj4gKyNkZWZpbmUgQ0NTSURSXzMyX0xTX1NI SUZUwqDCoMKgIDAKPj4+ICsjZGVmaW5lIENDU0lEUl8zMl9MU19NQVNLwqDCoMKgIChVTCg3KSA8 PCBDQ1NJRFJfMzJfTFNfU0hJRlQpCj4+PiArI2RlZmluZSBDQ1NJRFJfMzJfQVNTT0NfU0hJRlTC oMKgwqAgMwo+Pj4gKyNkZWZpbmUgQ0NTSURSXzMyX0FTU09DX01BU0vCoMKgwqAgKFVMKDB4M0ZG KSA8PCBDQ1NJRFJfMzJfQVNTT0NfU0hJRlQpCj4+PiArI2RlZmluZSBDQ1NJRFJfMzJfU0VUX1NI SUZUwqDCoMKgIDEzCj4+PiArI2RlZmluZSBDQ1NJRFJfMzJfU0VUX01BU0vCoMKgwqAgKFVMKDB4 N0ZGRikgPDwgQ0NTSURSXzMyX1NFVF9TSElGVCkKPj4KPj4gSSBkb24ndCB0aGluayB3ZSBzaG91 bGQgYmUgaW5mZXJyaW5nIGNhY2hlIHN0cnVjdHVyZSBmcm9tIHRoZXNlIHJlZ2lzdGVyCj4+IHZh bHVlcy4gVGhlIEFybSBBUk0gaGVscGZ1bGx5IHNheXM6Cj4+Cj4+IMKgwqAgfCBZb3UgY2Fubm90 IG1ha2UgYW55IGluZmVyZW5jZSBhYm91dCB0aGUgYWN0dWFsIHNpemVzIG9mIGNhY2hlcyBiYXNl ZAo+PiDCoMKgIHwgb24gdGhlc2UgcGFyYW1ldGVycy4KPj4KPj4gc28gd2UgbmVlZCB0byB0YWtl IHRoZSB0b3BvbG9neSBpbmZvcm1hdGlvbiBmcm9tIGVsc2V3aGVyZS4KPj4KPiAKPiBZZWFoLCBJ IGFsc28gbm90aWNlZCB0aGUgc3RhdGVtZW50IGluIHRoZSBzcGVjLiBIb3dldmVyLCB0aGUgTDEg Y2FjaGUgc2l6ZQo+IGZpZ3VyZWQgb3V0IGZyb20gYWJvdmUgcmVnaXN0ZXJzIGFyZSBtYXRjaGlu ZyB3aXRoICJsc2NwdSIgb24gdGhlIG1hY2hpbmUKPiB3aGVyZSBJIGRpZCBteSB0ZXN0cy4gTm90 ZSAibHNjcHUiIGRlcGVuZHMgb24gc3lzZnMgZW50cmllcyB3aG9zZSAKPiBpbmZvcm1hdGlvbgo+ IGlzIHJldHJpZXZlZCBmcm9tIEFDUEkgKFBQVFQpIHRhYmxlLiBUaGUgbnVtYmVyIG9mIGNhY2hl IGxldmVscyBhcmUgCj4gcGFydGlhbGx5Cj4gcmV0cmlldmVkIGZyb20gc3lzdGVtIHJlZ2lzdGVy IChjbGlkcl9lbDEpLgo+IAo+IEl0J3MgZG9hYmxlIHRvIHJldHJpZXZlIHRoZSBMMSBjYWNoZSBz aXplIGZyb20gQUNQSSAoUFBUVCkgdGFibGUuIEknbGwKPiBjaGFuZ2UgYWNjb3JkaW5nbHkgaW4g djIgaWYgdGhpcyBlbmFibGVtZW50IGlzIHJlYWxseSBuZWVkZWQuIE1vcmUgY2xhcmlmeQo+IGlz IHByb3ZpZGVkIGJlbG93Lgo+IAo+PiBCdXQgYmVmb3JlIHdlIGdldCBpbnRvIHRoYXQsIGNhbiB5 b3UganVzdGlmeSB3aHkgd2UgbmVlZCB0byBkbyB0aGlzIGF0IAo+PiBhbGwsCj4+IHBsZWFzZT8g RG8geW91IGhhdmUgZGF0YSB0byBzaG93IHRoZSBiZW5lZml0IG9mIGFkZGluZyB0aGlzIGNvbXBs ZXhpdHk/Cj4+Cj4gCj4gSW5pdGlhbGx5LCBJIGZvdW5kIGl0J3MgdGhlIG1pc3NlZCBmZWF0dXJl IHdoaWNoIGhhcyBiZWVuIGVuYWJsZWQgb24KPiBtaXBzL3MzOTAuIEN1cnJlbnRseSwgYWxsIHJl YWQtb25seSBhbm9ueW1vdXMgVk1BcyBhcmUgYmFja2VkIHVwIGJ5Cj4gc2FtZSB6ZXJvIHBhZ2Uu IEl0IG1lYW5zIGFsbCByZWFkcyB0byB0aGVzZSBWTUFzIGFyZSBjYWNoZWQgYnkgc2FtZQo+IHNl dCBvZiBjYWNoZSwgYnV0IHN0aWxsIG11bHRpcGxlIHdheXMgaWYgc3VwcG9ydGVkLiBTbyBpdCB3 b3VsZCBiZQo+IG5pY2UgdG8gaGF2ZSBtdWx0aXBsZSB6ZXJvIHBhZ2VzIHRvIGJhY2sgdXAgdGhl c2UgcmVhZC1vbmx5IGFub255bW91cwo+IFZNQXMsIHNvIHRoYXQgdGhlIHJlYWRzIG9uIHRoZW0g Y2FuIGJlIGNhY2hlZCBieSBtdWx0aXBsZSBzZXRzIChtdWx0aXBsZQo+IHdheXMgc3RpbGwgaWYg c3VwcG9ydGVkKS4gSXQncyBvdmVyYWxsIGJlbmVmaWNpYWwgdG8gdGhlIHBlcmZvcm1hbmNlLgoK SXMgdGhpcyBhIGNvbmNlcm4gZm9yIHRydWUgUElQVCBjYWNoZXMsIG9yIGlzIGl0IHJlYWxseSBq dXN0IHdvcmtpbmcgCmFyb3VuZCBhIHBhdGhvbG9naWNhbCBjYXNlIGZvciBhbGlhcy1kZXRlY3Rp bmcgVklQVCBjYWNoZXM/Cgo+IFVuZm9ydHVuYXRlbHksIEkgZGlkbid0IGZpbmQgYSBtYWNoaW5l IHdoZXJlIHRoZSBzaXplIG9mIGNhY2hlIHNldCBpcwo+IGxhcmdlciB0aGFuIHBhZ2Ugc2l6ZS4g U28gSSBoYWQgb25lIGV4cGVyaW1lbnQgYXMgaW5kaWNhdGlvbiBob3cgTDEKPiBkYXRhIGNhY2hl IG1pc3MgYWZmZWN0cyB0aGUgb3ZlcmFsbCBwZXJmb3JtYW5jZToKPiAKPiAgwqDCoMKgIEwxIGRh dGEgY2FjaGUgc2l6ZTrCoMKgwqDCoMKgwqDCoMKgwqDCoCAzMktCCj4gIMKgwqDCoCBMMSBkYXRh IGNhY2hlIGxpbmUgc2l6ZTrCoMKgwqDCoMKgIDY0Cj4gIMKgwqDCoCBOdW1iZXIgb2YgTDEgZGF0 YSBjYWNoZSBzZXQ6wqAgNjQKPiAgwqDCoMKgIE51bWJlciBvZiBMMSBkYXRhIGNhY2hlIHdheXM6 IDgKPiAgwqDCoMKgIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBzaXplID0gKGNhY2hlX2xpbmVfc2l6ZSkgKiAobnVtX29mX3NldHMpICogKG51bV9v Zl93YXlzKQo+IAo+ICDCoMKgwqAgS2VybmVsIGNvbmZpZ3VyYXRpb246Cj4gIMKgwqDCoMKgwqDC oMKgwqDCoMKgIFZBX0JJVFM6wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA0OAo+ICDCoMKg wqDCoMKgwqDCoMKgwqDCoCBQQUdFX1NJWkU6wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDRLQgo+ ICDCoMKgwqDCoMKgwqDCoMKgwqDCoCBQTUQgSHVnZVRMQiBQYWdlIFNpemU6IDJNQgo+IAo+ICDC oMKgwqAgRXhwZXJpbWVudDoKPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqAgSSBoYXZlIGEgcHJvZ3Jh bSB0byBkbyB0aGUgZm9sbG93aW5nIHRoaW5ncyBhbmQgY2hlY2sgdGhlCj4gIMKgwqDCoMKgwqDC oMKgwqDCoMKgIGNvbnN1bWVkIHRpbWUgYW5kIEwxLWRhdGEtY2FjaGUtbWlzc2VzIGJ5IHBlcmYu Cj4gCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgICgxKSBBbGxvY2F0ZSAobW1hcCkgYSBQTUQgSHVn ZVRMQiBQYWdlLCB3aGljaCBpcyAyTUIuCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgICgyKSBSZWFk IG9uIHRoZSBtbWFwJ2QgcmVnaW9uIGluIHN0ZXAgb2YgcGFnZSBzaXplICg0S0IpCj4gIMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZm9yIDggb3IgOSB0aW1lcy4gTm90ZSA4IGlzIHRoZSBu dW1iZXIgb2YgZGF0YSBjYWNoZQo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHdheXMu Cj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgICgzKSBSZXBlYXQgKDIpIGZvciAxMDAwMDAwIHRpbWVz Lgo+ICDCoMKgwqAgUmVzdWx0Ogo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoYSkgd2hlbiB3ZSBo YXZlIDggZm9yIHRoZSBzdGVwcyBpbiAoMik6Cj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgMzcsMTAzwqDCoMKgwqDCoCBMMS1kY2FjaGUtbG9hZC1taXNzZXMKPiAgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAwLjIxNzUyMjUxNSBzZWNvbmRzIHRpbWUgZWxhcHNlZAo+ICDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDAuMjE3NTY0MDAwIHNlY29uZHMgdXNlcgo+ICDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDAuMDAwMDAwMDAwIHNlY29uZHMgc3lzCj4gIMKgwqDC oMKgwqDCoMKgwqDCoMKgIChiKSB3aGVuIHdlIGhhdmUgOSBmb3IgdGhlIHN0ZXBzIGluICgyKToK PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA0LDY4Nyw5MzLCoMKgIEwxLWRjYWNoZS1s b2FkLW1pc3Nlc8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKDEyNiB0aW1lcykKPiAgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAwLjI0ODEzMjEwNSBzZWNvbmRzIHRpbWUgZWxhcHNlZMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAoKzE0LjIlKQo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIDAuMjQ4MjY3MDAwIHNlY29uZHMgdXNlcgo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIDAuMDAwMDAwMDAwIHNlY29uZHMgc3lzCgpJIGhhdmUgYSB2YWd1ZSBmZWVsaW5nIHRoaXMg bWF5IGhhdmUgY29tZSB1cCBiZWZvcmUsIGJ1dCBhcmUgdGhlcmUgCnJlYWwtd29ybGQgYXBwbGlj YXRpb25zIHRoYXQgaGF2ZSBhIHBlcmZvcm1hbmNlIGJvdHRsZW5lY2sgb24gcmVhZGluZyAKZnJv bSB1bmluaXRpYWxpc2VkIG1lbW9yeT8gQXMgZmFyIGFzIHN5bnRoZXRpYyBiZW5jaG1hcmtzIGdv LCBJJ20gc3VyZSAKd2UgY291bGQgZXF1YWxseSBjb21lIHVwIHdpdGggb25lIHRoYXQgc2hvd3Mg YSByZWdyZXNzaW9uIGR1ZSB0byByZWFsIApkYXRhIGJlaW5nIHB1c2hlZCBvdXQgb2YgdGhlIGNh Y2hlIGJ5IGFsbCB0aG9zZSBleHRyYSB6ZXJvcyA7KQoKUm9iaW4uCgo+IFBsZWFzZSBsZXQgbWUg a25vdyBpZiBpdCdzIHdvcnRoeSBmb3IgYSB2MiwgdG8gcmV0cmlldmUgdGhlIGNhY2hlIHNpemUK PiBmcm9tIEFDUEkgKFBQVFQpIHRhYmxlLiBUaGUgY29zdCBpcyB0byBhbGxvY2F0ZSBtdWx0aXBs ZSB6ZXJvIHBhZ2VzIGFuZAo+IHRoZSB3b3JzdCBjYXNlIGlzIGZhaWwgYmFjayB0byBvbmUgemVy byBwYWdlLCBhcyBiZWZvcmUgOikKPiAKPiBDaGVlcnMsCj4gR2F2aW4KPiAKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0Cj4gbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4g aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB0DC433E2 for ; Thu, 17 Sep 2020 10:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EB752083B for ; Thu, 17 Sep 2020 10:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbgIQKbW (ORCPT ); Thu, 17 Sep 2020 06:31:22 -0400 Received: from foss.arm.com ([217.140.110.172]:44236 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbgIQKaU (ORCPT ); Thu, 17 Sep 2020 06:30:20 -0400 X-Greylist: delayed 444 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 06:30:19 EDT Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9AF2230E; Thu, 17 Sep 2020 03:22:53 -0700 (PDT) Received: from [10.57.47.84] (unknown [10.57.47.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35C5C3F68F; Thu, 17 Sep 2020 03:22:52 -0700 (PDT) Subject: Re: [PATCH 2/2] arm64/mm: Enable color zero pages To: Gavin Shan , Will Deacon Cc: mark.rutland@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, shan.gavin@gmail.com, linux-arm-kernel@lists.infradead.org References: <20200916032523.13011-1-gshan@redhat.com> <20200916032523.13011-3-gshan@redhat.com> <20200916082819.GB27496@willie-the-truck> From: Robin Murphy Message-ID: <33e9a04e-9f93-6a06-273d-284900bc1535@arm.com> Date: Thu, 17 Sep 2020 11:22:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-17 04:35, Gavin Shan wrote: > Hi Will, > > On 9/16/20 6:28 PM, Will Deacon wrote: >> On Wed, Sep 16, 2020 at 01:25:23PM +1000, Gavin Shan wrote: >>> This enables color zero pages by allocating contigous page frames >>> for it. The number of pages for this is determined by L1 dCache >>> (or iCache) size, which is probbed from the hardware. >>> >>>     * Add cache_total_size() to return L1 dCache (or iCache) size >>> >>>     * Implement setup_zero_pages(), which is called after the page >>>       allocator begins to work, to allocate the contigous pages >>>       needed by color zero page. >>> >>>     * Reworked ZERO_PAGE() and define __HAVE_COLOR_ZERO_PAGE. >>> >>> Signed-off-by: Gavin Shan >>> --- >>>   arch/arm64/include/asm/cache.h   | 22 ++++++++++++++++++++ >>>   arch/arm64/include/asm/pgtable.h |  9 ++++++-- >>>   arch/arm64/kernel/cacheinfo.c    | 34 +++++++++++++++++++++++++++++++ >>>   arch/arm64/mm/init.c             | 35 ++++++++++++++++++++++++++++++++ >>>   arch/arm64/mm/mmu.c              |  7 ------- >>>   5 files changed, 98 insertions(+), 9 deletions(-) >>> >>> diff --git a/arch/arm64/include/asm/cache.h >>> b/arch/arm64/include/asm/cache.h >>> index a4d1b5f771f6..420e9dde2c51 100644 >>> --- a/arch/arm64/include/asm/cache.h >>> +++ b/arch/arm64/include/asm/cache.h >>> @@ -39,6 +39,27 @@ >>>   #define CLIDR_LOC(clidr)    (((clidr) >> CLIDR_LOC_SHIFT) & 0x7) >>>   #define CLIDR_LOUIS(clidr)    (((clidr) >> CLIDR_LOUIS_SHIFT) & 0x7) >>> +#define CSSELR_TND_SHIFT    4 >>> +#define CSSELR_TND_MASK        (UL(1) << CSSELR_TND_SHIFT) >>> +#define CSSELR_LEVEL_SHIFT    1 >>> +#define CSSELR_LEVEL_MASK    (UL(7) << CSSELR_LEVEL_SHIFT) >>> +#define CSSELR_IND_SHIFT    0 >>> +#define CSSERL_IND_MASK        (UL(1) << CSSELR_IND_SHIFT) >>> + >>> +#define CCSIDR_64_LS_SHIFT    0 >>> +#define CCSIDR_64_LS_MASK    (UL(7) << CCSIDR_64_LS_SHIFT) >>> +#define CCSIDR_64_ASSOC_SHIFT    3 >>> +#define CCSIDR_64_ASSOC_MASK    (UL(0x1FFFFF) << CCSIDR_64_ASSOC_SHIFT) >>> +#define CCSIDR_64_SET_SHIFT    32 >>> +#define CCSIDR_64_SET_MASK    (UL(0xFFFFFF) << CCSIDR_64_SET_SHIFT) >>> + >>> +#define CCSIDR_32_LS_SHIFT    0 >>> +#define CCSIDR_32_LS_MASK    (UL(7) << CCSIDR_32_LS_SHIFT) >>> +#define CCSIDR_32_ASSOC_SHIFT    3 >>> +#define CCSIDR_32_ASSOC_MASK    (UL(0x3FF) << CCSIDR_32_ASSOC_SHIFT) >>> +#define CCSIDR_32_SET_SHIFT    13 >>> +#define CCSIDR_32_SET_MASK    (UL(0x7FFF) << CCSIDR_32_SET_SHIFT) >> >> I don't think we should be inferring cache structure from these register >> values. The Arm ARM helpfully says: >> >>    | You cannot make any inference about the actual sizes of caches based >>    | on these parameters. >> >> so we need to take the topology information from elsewhere. >> > > Yeah, I also noticed the statement in the spec. However, the L1 cache size > figured out from above registers are matching with "lscpu" on the machine > where I did my tests. Note "lscpu" depends on sysfs entries whose > information > is retrieved from ACPI (PPTT) table. The number of cache levels are > partially > retrieved from system register (clidr_el1). > > It's doable to retrieve the L1 cache size from ACPI (PPTT) table. I'll > change accordingly in v2 if this enablement is really needed. More clarify > is provided below. > >> But before we get into that, can you justify why we need to do this at >> all, >> please? Do you have data to show the benefit of adding this complexity? >> > > Initially, I found it's the missed feature which has been enabled on > mips/s390. Currently, all read-only anonymous VMAs are backed up by > same zero page. It means all reads to these VMAs are cached by same > set of cache, but still multiple ways if supported. So it would be > nice to have multiple zero pages to back up these read-only anonymous > VMAs, so that the reads on them can be cached by multiple sets (multiple > ways still if supported). It's overall beneficial to the performance. Is this a concern for true PIPT caches, or is it really just working around a pathological case for alias-detecting VIPT caches? > Unfortunately, I didn't find a machine where the size of cache set is > larger than page size. So I had one experiment as indication how L1 > data cache miss affects the overall performance: > >     L1 data cache size:           32KB >     L1 data cache line size:      64 >     Number of L1 data cache set:  64 >     Number of L1 data cache ways: 8 >     ---------------------------------------------------------------------- >                   size = (cache_line_size) * (num_of_sets) * (num_of_ways) > >     Kernel configuration: >            VA_BITS:               48 >            PAGE_SIZE:             4KB >            PMD HugeTLB Page Size: 2MB > >     Experiment: >            I have a program to do the following things and check the >            consumed time and L1-data-cache-misses by perf. > >            (1) Allocate (mmap) a PMD HugeTLB Page, which is 2MB. >            (2) Read on the mmap'd region in step of page size (4KB) >                for 8 or 9 times. Note 8 is the number of data cache >                ways. >            (3) Repeat (2) for 1000000 times. >     Result: >            (a) when we have 8 for the steps in (2): >                37,103      L1-dcache-load-misses >                0.217522515 seconds time elapsed >                0.217564000 seconds user >                0.000000000 seconds sys >            (b) when we have 9 for the steps in (2): >                4,687,932   L1-dcache-load-misses            (126 times) >                0.248132105 seconds time elapsed             (+14.2%) >                0.248267000 seconds user >                0.000000000 seconds sys I have a vague feeling this may have come up before, but are there real-world applications that have a performance bottleneck on reading from uninitialised memory? As far as synthetic benchmarks go, I'm sure we could equally come up with one that shows a regression due to real data being pushed out of the cache by all those extra zeros ;) Robin. > Please let me know if it's worthy for a v2, to retrieve the cache size > from ACPI (PPTT) table. The cost is to allocate multiple zero pages and > the worst case is fail back to one zero page, as before :) > > Cheers, > Gavin > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel