Re: [PATCH 1/2] ap: Move AP parameters to a struct

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

Hi Andrew,

>> I do wonder why you decided to make authorized_macs into a double-level array
>> instead of just a flat one...  You can always realloc if you need to grow it..
> 
> Right, I thought it's just more natural when you can access n'th
> element with array[n], or you can iterate like over a list like I did
> here.
> And you don't need to make assumptions about the length of the array.

That just seems so wasteful though?  I mean each pointer is 8 bytes on 64-bit, 
more than you pay for the mac address itself.  Plus god knows how much you pay 
in malloc overhead.  No point being wasteful unnecessarily.

>>
>> I think eventually we probably want to make this a proper API.  like
>> ap_config_new, ap_config_set_ssid, ap_config_set_passphrase, etc.
> 
> Do you mean eventually, or now?  I personally would prefer l_settings
> over that, once you add accessors it loses the benefit of a nice
> struct that can be read and written easily.
> 
But this can be defined inside ap.c.  So opaque only to clients of ap.c.  Do you 
need to access the struct elsewhere?  If so, then the whole blurb in the 
documentation about ap_start taking ownership isn't really true...

Regards,
-Denis