From: Jeff Layton <jlayton@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: add a debugfs files for showing netns refcount tracking info
Date: Mon, 24 Mar 2025 20:37:57 -0400 [thread overview]
Message-ID: <33f758b03548b869f75d72a24c3abbcf382427ae.camel@kernel.org> (raw)
In-Reply-To: <59446182-8d60-40a0-975f-30069b0afe86@lunn.ch>
On Mon, 2025-03-24 at 21:50 +0100, Andrew Lunn wrote:
> On Mon, Mar 24, 2025 at 04:24:47PM -0400, Jeff Layton wrote:
> > CONFIG_NET_NS_REFCNT_TRACKER currently has no convenient way to display
> > its tracking info. Add a new net_ns directory in debugfs. Have a
> > directory in there for every net, with refcnt and notrefcnt files that
> > show the currently tracked active and passive references.
>
> Hi Jeff
>
> CONFIG_NET_NS_REFCNT_TRACKER is just an instance of
> CONFIG_REF_TRACKER.
>
> It would be good to explain why you are doing it at the netdev level,
> rather than part of the generic CONFIG_REF_TRACKER level. Why would
> other subsystems not benefit from having their reference trackers in
> debugfs?
>
>
Mostly because I just needed the NS_REFCNT_TRACKER at the time.
I'm OK with making this more general, but all of those subsystems using
refcount trackers would need to add the infrastructure to create
directories to track them.
To whit:
What would the directory structure look like for the more general case?
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-03-25 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 20:24 [PATCH] net: add a debugfs files for showing netns refcount tracking info Jeff Layton
2025-03-24 20:50 ` Andrew Lunn
2025-03-25 0:37 ` Jeff Layton [this message]
2025-03-25 13:00 ` Andrew Lunn
2025-03-25 5:21 ` Eric Dumazet
2025-03-25 11:47 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f758b03548b869f75d72a24c3abbcf382427ae.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.