From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: fix build Date: Wed, 29 Jul 2015 18:05:31 +0200 Message-ID: <3400596.gUZi4e9jS4@xps13> References: <1438123707-26509-1-git-send-email-helin.zhang@intel.com> <55B8EBD1.5090104@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Zhang, Helin" Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 79813C41C for ; Wed, 29 Jul 2015 18:06:46 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so33331615wib.1 for ; Wed, 29 Jul 2015 09:06:46 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-29 15:09, Zhang, Helin: > From: Gonzalez Monroy, Sergio > > Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux and bsd") > > > > The function rte_eal_pci_probe_one_driver, which calls pci_config_space_set, > > was moved to eal_common_pci.c, but pci_config_space_set was left in eal_pci.c > > with static specifier. > > Yes, that's the root cause. > I am just have a thought that we may need to move all of those three functions > together into eal_common_pci.c, which can avoid exporting that function. No it is specific to Linux (implemented in igb_uio only). But it may be moved to eal_common if you remove the igb_uio patch and use the new functions to access to PCI config with UIO or VFIO: http://dpdk.org/browse/dpdk/commit/?id=632b2d1deeed This build fix will be applied for 2.1. It is expected the above rework will be done for 2.2. Thanks