From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7186E9B368 for ; Mon, 2 Mar 2026 11:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WJ6Fp+6ND9bT9YLc0KTOaJB8aEFzkS2JdOdry7EMlC0=; b=qXVkAT7yFh24G3ZDV113t8vCrB 3TKN6hJhHmpkkYy/yxl+TrQIxsZPZmPZrimARNTdFDfXCB6Vn3xJOL79YY62OqcaXKGucpEGwTxHZ nYu3lzQNS4C+ltNhawXc8EthVgivg0WjKKzqc4JHJ5OzelXEu6kdvEBldqpYTa/5WYmxiXoqpDu2a 8BxCue8FAYlORSh/gk8jY/mDq/HZORrw88gIZnT3uiZo2kl6YHr4tikQMyoho/MexpUAsUBhuWBHi deYJeFSf9msY9Hfh3VnwHuy9ilYViBsy7+Jp1v5TO8vP0dIzungcXHfMDp7+z/OV7J6VT5TMwNB/M if8BLNGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vx18N-0000000CmQs-1qQo; Mon, 02 Mar 2026 11:08:19 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vx18L-0000000CmQS-0bAv; Mon, 02 Mar 2026 11:08:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=WJ6Fp+6ND9bT9YLc0KTOaJB8aEFzkS2JdOdry7EMlC0=; b=Ksmu/junNI891rI+Ldwlu8ZOJY USTaEE9SRmuxDtB7tw1boBq1aKDP9VOpYkyP1KF8JJ8W0bsTfqSl+oFOoYEeT7netLIqrKUViXeOg s/WIYF7opi46e4TX8s0ltxDLp42GZL1CIygKM1hHpk2ksDaxM3hjdpjDRH/zQkuuOwB1QBmNKF2V3 xuh33WUrtEjXPVYQ7V014Qpx1ssy/hUE3qPNvnjNSsWrSMJZnw/x1gvTr8+rjaQ0+vMcJGncIGLKp fms8+QIHeP7QE3LBFcXiCgZ1Jxnq0YwXUaZnhZ/FOO8gtFWVz68oy1alLKIHf/iWkFq2GHrTkvQhv Zcc/KD4Q==; From: Heiko Stuebner To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , david@ixit.cz Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Filla , David Heidelberg Subject: Re: [PATCH] arm64: dts: rockchip: Fix PCIe v3 pinctrl for BPI-R2-Pro Date: Mon, 02 Mar 2026 12:08:14 +0100 Message-ID: <3404271.44csPzL39Z@phil> In-Reply-To: <20260301-rk3568-bri-r2-pro-fix-pcie-v1-1-b9ed318b4a77@ixit.cz> References: <20260301-rk3568-bri-r2-pro-fix-pcie-v1-1-b9ed318b4a77@ixit.cz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260302_030817_179580_A8F9342B X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David, Am Sonntag, 1. M=C3=A4rz 2026, 16:54:41 Mitteleurop=C3=A4ische Normalzeit s= chrieb David Heidelberg via B4 Relay: > From: David Heidelberg >=20 > Add missing pinctrl for PD4 (PI6C PCIe clock enable, > PCIE_CLKEN_H_GPIO0_D4) and set output high. >=20 > This does fix freeze at initialization due pinctrl being in input > state. >=20 > Reported-by: Martin Filla # reported by private messa= ge > Signed-off-by: David Heidelberg > --- > arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/ar= m64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > index 4d3ebe50b90ba..b4c8abe37d1f3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > @@ -121,6 +121,8 @@ vcc3v3_pi6c_05: regulator-vcc3v3-pi6c-05 { > regulator-max-microvolt =3D <3300000>; > enable-active-high; > gpios =3D <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>; > + pinctrl-0 =3D <&pi6cpcie_enable_h>; > + pinctrl-names =3D "default"; please model hardware not how you want to use it. The pi6c in the pin-name suggests, that this is a Diodes clock-generator that creates the 100MHz frequency for PCIe [0] . Please see [1] for one possible variant to model this. Heiko [0] https://www.diodes.com/part/view/PI6CG33602C or some variant of it [1] http://lore.kernel.org/all/20260210080303.680403-1-heiko@sntech.de From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B8E4E9B369 for ; Mon, 2 Mar 2026 11:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s1HhP/HRfcYI1NFK6/+wRMq7dPX0TGsTlsFATMereFU=; b=nwNpdZtWiNez3P L15XGGjG9zHfAlIP5L/tLUD7gI6bBYZGAefR0gV8Al3QNFFFixzYrgZnqo6tBprxavKmz0L886Zdq MgZkdJ/CxysMnUKCRlL4s/ZHNWlapkFleVgjRE5/BsA1NPdGFOrC0Y/VXSXT1JA5VXNKfyRRnfOPz /yv5iNewkOkhwLelN6MICOXfLb0SBjx8GLOwBQQAOSwu5gfQjSNNPP/J4j6cfTKH3SWPek4ADd57W JhYQYhsm3kYe5fOlZz+bMmGrZnJ+xo1ezpzrL4bk+6y8zgp67bWI5MdrPczfk5FJLcaMdi70NE0Bx 6qQ327TuFIbC6rJDn0nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vx18N-0000000CmR8-3HSx; Mon, 02 Mar 2026 11:08:19 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vx18L-0000000CmQS-0bAv; Mon, 02 Mar 2026 11:08:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=WJ6Fp+6ND9bT9YLc0KTOaJB8aEFzkS2JdOdry7EMlC0=; b=Ksmu/junNI891rI+Ldwlu8ZOJY USTaEE9SRmuxDtB7tw1boBq1aKDP9VOpYkyP1KF8JJ8W0bsTfqSl+oFOoYEeT7netLIqrKUViXeOg s/WIYF7opi46e4TX8s0ltxDLp42GZL1CIygKM1hHpk2ksDaxM3hjdpjDRH/zQkuuOwB1QBmNKF2V3 xuh33WUrtEjXPVYQ7V014Qpx1ssy/hUE3qPNvnjNSsWrSMJZnw/x1gvTr8+rjaQ0+vMcJGncIGLKp fms8+QIHeP7QE3LBFcXiCgZ1Jxnq0YwXUaZnhZ/FOO8gtFWVz68oy1alLKIHf/iWkFq2GHrTkvQhv Zcc/KD4Q==; From: Heiko Stuebner To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , david@ixit.cz Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Filla , David Heidelberg Subject: Re: [PATCH] arm64: dts: rockchip: Fix PCIe v3 pinctrl for BPI-R2-Pro Date: Mon, 02 Mar 2026 12:08:14 +0100 Message-ID: <3404271.44csPzL39Z@phil> In-Reply-To: <20260301-rk3568-bri-r2-pro-fix-pcie-v1-1-b9ed318b4a77@ixit.cz> References: <20260301-rk3568-bri-r2-pro-fix-pcie-v1-1-b9ed318b4a77@ixit.cz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260302_030817_179580_A8F9342B X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgRGF2aWQsCgpBbSBTb25udGFnLCAxLiBNw6RyeiAyMDI2LCAxNjo1NDo0MSBNaXR0ZWxldXJv cMOkaXNjaGUgTm9ybWFsemVpdCBzY2hyaWViIERhdmlkIEhlaWRlbGJlcmcgdmlhIEI0IFJlbGF5 Ogo+IEZyb206IERhdmlkIEhlaWRlbGJlcmcgPGRhdmlkQGl4aXQuY3o+Cj4gCj4gQWRkIG1pc3Np bmcgcGluY3RybCBmb3IgUEQ0IChQSTZDIFBDSWUgY2xvY2sgZW5hYmxlLAo+IFBDSUVfQ0xLRU5f SF9HUElPMF9ENCkgYW5kIHNldCBvdXRwdXQgaGlnaC4KPiAKPiBUaGlzIGRvZXMgZml4IGZyZWV6 ZSBhdCBpbml0aWFsaXphdGlvbiBkdWUgcGluY3RybCBiZWluZyBpbiBpbnB1dAo+IHN0YXRlLgo+ IAo+IFJlcG9ydGVkLWJ5OiBNYXJ0aW4gRmlsbGEgPGZyZWVic2RAc3lzY3RsLmN6PiAjIHJlcG9y dGVkIGJ5IHByaXZhdGUgbWVzc2FnZQo+IFNpZ25lZC1vZmYtYnk6IERhdmlkIEhlaWRlbGJlcmcg PGRhdmlkQGl4aXQuY3o+Cj4gLS0tCj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmsz NTY4LWJwaS1yMi1wcm8uZHRzIHwgNiArKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3Jr MzU2OC1icGktcjItcHJvLmR0cyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTY4 LWJwaS1yMi1wcm8uZHRzCj4gaW5kZXggNGQzZWJlNTBiOTBiYS4uYjRjOGFiZTM3ZDFmMyAxMDA2 NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2OC1icGktcjItcHJv LmR0cwo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LWJwaS1yMi1w cm8uZHRzCj4gQEAgLTEyMSw2ICsxMjEsOCBAQCB2Y2MzdjNfcGk2Y18wNTogcmVndWxhdG9yLXZj YzN2My1waTZjLTA1IHsKPiAgCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwzMzAwMDAwPjsK PiAgCQllbmFibGUtYWN0aXZlLWhpZ2g7Cj4gIAkJZ3Bpb3MgPSA8JmdwaW8wIFJLX1BENCBHUElP X0FDVElWRV9ISUdIPjsKPiArCQlwaW5jdHJsLTAgPSA8JnBpNmNwY2llX2VuYWJsZV9oPjsKPiAr CQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoKcGxlYXNlIG1vZGVsIGhhcmR3YXJlIG5vdCBo b3cgeW91IHdhbnQgdG8gdXNlIGl0LgoKVGhlIHBpNmMgaW4gdGhlIHBpbi1uYW1lIHN1Z2dlc3Rz LCB0aGF0IHRoaXMgaXMgYSBEaW9kZXMgY2xvY2stZ2VuZXJhdG9yCnRoYXQgY3JlYXRlcyB0aGUg MTAwTUh6IGZyZXF1ZW5jeSBmb3IgUENJZSBbMF0gLgoKUGxlYXNlIHNlZSBbMV0gZm9yIG9uZSBw b3NzaWJsZSB2YXJpYW50IHRvIG1vZGVsIHRoaXMuCgoKSGVpa28KClswXSBodHRwczovL3d3dy5k aW9kZXMuY29tL3BhcnQvdmlldy9QSTZDRzMzNjAyQyBvciBzb21lIHZhcmlhbnQgb2YgaXQKWzFd IGh0dHA6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzIwMjYwMjEwMDgwMzAzLjY4MDQwMy0xLWhlaWtv QHNudGVjaC5kZQoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1yb2NrY2hpcAo=