From: Thomas Monjalon <thomas@monjalon.net>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com,
Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/bnxt: fix cleanup and check for ulp context alloc
Date: Wed, 05 Aug 2020 22:27:11 +0200 [thread overview]
Message-ID: <3405053.XWxjWNVelI@thomas> (raw)
In-Reply-To: <20200731172302.5292-4-ajit.khaparde@broadcom.com>
31/07/2020 19:23, Ajit Khaparde:
> From: Somnath Kotur <somnath.kotur@broadcom.com>
>
> Set ulp_ctx explicitly to NULL in ulp_ctx_deinit() so that representor
> init is aborted if parent ulp context is not initialized.
> Also check for the same before creation of port default rules.
> Additional checks in VF rep dev ops for proper parent dev initialization
Looks like it should be separate patche.
I don't know what is "ulp", but if it an acronym,
it should be in capital letters.
> Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
> Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init")
Not clear it is a fix.
Looks like adding more checks.
> Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Reviewed-by should be below Signed-off-by.
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
next prev parent reply other threads:[~2020-08-05 20:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 14:03 [dpdk-dev] [PATCH 0/4] bnxt patches Somnath Kotur
2020-07-29 14:03 ` [dpdk-dev] [PATCH 1/4] net/bnxt: configure loopback parif for full offload egress flows Somnath Kotur
2020-07-29 21:23 ` [dpdk-dev] [PATCH 0/4] bnxt patches Ajit Khaparde
2020-07-31 17:22 ` [dpdk-dev] [PATCH v2 " Ajit Khaparde
2020-07-31 17:22 ` [dpdk-dev] [PATCH v2 1/4] net/bnxt: fix loopback parif for egress flows Ajit Khaparde
2020-08-05 20:29 ` Thomas Monjalon
2020-07-31 17:23 ` [dpdk-dev] [PATCH v2 2/4] net/bnxt: fix lookup for default parif action record Ajit Khaparde
2020-08-05 20:28 ` Thomas Monjalon
2020-08-06 1:27 ` Kishore Padmanabha
2020-07-31 17:23 ` [dpdk-dev] [PATCH v2 3/4] net/bnxt: fix cleanup and check for ulp context alloc Ajit Khaparde
2020-08-05 20:27 ` Thomas Monjalon [this message]
2020-07-31 17:23 ` [dpdk-dev] [PATCH v2 4/4] net/bnxt: fix vfrep add when VF interface is down Ajit Khaparde
2020-08-05 20:37 ` Thomas Monjalon
2020-09-02 5:31 ` [dpdk-dev] [PATCH v3 0/4] bnxt patches Ajit Khaparde
2020-09-02 5:31 ` [dpdk-dev] [PATCH v3 1/4] net/bnxt: configure loopback parif for egress flows Ajit Khaparde
2020-09-02 5:31 ` [dpdk-dev] [PATCH v3 2/4] net/bnxt: lookup default action record parif Ajit Khaparde
2020-09-02 5:31 ` [dpdk-dev] [PATCH v3 3/4] net/bnxt: cleanups and checks ULP context allocation Ajit Khaparde
2020-09-02 5:31 ` [dpdk-dev] [PATCH v3 4/4] net/bnxt: fix VF representor port add Ajit Khaparde
2020-09-02 19:16 ` [dpdk-dev] [PATCH v3 0/4] bnxt patches Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3405053.XWxjWNVelI@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=venkatkumar.duvvuru@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.