All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: chunbo.luo@windriver.com
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [POWERPC] mpc7448hpc2.dts: remove chosen node from dts
Date: Mon, 30 Jun 2008 18:22:09 +0200	[thread overview]
Message-ID: <34080997e6c29d809a38331f88caf3cf@kernel.crashing.org> (raw)
In-Reply-To: <1214795032.9125.7.camel@pek-cluo>

> Modern versions of u-boot create a chosen node automatically.  So if
> we set the chosen node in the dts file, there will be 2 chosen nodes
> passed in to the kernel,

That's a bug in uboot, then: when it creates a property, it should
delete an already existing property with the same name in that node.

> and the kernel command line will be taken from
> the wrong node.  So, remove the extra chosen node from the dts file.

This will cause a regression for people using an older version of
uboot.  No idea how important that is.


Segher

  reply	other threads:[~2008-06-30 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30  3:03 [POWERPC] mpc7448hpc2.dts: remove chosen node from dts Chunbo Luo
2008-06-30 16:22 ` Segher Boessenkool [this message]
2008-06-30 18:45   ` Scott Wood
  -- strict thread matches above, loose matches on Subject: below --
2008-06-30  4:37 Chunbo Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34080997e6c29d809a38331f88caf3cf@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=chunbo.luo@windriver.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.