From: Thomas Monjalon <thomas@monjalon.net>
To: Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ray Kinsella <mdr@ashroe.eu>,
dev@dpdk.org, ferruh.yigit@amd.com, bruce.richardson@intel.com,
konstantin.v.ananyev@yandex.ru, ajit.khaparde@broadcom.com,
jerinj@marvell.com
Subject: Re: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api
Date: Tue, 12 Jul 2022 16:04:06 +0200 [thread overview]
Message-ID: <3410736.z0yIoBN5P9@thomas> (raw)
In-Reply-To: <SJ0PR18MB441316DDE6875571E39719EAC1839@SJ0PR18MB4413.namprd18.prod.outlook.com>
07/07/2022 15:38, Satha Koteswara Rao Kottidi:
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > On 7/1/22 18:32, skoteshwar@marvell.com wrote:
> > > +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate``
> > > in Mbps. + This parameter declared as uint16_t, queue rate limited to
> > > 64Gbps. +``rate``
> > > + parameter will be modified to uint64_t in DPDK 22.11 so that it can
> > > +work for
> > > + more than 64Gbps.
> >
> > I fully agree that uint16_t is not enough, but I'd like to understand the
> > reason behind uint64_t vs uint32_t. It looks like uint32_t is more than
> > enough.
> yes uint32_t is enough, proposed uint64_t so that the rate in TM shaper profile is also uint64_t in bps
I don't see how both are related.
Why not stick to uint32_t for this parameter?
Also I'm not sure it is breakage.
If it was, it could have been handled with function versioning.
But anyway it is a small change, I am OK with uint32_t.
next prev parent reply other threads:[~2022-07-12 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 15:32 [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api skoteshwar
2022-07-07 12:52 ` Andrew Rybchenko
2022-07-07 13:38 ` [EXT] " Satha Koteswara Rao Kottidi
2022-07-12 13:10 ` Satha Koteswara Rao Kottidi
2022-07-12 14:04 ` Thomas Monjalon [this message]
2022-07-13 4:04 ` Satha Koteswara Rao Kottidi
2022-07-13 6:26 ` [PATCH v2] " skoteshwar
2022-07-13 6:46 ` Jerin Jacob
2022-07-15 13:25 ` [PATCH v3] doc: announce changes to rte_eth_set_queue_rate_limit API skoteshwar
2022-07-15 14:23 ` Andrew Rybchenko
2022-07-15 16:29 ` Ajit Khaparde
2022-07-16 18:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3410736.z0yIoBN5P9@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mdr@ashroe.eu \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.