From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2F69606A31C for ; Tue, 20 Oct 2026 07:43:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cRt7jljb; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=ceIP9DQr Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xJ4Vb-0001dC-7P; Tue, 20 Oct 2026 03:43:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xJ4Va-0001cm-0b for qemu-devel@nongnu.org; Tue, 20 Oct 2026 03:43:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xJ4VY-0005jy-H6 for qemu-devel@nongnu.org; Tue, 20 Oct 2026 03:43:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792482219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=krdXaPnFGrq42mp4rmeldNAjyfxHL9My08C1j3HYO0k=; b=cRt7jljb2XzgA/g863l7xOYPkJ15hGOyGmiGTT/V7R1cYLO6ueQbd5gXYUq3OGTlaagP1j Ma44bKno7U9snmwO1yh21OESZtaRkq29nL6kQx10X+um6M5nvF6CfFAS+tovWeCyR8FKxV wsZtT7pmU2YI1TEH+FKtEag55qGolV8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-gI8gb8OgP9u84Be7dr0yGg-1; Tue, 20 Oct 2026 07:43:36 +0000 X-MC-Unique: gI8gb8OgP9u84Be7dr0yGg-1 X-Mimecast-MFC-AGG-ID: gI8gb8OgP9u84Be7dr0yGg_1792482215 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49febef74e3so3004225e9.0 for ; Tue, 20 Oct 2026 00:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792482215; x=1793087015; darn=nongnu.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=krdXaPnFGrq42mp4rmeldNAjyfxHL9My08C1j3HYO0k=; b=ceIP9DQrbtC+a67NU5EHv0Ecoih/YPbXA6zi2Ya4Ssrgn7yofK7eu59bWdL+Z695mf LHVvL/SINcfS6iJ7pD78uwKW/M4zRZ++VJafZvPJgJ3ZyTQvV2oaxhGUq1PsHWyrehOf rUFElimBKq81up6eOvCSfSxJwwC7DR9nLNVb2RjYUfCli2Ix9WEKPuUbW5zS/Ysn94U8 wJkwZGEcyB+yl7lkk7q6TUb7DQfAL0y/qY4BB8flRcHVHtwsYUJRUeTQB0rrGmzswLTn kkcEyW+kAe8Ih5/7PsI7cMV0jeRl3Qc1zZO/Q1DJ+N0/cv/PmENrOm2mAXAVsy+uJGas VluQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792482215; x=1793087015; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=krdXaPnFGrq42mp4rmeldNAjyfxHL9My08C1j3HYO0k=; b=iPMaLV9rmvFJEgjT3oE9o+LkYM07/R9R+1J/ZLMpKROPRAr9TNPKm2hFOiYjMZtdIS xsBqDGmXnyTOP54ixl74KuhvVkDZ2QCXtsDNIC2QrgajHhWHWAMkZRoYP9Mx9pqSU+9m o31OwTUNnTz1gTVjjDOhTQjZvPIqOEHAtH8nMYXcvQPJ9EUP/au1NX4IXA6/YJeoBZZp y6WOegVmrBE8vLOzu93OBcr1/TWWVWetL8ClIU81nSWtCJgDDr1O3jWZcVu4BL8WJWBz wly+XWnkimvWiWCiv499P/T4A1HT8QZNmWp0wZRS3UWJzl4dNFPTGbIv2q8+PddGPSBa 3zvw== X-Forwarded-Encrypted: i=1; AKwUvBykfL4YDhzdEfdifCx+BlW/n5MyU9Q/pS3IdVLedAmT1QGDxpARUQoqLxPSXqyEMkfmUbqAz5STiXk1@nongnu.org X-Gm-Message-State: AFq9FYLJBbCdKNINbbugClLA1tyxq7c8l811FWEAu2YcHRxFYoWvLZVk 8GG5XZL5bX6e2HSi2pnLQ+5jRqpP5+mRJuHo6rqZ3eTfIfm18+/d4+Fyuuv9ojMvRk/ElTHs2fr tnLWsxDcQH4HMcu9cppnFcvN8OWCzZH9PqsBAe3N7ZFZXQBnG907w6QjK X-Gm-Gg: AYBFou1zB/eO+DTHWvi2FKp98MI1OiRwLj3SN7L/VIoIbd0OVkmT3Jo+htokYX0a8d2 kSajyDQoC2MmoP9uV6bQ2ZAZFio7NicM2r6iGo1h6B0G1V9qNtao1oE9zodmkAHMTla1apK9XoP hLRx3w7zHmQ88saz+EUl2QIOYKjorCBN0HI+4dk2s+Be1xD2IGN+0WYU0JLM2/k03vrSOHOj/Lr Eo0Ykp43fRL9mtOFW1AohmbG4pVLirtXE+AyW65jv71WYkNcr+j0v0FQ2dWsBT3/i2lK4bc+rPC LuIK2hzGmRK3de2vH2VmtWvzSsWz5uXJZw3peX/kYB7o93r8K8XgQJJN0ZFUWc5Dp5Eqb98oVA= = X-Received: by 2002:a05:600c:a20a:b0:4a1:8849:17ae with SMTP id 5b1f17b1804b1-4a1f4c4d361mr19444695e9.1.1792482215579; Tue, 20 Oct 2026 00:43:35 -0700 (PDT) X-Received: by 2002:a05:600c:a20a:b0:4a1:8849:17ae with SMTP id 5b1f17b1804b1-4a1f4c4d361mr19444355e9.1.1792482215196; Tue, 20 Oct 2026 00:43:35 -0700 (PDT) Received: from [192.168.0.9] ([47.64.113.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e1d6db78csm4418281f8f.2.2026.10.20.00.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2026 00:43:34 -0700 (PDT) Message-ID: <3412f9e1-1db8-4e6e-a4d0-e76876db157e@redhat.com> Date: Tue, 20 Oct 2026 09:43:32 +0200 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/19] tests/guest-debug: convert cmd to an qemu_cmd array To: =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Cc: Cornelia Huck , Thomas Huth , Ilya Leoshkevich , Paolo Bonzini , Christian Borntraeger , Peter Xu , Warner Losh , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Kyle Evans , Keith Busch , Matthew Rosato , Eric Farman , Zhao Liu , Ani Sinha , Anders Roxell , qemu-arm@nongnu.org, Song Gao , Peter Maydell , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier , qemu-s390x@nongnu.org, Pierrick Bouvier , Brad Smith , Brian Cain , Halil Pasic , Richard Henderson , "Michael S. Tsirkin" , Yoshinori Sato , Klaus Jensen , John Snow References: <20261019192704.3220373-1-alex.bennee@linaro.org> <20261019192704.3220373-10-alex.bennee@linaro.org> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20261019192704.3220373-10-alex.bennee@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.329, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 19/10/2026 21.26, Alex Bennée wrote: > As with gdb_cmd passing a plain string to a subprocess involves making > sure the escaping is correct so the underlying shell doesn't get > confused. Do the same as gdb_cmd and make the whole thing an array. > > There are a few minor wrinkles with when args.binary is expected so > add some comments for that. > > Suggested-by: Ilya Leoshkevich > Signed-off-by: Alex Bennée > --- > tests/guest-debug/run-test.py | 31 ++++++++++++++++++------------- > 1 file changed, 18 insertions(+), 13 deletions(-) Reviewed-by: Thomas Huth