From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID Date: Tue, 19 Aug 2014 11:57:22 +0200 Message-ID: <3413299.OcpyWkc82q@amdc1032> References: <1405500606-5752-1-git-send-email-drake@endlessm.com> <53F22D1B.4010900@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:11867 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbaHSJ5p (ORCPT ); Tue, 19 Aug 2014 05:57:45 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NAJ00IKRT049870@mailout1.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 19 Aug 2014 18:57:40 +0900 (KST) In-reply-to: <53F22D1B.4010900@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: Tomeu Vizoso , Daniel Drake , liquid.acid@gmx.net, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Marek Szyprowski Hi, On Monday, August 18, 2014 11:43:07 AM Kukjin Kim wrote: > On 08/12/14 08:06, Tomeu Vizoso wrote: > > Tested on an Odroid-U2: > > > > Tested-by: Tomeu Vizoso > > > > Thanks, > > > > Tomeu > > > > > > On 16 July 2014 10:50, Daniel Drake wrote: > >> The ODROID kernel shows that the PMIC interrupt line is hooked up > >> to pin GPX3-2. > >> > >> This is needed for the max77686-irq driver to create the PMIC IRQ > >> domain, which is needed by max77686-rtc. > >> > >> Signed-off-by: Daniel Drake > >> --- > >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > >> index 6d6d23c..cb6f55f 100644 > >> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > >> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > >> @@ -148,6 +148,10 @@ > >> > >> max77686: pmic@09 { > >> compatible = "maxim,max77686"; > >> + interrupt-parent =<&gpx3>; > >> + interrupts =<2 0>; > >> + pinctrl-names = "default"; > >> + pinctrl-0 =<&max77686_irq>; > >> reg =<0x09>; > >> #clock-cells =<1>; > >> > >> @@ -368,4 +372,11 @@ > >> samsung,pins = "gpx1-3"; > >> samsung,pin-pud =<0>; > >> }; > >> + > >> + max77686_irq: max77686-irq { > >> + samsung,pins = "gpx3-2"; > >> + samsung,pin-function =<0>; > >> + samsung,pin-pud =<0>; > >> + samsung,pin-drv =<0>; > >> + }; > >> }; > > Thanks, applied this series. Unfortunately these patches were applied to v3.18-next/dt-samsung branch and not v3.17-samsung-fixes-1 one. IMHO they should go to upstream ASAP as they fix the boot for ODROID boards and they cannot break anything as they are limited to ODROID dts files. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz) Date: Tue, 19 Aug 2014 11:57:22 +0200 Subject: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID In-Reply-To: <53F22D1B.4010900@samsung.com> References: <1405500606-5752-1-git-send-email-drake@endlessm.com> <53F22D1B.4010900@samsung.com> Message-ID: <3413299.OcpyWkc82q@amdc1032> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Monday, August 18, 2014 11:43:07 AM Kukjin Kim wrote: > On 08/12/14 08:06, Tomeu Vizoso wrote: > > Tested on an Odroid-U2: > > > > Tested-by: Tomeu Vizoso > > > > Thanks, > > > > Tomeu > > > > > > On 16 July 2014 10:50, Daniel Drake wrote: > >> The ODROID kernel shows that the PMIC interrupt line is hooked up > >> to pin GPX3-2. > >> > >> This is needed for the max77686-irq driver to create the PMIC IRQ > >> domain, which is needed by max77686-rtc. > >> > >> Signed-off-by: Daniel Drake > >> --- > >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > >> index 6d6d23c..cb6f55f 100644 > >> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > >> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > >> @@ -148,6 +148,10 @@ > >> > >> max77686: pmic at 09 { > >> compatible = "maxim,max77686"; > >> + interrupt-parent =<&gpx3>; > >> + interrupts =<2 0>; > >> + pinctrl-names = "default"; > >> + pinctrl-0 =<&max77686_irq>; > >> reg =<0x09>; > >> #clock-cells =<1>; > >> > >> @@ -368,4 +372,11 @@ > >> samsung,pins = "gpx1-3"; > >> samsung,pin-pud =<0>; > >> }; > >> + > >> + max77686_irq: max77686-irq { > >> + samsung,pins = "gpx3-2"; > >> + samsung,pin-function =<0>; > >> + samsung,pin-pud =<0>; > >> + samsung,pin-drv =<0>; > >> + }; > >> }; > > Thanks, applied this series. Unfortunately these patches were applied to v3.18-next/dt-samsung branch and not v3.17-samsung-fixes-1 one. IMHO they should go to upstream ASAP as they fix the boot for ODROID boards and they cannot break anything as they are limited to ODROID dts files. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics