All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com, david.marchand@redhat.com,
	olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru,
	chenbo.xia@intel.com, ktraynor@redhat.com,
	Ray Kinsella <mdr@ashroe.eu>,
	xuemingl@nvidia.com, matan@nvidia.com
Subject: Re: [PATCH] doc: announce transition to vDPA port close function
Date: Tue, 12 Jul 2022 14:26:40 +0200	[thread overview]
Message-ID: <3424161.GA8KThiCzi@thomas> (raw)
In-Reply-To: <1022991b-c3e5-1b1f-f713-f4769e6ca4e5@redhat.com>

12/07/2022 11:16, Maxime Coquelin:
> 
> On 5/18/21 09:34, Thomas Monjalon wrote:
> > There is a layer violation in the vDPA API which encourages to destroy
> > a full device with rte_dev_remove() instead of just closing the port.
> > The plan is to introduce a new function in 21.08, promote in 21.11,
> > and deprecate rte_vdpa_get_rte_device() in 21.11.
[...]
> > +* vdpa: The vDPA API should not try to manipulate or export
> > +  any ``rte_device`` object, which belongs to the bus layer.
> > +  The function ``rte_vdpa_get_rte_device()`` will be deprecated in 21.11,
> > +  when its usage will be replaced with a function ``rte_vdpa_close()``.
> > +  The new function should enter in 21.08 and get promoted to stable in 21.11.
> > +  A port close function will allow to close a single port without destroying
> > +  the rest of the device.
> 
> Maybe there was some changes since you posted the announce, but I don't
> see why rte_vdpa_close() would be needed. It seems the only user of
> rte_vdpa_get_rte_device() is the internal vDPA example, and it only use
> it to get and print the device name.

You're right, it was an oversight.
So we need only to get the rte_device name.

I propose to replace
	struct rte_device *rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev);
with
	const char *rte_vdpa_get_name(void);




  reply	other threads:[~2022-07-12 12:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  7:34 [dpdk-dev] [PATCH] doc: announce transition to vDPA port close function Thomas Monjalon
2021-05-18  7:42 ` Andrew Rybchenko
2021-08-02 22:49 ` Thomas Monjalon
2022-07-12  9:16 ` Maxime Coquelin
2022-07-12 12:26   ` Thomas Monjalon [this message]
2022-07-12 12:28     ` Thomas Monjalon
2022-07-12 12:40       ` Maxime Coquelin
2022-07-12 13:36 ` [PATCH v2] doc: announce transition to vDPA device name function Thomas Monjalon
2022-07-13 12:10   ` Maxime Coquelin
2022-07-13 12:37   ` Matan Azrad
2022-07-13 13:26   ` David Marchand
2022-07-13 14:07     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3424161.GA8KThiCzi@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=ktraynor@redhat.com \
    --cc=matan@nvidia.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mdr@ashroe.eu \
    --cc=olivier.matz@6wind.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.