From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] tst_kvcmp: Add support for extra kernel versions
Date: Mon, 24 Apr 2017 03:58:07 -0400 (EDT) [thread overview]
Message-ID: <343130515.905228.1493020687050.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170421155244.29773-1-chrubis@suse.cz>
----- Original Message -----
> This adds support for extra kernel versions to the tst_kvcmp shell
> helper.
>
> Now we can append the extra version(s) after the generic kernel version
> in the expression. For example to check for older kernel than
> 3.0 or in case of RHEL6 older than 2.6.32 we do:
>
> tst_kvcmp -lt '3.0 RHEL6:2.6.32'
>
> This commit also reduces the number of uname() syscalls needed to
> acquire the result as a side efect.
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> CC: Jan Stancek <jstancek@redhat.com>
> ---
>
> Jan can you please check that everything works fine when specifying extra
> version on RHEL? It seems that the only systems that are supported by extra
> kernel versions are RHEL5 and RHEL6 at the moment.
Should we print an error also if invalid distro is passed as parameter?
I'd add 4th number to all examples: "RHEL6:2.6.32" -> "RHEL6:2.6.32-77",
because all RHEL6 kernels are 2.6.32.
# uname -r
2.6.32-71.el6.x86_64
# ./tst_kvcmp -lt '3.11 RHEL6:2.6.32'; echo $?
1
# ./tst_kvcmp -lt '3.11 RHEL6:2.6.32-77'; echo $?
0
Otherwise it looks good to me.
Regards,
Jan
next prev parent reply other threads:[~2017-04-24 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 15:52 [LTP] [RFC] [PATCH] tst_kvcmp: Add support for extra kernel versions Cyril Hrubis
2017-04-24 7:58 ` Jan Stancek [this message]
2017-04-26 15:06 ` Cyril Hrubis
2017-04-27 8:28 ` Jan Stancek
2017-04-27 13:01 ` Cyril Hrubis
2017-04-27 13:21 ` Jan Stancek
2017-04-27 14:52 ` Cyril Hrubis
2017-04-28 6:58 ` Jan Stancek
2017-04-28 15:10 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=343130515.905228.1493020687050.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.