From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 10/10] drm/rcar-du/crc: Implement get_crc_sources callback Date: Thu, 12 Jul 2018 14:46:27 +0300 Message-ID: <3433641.J0DAlksvWM@avalon> References: <20180712083635.7472-1-mahesh1.kumar@intel.com> <20180712083635.7472-11-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 777B26EF60 for ; Thu, 12 Jul 2018 11:45:55 +0000 (UTC) In-Reply-To: <20180712083635.7472-11-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgTWFoZXNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHVyc2RheSwgMTIgSnVs eSAyMDE4IDExOjM2OjM1IEVFU1QgTWFoZXNoIEt1bWFyIHdyb3RlOgo+IFRoaXMgcGF0Y2ggaW1w bGVtZW50cyBnZXRfY3JjX3NvdXJjZXMgY2FsbGJhY2ssIHdoaWNoIHJldHVybnMgbGlzdCBvZgo+ IGFsbCB0aGUgY3JjIHNvdXJjZXMgc3VwcG9ydGVkIGJ5IGRyaXZlciBpbiBjdXJyZW50IHBsYXRm b3JtLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1haGVzaCBLdW1hciA8bWFoZXNoMS5rdW1hckBpbnRl bC5jb20+Cj4gQ2M6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJv YXJkLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMg fCAxMSArKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyAgfCAg MiArCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmggIHwgIDIgKwo+ICBk cml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2ttcy5jICB8IDY3ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMu aCAgfCAgMSArCj4gIDUgZmlsZXMgY2hhbmdlZCwgODMgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYwo+IGIvZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMgaW5kZXggNzJkYjE4MzRkZDUwLi44ZGEw NjRkYWY5YzkKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5jCj4g QEAgLTgwNyw2ICs4MDcsMTYgQEAgc3RhdGljIGludCByY2FyX2R1X2NydGNfdmVyaWZ5X2NyY19z b3VyY2Uoc3RydWN0Cj4gZHJtX2NydGMgKmNydGMsIHJldHVybiAwOwo+ICB9Cj4gCj4gK2NvbnN0 IGNoYXIgKmNvbnN0ICpyY2FyX2R1X2NydGNfZ2V0X2NyY19zb3VyY2VzKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YywKPiArCQkJCQkJc2l6ZV90ICpjb3VudCkKPiArewo+ICsJc3RydWN0IHJjYXJfZHVf Y3J0YyAqcmNydGMgPSB0b19yY2FyX2NydGMoY3J0Yyk7Cj4gKwlzdHJ1Y3QgcmNhcl9kdV9kZXZp Y2UgKnJjZHUgPSByY3J0Yy0+Z3JvdXAtPmRldjsKPiArCj4gKwkqY291bnQgPSByY2R1LT5zb3Vy Y2VzX2NvdW50Owo+ICsJcmV0dXJuIChjb25zdCBjaGFyICogY29uc3QqKXJjZHUtPnNvdXJjZXM7 Cj4gK30KClRoZSBsaXN0IG9mIHNvdXJjZXMgaGFzIHRvIGJlIHN0b3JlZCBwZXItQ1JUQywgYXMg aW4gbW9zdCBjYXNlcyBwbGFuZXMgYXJlIG5vdCAKc2hhcmVkIGJldHdlZW4gQ1JUQ3Mgb24gR2Vu MyBoYXJkd2FyZSB3aGVyZSBDUkMgY29tcHV0YXRpb24gaXMgYXZhaWxhYmxlLiBPbiAKR2VuMiBo YXJkd2FyZSBwbGFuZXMgYXJlIHNoYXJlZCBiZXR3ZWVuIENSVENzIChidXQgaW4gZ3JvdXBzIG9m IHR3byBDUlRDcyksIApidXQgQ1JDIGNvbXB1dGF0aW9uIGlzbid0IGF2YWlsYWJsZSwgc28geW91 IHNob3VsZG4ndCBjb21wdXRlIHRoZSBsaXN0IG9mIApzb3VyY2VzIGluIHRoYXQgY2FzZS4KCj4g IHN0YXRpYyBpbnQgcmNhcl9kdV9jcnRjX3NldF9jcmNfc291cmNlKHN0cnVjdCBkcm1fY3J0YyAq Y3J0YywKPiAgCQkJCSAgICAgICBjb25zdCBjaGFyICpzb3VyY2VfbmFtZSkKPiAgewo+IEBAIC04 OTgsNiArOTA4LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19mdW5jcyBjcnRjX2Z1 bmNzX2dlbjMgPSB7Cj4gIAkuZGlzYWJsZV92YmxhbmsgPSByY2FyX2R1X2NydGNfZGlzYWJsZV92 YmxhbmssCj4gIAkuc2V0X2NyY19zb3VyY2UgPSByY2FyX2R1X2NydGNfc2V0X2NyY19zb3VyY2Us Cj4gIAkudmVyaWZ5X2NyY19zb3VyY2UgPSByY2FyX2R1X2NydGNfdmVyaWZ5X2NyY19zb3VyY2Us Cj4gKwkuZ2V0X2NyY19zb3VyY2VzID0gcmNhcl9kdV9jcnRjX2dldF9jcmNfc291cmNlcywKPiAg fTsKPiAKPiAgLyogLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJf ZHVfZHJ2LmMgaW5kZXggMDJhZWU2Y2IwZTUzLi5iMmM5YjdlODYyZDUKPiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+IEBAIC00MDEsNiArNDAxLDggQEAgc3RhdGlj IGludCByY2FyX2R1X3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+IAo+ICAJ ZHJtX2Rldl91bnJlZ2lzdGVyKGRkZXYpOwo+IAo+ICsJcmNhcl9kdV9jcmNfc291cmNlc19saXN0 X3VuaW5pdChyY2R1KTsKCkFzIHRoZSBzb3VyY2VzIGxpc3QgaGFzIHRvIGJlIHN0b3JlZCBwZXIt Q1JUQywgeW91IGNhbiBtb3ZlIHRoaXMgdG8gdGhlIENSVEMgCmNsZWFudXAgaGFuZGxlci4KCj4g IAlpZiAocmNkdS0+ZmJkZXYpCj4gIAkJZHJtX2ZiZGV2X2NtYV9maW5pKHJjZHUtPmZiZGV2KTsK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuaAo+ IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuaCBpbmRleCBiM2EyNWU4ZTA3 ZDAuLmZlMGUyZWM3MjRiNQo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1 L3JjYXJfZHVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Ry di5oCj4gQEAgLTkyLDYgKzkyLDggQEAgc3RydWN0IHJjYXJfZHVfZGV2aWNlIHsKPiAKPiAgCXVu c2lnbmVkIGludCBkcGFkMF9zb3VyY2U7Cj4gIAl1bnNpZ25lZCBpbnQgdnNwZDFfc2luazsKPiAr CWNoYXIgKipzb3VyY2VzOwoKTGV0J3MgbWFrZSB0aGlzIGNvbnN0LgoKPiArCXNpemVfdCBzb3Vy Y2VzX2NvdW50OwoKSXQncyBub3QgYSBzaXplIGJ1dCBhIG51bWJlciBvZiBlbGVtZW50cywgSSdk IHVzZSB1bnNpZ25lZCBpbnQuCgo+ICB9Owo+IAo+ICBzdGF0aWMgaW5saW5lIGJvb2wgcmNhcl9k dV9oYXMoc3RydWN0IHJjYXJfZHVfZGV2aWNlICpyY2R1LAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2ttcy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1k dS9yY2FyX2R1X2ttcy5jIGluZGV4IGYwYmM3Y2MwZTkxMy4uYzc0Y2VkNDgwYzc0Cj4gMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfa21zLmMKPiBAQCAtNDIxLDYgKzQyMSw3MCBA QCBzdGF0aWMgaW50IHJjYXJfZHVfcHJvcGVydGllc19pbml0KHN0cnVjdAo+IHJjYXJfZHVfZGV2 aWNlICpyY2R1KSByZXR1cm4gMDsKPiAgfQo+IAo+ICtzdGF0aWMgdm9pZCByY2FyX2R1X2NyY19z b3VyY2VzX2xpc3RfaW5pdChzdHJ1Y3QgcmNhcl9kdV9kZXZpY2UgKnJjZHUpCj4gK3sKPiArCXN0 cnVjdCBkcm1fZGV2aWNlICpkZXYgPSByY2R1LT5kZGV2Owo+ICsJc3RydWN0IGRybV9wbGFuZSAq cGxhbmU7Cj4gKwljaGFyICoqc291cmNlczsKPiArCXNpemVfdCBjb3VudDsKPiArCWludCBpID0g MDsKCmkgaXMgbmV2ZXIgbmVnYXRpdmUsIHlvdSBjYW4gbWFrZSBpdCBhbiB1bnNpZ25lZCBpbnQu Cgo+ICsJLyogcmVzZXJ2ZSAxIGZvciAiYXV0byIgc291cmNlICovCj4gKwljb3VudCA9IDE7Cj4g Kwo+ICsJZHJtX2Zvcl9lYWNoX3BsYW5lKHBsYW5lLCBkZXYpCj4gKwkJY291bnQrKzsKPiArCj4g Kwlzb3VyY2VzID0ga21hbGxvY19hcnJheShjb3VudCwgc2l6ZW9mKGNoYXIgKiksIEdGUF9LRVJO RUwpOwo+ICsJaWYgKCFzb3VyY2VzKQo+ICsJCWdvdG8gZmFpbDsKPiArCj4gKwlzb3VyY2VzW2ld ID0ga3N0cmR1cCgiYXV0byIsIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFzb3VyY2VzW2ldKQo+ICsJ CWdvdG8gZmFpbF9ub19tZW07Cj4gKwo+ICsJaSsrOwo+ICsJZHJtX2Zvcl9lYWNoX3BsYW5lKHBs YW5lLCBkZXYpIHsKPiArCQljaGFyIG5hbWVbMTZdOwo+ICsKPiArCQlzcHJpbnRmKG5hbWUsICJw bGFuZSVkIiwgcGxhbmUtPmJhc2UuaWQpOwo+ICsJCXNvdXJjZXNbaV0gPSBrc3RyZHVwKG5hbWUs IEdGUF9LRVJORUwpOwo+ICsJCWlmICghc291cmNlc1tpXSkKPiArCQkJZ290byBmYWlsX25vX21l bTsKPiArCQlpKys7Cj4gKwl9Cj4gKwo+ICsJcmNkdS0+c291cmNlcyA9IHNvdXJjZXM7Cj4gKwly Y2R1LT5zb3VyY2VzX2NvdW50ID0gY291bnQ7Cj4gKwlyZXR1cm47Cj4gKwo+ICtmYWlsX25vX21l bToKPiArCXdoaWxlIChpID4gMCkgewo+ICsJCWktLTsKPiArCQlrZnJlZShzb3VyY2VzW2ldKTsK PiArCX0KPiArCWtmcmVlKHNvdXJjZXMpOwo+ICtmYWlsOgo+ICsJcmNkdS0+c291cmNlcyA9IE5V TEw7Cj4gKwlyY2R1LT5zb3VyY2VzX2NvdW50ID0gMDsKPiArfQo+ICsKPiArdm9pZCByY2FyX2R1 X2NyY19zb3VyY2VzX2xpc3RfdW5pbml0KHN0cnVjdCByY2FyX2R1X2RldmljZSAqcmNkdSkKPiAr ewo+ICsJaW50IGkgPSByY2R1LT5zb3VyY2VzX2NvdW50OwoKaSBpcyBuZXZlciBuZWdhdGl2ZSwg eW91IGNhbiBtYWtlIGl0IGFuIHVuc2lnbmVkIGludC4KCj4gKwlpZiAoIXJjZHUtPnNvdXJjZXMp Cj4gKwkJcmV0dXJuOwo+ICsKPiArCXdoaWxlIChpID4gMCkgewo+ICsJCWktLTsKPiArCQlrZnJl ZShyY2R1LT5zb3VyY2VzW2ldKTsKPiArCX0KCkFueXRoaW5nIHdyb25nIHdpdGggYSBjbGFzc2lj IGZvciBsb29wID8KCglmb3IgKGkgPSAwOyBpIDwgcmNkdS0+c291cmNlc19jb3VudDsgKytpKQoJ CWtmcmVlKHJjZHUtPnNvdXJjZXNbaV0pOwoKPiArCWtmcmVlKHJjZHUtPnNvdXJjZXMpOwo+ICsJ cmNkdS0+c291cmNlcyA9IE5VTEw7Cj4gKwlyY2R1LT5zb3VyY2VzX2NvdW50ID0gMDsKPiArfQo+ ICsKPiAgc3RhdGljIGludCByY2FyX2R1X3ZzcHNfaW5pdChzdHJ1Y3QgcmNhcl9kdV9kZXZpY2Ug KnJjZHUpCj4gIHsKPiAgCWNvbnN0IHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAgPSByY2R1LT5kZXYt Pm9mX25vZGU7Cj4gQEAgLTU5MSw2ICs2NTUsOSBAQCBpbnQgcmNhcl9kdV9tb2Rlc2V0X2luaXQo c3RydWN0IHJjYXJfZHVfZGV2aWNlICpyY2R1KQo+ICAJCQlyZXR1cm4gcmV0Owo+ICAJfQo+IAo+ ICsJLyogSW5pdGlhbGl6ZSBDUkMtc291cmNlcyBsaXN0ICovCj4gKwlyY2FyX2R1X2NyY19zb3Vy Y2VzX2xpc3RfaW5pdChyY2R1KTsKPiArCj4gIAkvKiBJbml0aWFsaXplIHRoZSBlbmNvZGVycy4g Ki8KPiAgCXJldCA9IHJjYXJfZHVfZW5jb2RlcnNfaW5pdChyY2R1KTsKPiAgCWlmIChyZXQgPCAw KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2ttcy5oCj4g Yi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2ttcy5oIGluZGV4IDA3OTUxZDVmZTM4 Yi4uMjkxMjBlNmI1NjY2Cj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUv cmNhcl9kdV9rbXMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfa21z LmgKPiBAQCAtMzIsNiArMzIsNyBAQCBzdHJ1Y3QgcmNhcl9kdV9mb3JtYXRfaW5mbyB7Cj4gIGNv bnN0IHN0cnVjdCByY2FyX2R1X2Zvcm1hdF9pbmZvICpyY2FyX2R1X2Zvcm1hdF9pbmZvKHUzMiBm b3VyY2MpOwo+IAo+ICBpbnQgcmNhcl9kdV9tb2Rlc2V0X2luaXQoc3RydWN0IHJjYXJfZHVfZGV2 aWNlICpyY2R1KTsKPiArdm9pZCByY2FyX2R1X2NyY19zb3VyY2VzX2xpc3RfdW5pbml0KHN0cnVj dCByY2FyX2R1X2RldmljZSAqcmNkdSk7Cj4gCj4gIGludCByY2FyX2R1X2R1bWJfY3JlYXRlKHN0 cnVjdCBkcm1fZmlsZSAqZmlsZSwgc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJc3RydWN0 IGRybV9tb2RlX2NyZWF0ZV9kdW1iICphcmdzKTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5j aGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK