From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: "Greg Kurz" <groug@kaod.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] tests/9pfs: fix mkdir() being called twice
Date: Tue, 25 Jan 2022 18:51:54 +0100 [thread overview]
Message-ID: <3438847.JacDP26HMr@silver> (raw)
In-Reply-To: <20220125163346.4cb345ce@bahia>
On Dienstag, 25. Januar 2022 16:33:46 CET Greg Kurz wrote:
> On Sat, 22 Jan 2022 20:12:16 +0100
>
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > The 9p test cases use mkdtemp() to create a temporary directory for
> > running the 'local' 9p tests with real files/dirs. Unlike mktemp()
> > which only generates a unique file name, mkdtemp() also creates the
> > directory, therefore the subsequent mkdir() was wrong and caused
> > errors on some systems.
> >
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > Fixes: 136b7af2 (tests/9pfs: fix test dir for parallel tests)
> > Reported-by: Daniel P. Berrangé <berrange@redhat.com>
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/832
> > ---
>
> Reviewed-by: Greg Kurz <Greg Kurz <groug@kaod.org>
Hey, a live sign. :)
> Unrelated, the template pointer is leaked. It looks like g_autofree would
> help here. I'll post a follow-up to fix that.
This man knows what I like to read!
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2022-01-25 17:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 19:12 [PATCH] tests/9pfs: fix mkdir() being called twice Christian Schoenebeck
2022-01-22 20:45 ` Christian Schoenebeck
2022-01-25 15:12 ` Daniel P. Berrangé
2022-01-25 15:33 ` Greg Kurz
2022-01-25 17:51 ` Christian Schoenebeck [this message]
2022-01-26 10:22 ` Greg Kurz
2022-01-26 15:29 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3438847.JacDP26HMr@silver \
--to=qemu_oss@crudebyte.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.