From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 03/14] ring: eliminate duplication of size and mask fields Date: Mon, 27 Mar 2017 15:13:04 +0200 Message-ID: <3439297.P6JfIMhuDO@xps13> References: <20170307113217.11077-1-bruce.richardson@intel.com> <2476675.J1ds0gYDs0@xps13> <20170327101549.GB18148@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com To: Bruce Richardson Return-path: Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 00199FAEA for ; Mon, 27 Mar 2017 15:13:06 +0200 (CEST) Received: by mail-lf0-f43.google.com with SMTP id j90so20760394lfk.2 for ; Mon, 27 Mar 2017 06:13:06 -0700 (PDT) In-Reply-To: <20170327101549.GB18148@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-27 11:15, Bruce Richardson: > On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote: > > 2017-03-24 17:09, Bruce Richardson: > > > The size and mask fields are duplicated in both the producer and > > > consumer data structures. Move them out of that into the top level > > > structure so they are not duplicated. > > > > > > Signed-off-by: Bruce Richardson > > > Acked-by: Olivier Matz > > > > Sorry Bruce, I encounter this error: > > > > fatal error: no member named 'size' in 'struct rte_ring_headtail' > > if (r->prod.size >= ring_size) { > > ~~~~~~~ ^ > > > Ok, I think I've found it now using git grep. I assume this is in the > crypto code which is disabled by default, right? Right, sorry for forgetting the context.