From: Nilay Shroff <nilay@linux.ibm.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de
Subject: Re: [PATCHv2 2/3] nvme-multipath: rescan siblings on last path removal
Date: Fri, 27 Feb 2026 21:27:26 +0530 [thread overview]
Message-ID: <343bc90a-e502-4178-86ab-74e0fa4f33ff@linux.ibm.com> (raw)
In-Reply-To: <aaG5dpk_w16ZN4uO@kbusch-mbp>
On 2/27/26 9:04 PM, Keith Busch wrote:
> On Fri, Feb 27, 2026 at 12:29:00PM +0530, Nilay Shroff wrote:
>> Should we consider reordering patches 2/3 and 3/3? It seems like this
>> patch depends on the changes introduced in 3/3.
>>
>> Without the updates from 3/3, if delayed head removal is still in effect
>> and the NSIDs are recycled with mismatched identifiers, a forced rescan
>> of the sibling controller may still fail to instantiate the namespace.
>> In that case, requeueing the scan alone might not be sufficient.
>
> But the other way around, if we're racing with another controller's scan
> to complete the last path removal, then the delayed work hasn't been
> scheduled yet so patch 3 has a significant gap without patch 2 preceding
> it.
Yes, that’s also correct — both patches depend on each other to some extent.
If the user does not configure delayed_removal_sec, then patch 2 by itself
is sufficient to resolve the race. So with that, overall, the changes look
good to me:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2026-02-27 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 18:32 [PATCHv2 0/3] nvme: multi-path scan races fixes Keith Busch
2026-02-26 18:32 ` [PATCHv2 1/3] nvme-multipath: fix leak on try_module_get failure Keith Busch
2026-02-26 18:32 ` [PATCHv2 2/3] nvme-multipath: rescan siblings on last path removal Keith Busch
2026-02-27 6:59 ` Nilay Shroff
2026-02-27 15:34 ` Keith Busch
2026-02-27 15:57 ` Nilay Shroff [this message]
2026-02-27 13:54 ` Christoph Hellwig
2026-02-26 18:32 ` [PATCHv2 3/3] nvme: fix unmatched id's under delayed path deletion Keith Busch
2026-02-27 5:55 ` Nilay Shroff
2026-02-27 13:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=343bc90a-e502-4178-86ab-74e0fa4f33ff@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.